Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
To:     corbet@lwn.net, mcgrof@kernel.org, keescook@chromium.org,
        yzaikin@google.com, linux-fsdevel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     akpm@linux-foundation.org, linux@rasmusvillemoes.dk,
        ebiggers@google.com, peterz@infradead.org, ying.huang@intel.com,
        gpiccoli@igalia.com, mchehab+huawei@kernel.org, Jason@zx2c4.com,
        daniel@iogearbox.net, robh@kernel.org, wangqing@vivo.com,
        prestwoj@gmail.com, dsahern@kernel.org,
        stephen.s.brennan@oracle.com, alejandro.j.jimenez@oracle.com
Subject: [RFC 1/1] kernel/sysctl: Add sysctl entry for crash_kexec_post_notifiers
Date:   Fri,  1 Apr 2022 16:23:00 -0400
Message-Id: <20220401202300.12660-2-alejandro.j.jimenez@oracle.com>
In-Reply-To: <20220401202300.12660-1-alejandro.j.jimenez@oracle.com>
References: <20220401202300.12660-1-alejandro.j.jimenez@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Zv1/rZJ1pvXYiyR8/+q7pcMDDrrRqSLoPs9DqtEVfT4VV9TEKtklBzIHDt7C?=
 =?us-ascii?Q?8cNWgLnxCYNBhIlqMRwEISpoxfiAmOkg+qeJvZhej8338dd51zLBIsjewDcQ?=
 =?us-ascii?Q?bo1DxKKukjLJAvFqzhNFQKTe9bgAEDxRff5zjwjpYJxr6dn0jJu6PQJHWuLs?=
 =?us-ascii?Q?ADmlfR+kEV3o4Eg2g7ldAHl3sdSFhTIFzQjyviHWDOvi1k1mAl4bnRi2jK4N?=
 =?us-ascii?Q?G/Vz00bmYKWjt4klQPsutRUqmNDkEfHVYEoTWDfePSbK/Hg3bFOUPQpWdGsR?=
 =?us-ascii?Q?JWPnt6OBVHkXn4Dj6nBaKJOH3fPOz+fhX8BnY704SCiZFXb67IV0G0qEKT2p?=
 =?us-ascii?Q?HmvcRqOyj5xCP0AFjFmWGJG2I9en4UfM+zZy8srezhodkhwyU2x9RwgoPnt8?=
 =?us-ascii?Q?YpBJAAZWhmp0SzzE+UG/cPG9d33/4bJ25J3CrgSXScEF6FMyy5DXyZqFvvOa?=
 =?us-ascii?Q?Yv6+wo3D+2ZCMuFLcOUeCkLQpPNH8KXWcVnbUAuxluMB8s0b4sn8yj0LMEjI?=
 =?us-ascii?Q?qeoob+3Du61mq9EljNNksxyXEiFiuIkoLKn2YqwwC3WkDkVtSR2OXAZLnct5?=
 =?us-ascii?Q?djHOL0okWiLxJs/pzRANVMddnqRbUYnyI+MyrCeauXjsFjJfjPMzZT7NpxYK?=
 =?us-ascii?Q?lYN27nKgM03lmKb2b3vg1P8ZaiUp6T0cn1RMI2t7SZRmwhkak678dshqWd3P?=
 =?us-ascii?Q?MF9+V/mqgytUeXeEcpUI/eK3z3oJ5+9T20IctwmIZyex/3UHpwcmvlYATxdd?=
 =?us-ascii?Q?rwAi1Lr2kR6BxorCAUQP444AeTgGynevwhFlLZvUD8/JsL47mCx09cBTkENR?=
 =?us-ascii?Q?xd/eQJCy2l7sNUpPM+pRvWM8fgdtAUJE1CWIb1JJsZiS/h75YXV2iqugPmy6?=
 =?us-ascii?Q?MNr1ani9hBIF55mqy1sZLF61l1YHOS+lquS+koEhpO7p/LhfxN6x2Cq13ON1?=
 =?us-ascii?Q?TXTJlozDu7V4rS6vF5pkEeP2WgIgZYxu5/XXVOp+nboNDDkrAuZMSOOmZUhW?=
 =?us-ascii?Q?2dvMtcbF0fg6ET7nYDopeEmLaUclQI/dSfKBpHjI8Iu+9PSTvvT6EwrpKey6?=
 =?us-ascii?Q?mjGzjCQ3cpMM7Sv2ufsEeyjVSmtDlcYHlSpRKIU0qjZQrGn6vtm4mxxpib53?=
 =?us-ascii?Q?4Pvsi0a6JkAqM90f1KGBfQgEJmlqi8j8oKn8WmDDGkETb/f9KmkmM7uSBluV?=
 =?us-ascii?Q?JuTA1COQg31rUILoLiR8AhPFQJGUAHidH8MMW19jdmqBB68U71yO/wMGibD9?=
 =?us-ascii?Q?gvHVLq8NOBzATigr1n68Mp2x8OtxKXtQ8HXLcgOQh0EmqePbUBvCRgXCwzdr?=
 =?us-ascii?Q?iA7Jui1C27TDG8do73Qj75fYP190HhN4E+TWDHJWrKiUJ4Y2XsUU1dUDwUSA?=
 =?us-ascii?Q?h+bYllRGvjCvpzbD2npPnplhGA5OFB9ubvups6rqN/unvUj1nTpcLv8pX+us?=
 =?us-ascii?Q?//TTwRN394BueIA4t3Mkdl7IKFL8ktCRWqLxeC6Q8V2attMmMgJz+Joi+OuX?=
 =?us-ascii?Q?NSruM9hOjwWQQVzuw5P4IKT1PAL6XE8olU1VHx3re/As6SHjX5fLIYYVFegY?=
 =?us-ascii?Q?WHDlGy/56jpsyBSbbB8h+OE8p32BQAbRd2McFIdwBM0JdTJD2bAA3g4Q7kE+?=
 =?us-ascii?Q?NjR9qNZ2D18HAHTNJghc32JVoTVPoWWbm0nbBeEMPlkwXn6BDSWeQBJNJsD+?=
 =?us-ascii?Q?x0iRL811utIWWjpQnh4lzDxzaAIYi9rQ08s/lzImjXhDbngl6uvjGXjmVa/U?=
 =?us-ascii?Q?loTFDYLcs7tJZ1iYiqA3hgNBMfPsZps=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d27d605-a5a4-4a5e-be66-08da141dfdc0
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5866.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 20:27:07.2408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d4G3ct08gXperrbh0IUUtwFEmnCS1BYQBD8NrJJAJLxvdYFkBMTEQAVyIFQ4E2odYdJHIVcgNrIX8ZKpNtLDTZOchj3xX6CUnS7A93bWkII=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5647
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-01_05:2022-03-30,2022-04-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204010097
X-Proofpoint-GUID: GOVPbhHXh64MnadK0BiKWv-LQ5lmEJmF
X-Proofpoint-ORIG-GUID: GOVPbhHXh64MnadK0BiKWv-LQ5lmEJmF
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Introduce a new sysctl:

  /proc/sys/kernel/crash_kexec_post_notifiers

that allows the crash_kexec_post_notifiers tunable to be listed, read, and
modified via sysctl(8) at runtime.

crash_kexec_post_notifiers can now be set via sysctl:

  # sysctl -w kernel.crash_kexec_post_notifiers=1

or using the sysfs entry:

 #  echo 0 > /sys/module/kernel/parameters/crash_kexec_post_notifiers

which is also available for other core kernel parameters like panic,
panic_print, and panic_on_warn.

Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
Reviewed-by: Stephen Brennan <stephen.s.brennan@oracle.com>
---
 Documentation/admin-guide/sysctl/kernel.rst | 8 ++++++++
 include/uapi/linux/sysctl.h                 | 1 +
 kernel/sysctl.c                             | 7 +++++++
 3 files changed, 16 insertions(+)

diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
index 1144ea3229a3..8e07121e2a58 100644
--- a/Documentation/admin-guide/sysctl/kernel.rst
+++ b/Documentation/admin-guide/sysctl/kernel.rst
@@ -213,6 +213,14 @@ If `core_pattern`_ does not include "%p" (default does not)
 and ``core_uses_pid`` is set, then .PID will be appended to
 the filename.
 
+crash_kexec_post_notifiers
+============
+
+Allow the callbacks in panic notifier list to be called before kdump and dumping
+kmsg.
+
+0 Do not call panic notifier list callbacks before kdump (default).
+1 Call panic notifier list callbacks before kdump.
 
 ctrl-alt-del
 ============
diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
index 6a3b194c50fe..921e3ea01881 100644
--- a/include/uapi/linux/sysctl.h
+++ b/include/uapi/linux/sysctl.h
@@ -154,6 +154,7 @@ enum
 	KERN_PANIC_ON_NMI=76, /* int: whether we will panic on an unrecovered */
 	KERN_PANIC_ON_WARN=77, /* int: call panic() in WARN() functions */
 	KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */
+	KERN_CRASH_KEXEC_POST_NOTIFIERS=79, /* bool: call panic notifier list before kdump */
 };
 
 
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 830aaf8ca08e..8e0be72b5fba 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -2339,6 +2339,13 @@ static struct ctl_table kern_table[] = {
 		.extra2		= SYSCTL_INT_MAX,
 	},
 #endif
+	{
+		.procname	= "crash_kexec_post_notifiers",
+		.data		= &crash_kexec_post_notifiers,
+		.maxlen		= sizeof(int),
+		.mode		= 0644,
+		.proc_handler	= proc_dobool,
+	},
 	{ }
 };
 
-- 
2.34.1