Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Mar 2022 15:17:22 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Tony Lindgren <tony@atomide.com>, Lee Jones <lee.jones@linaro.org>
Cc:     linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH 0/2] mfd: twlx030: i2c remove callback cleanup
Message-ID: <20220331131722.wt5uik3izzr7kewq@pengutronix.de>
References: <20220113101430.12869-1-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="k7bb3avtwrjcunmo"
Content-Disposition: inline
In-Reply-To: <20220113101430.12869-1-u.kleine-koenig@pengutronix.de>
Precedence: bulk


--k7bb3avtwrjcunmo
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 13, 2022 at 11:14:28AM +0100, Uwe Kleine-K=F6nig wrote:
> Hello,
>=20
> the remove paths of the twl4030 chip can fail and then returns an error
> code in twl_remove() early. This isn't a good thing, because the device
> will still go away with some resources not freed.
> For the twl6030 this cannot happen, and the first patch is just a small
> cleanup. For the twl4030 the situation is improved a bit: When the
> failure happens, the dummy slave devices are removed now.
>=20
> Note that twl4030_exit_irq() is incomplete. The irq isn't freed and
> maybe some more cleanup is missing which might boom if an irq triggers
> after the device is removed. Not sure that twl6030_exit_irq() is better
> in this regard.
>=20
> I noticed this issue because I work on making i2c_driver::remove return
> void as returning a value !=3D 0 there is almost always an error attached
> to wrong expectations.

It's one merge window ago now that I sent these two patches and didn't
get any feedback. Did this series fell through the cracks?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--k7bb3avtwrjcunmo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmJFqd8ACgkQwfwUeK3K
7AnLdwgAjHkq22/YPazauz9li4T4Gglucux/NLvOBjrtwIyk/K6zn7623YCWSdlK
NyV358wdTE69ID/SzlfwOFXzUyLx6XuH94galV4v/TDb0/SkpquraC6Q1R/EvnYJ
s1WrijKXQhlcfpv5pJQ/dIyJKiqi14uPhMuBWjNuF4UbXAWwBMLY+4h9KbpiS8xh
IyafzqeexB/3lcRDPOAwfREqMC72lkpCkLJJDkOidnkzmDsz5UUASXF2FD0nTEZN
+qjglyOImwcCE3S6+chwceGxLdo+wFmUO7/6Xow8UPhbQqEUCZPUx5Eh9JTIVSNC
SdDZDBX6BtI5fXXQLc84Kq/1gVBoYQ==
=xLPR
-----END PGP SIGNATURE-----

--k7bb3avtwrjcunmo--