Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c4b1e34f-453c-11b6-c083-2e5a638e8db1@linaro.org>
Date:   Fri, 1 Apr 2022 18:02:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] ASoC: samsung: Constify snd_soc_dapm_{route,widget}
 structs
Content-Language: en-US
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>,
        Manivannan Sadhasivam <mani@kernel.org>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-actions@lists.infradead.org,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
References: <20220330204227.25081-1-rikard.falkeborn@gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220330204227.25081-1-rikard.falkeborn@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 30/03/2022 22:42, Rikard Falkeborn wrote:
> These structs only have their address assigned to the
> dapm_{routes,widget} fields in the snd_soc_card struct,
> both which are pointers to const data. Make them const to
> allow the compiler to put them in read-only memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
>  sound/soc/samsung/bells.c      | 4 ++--
>  sound/soc/samsung/littlemill.c | 4 ++--
>  sound/soc/samsung/lowland.c    | 4 ++--
>  sound/soc/samsung/speyside.c   | 4 ++--
>  sound/soc/samsung/tobermory.c  | 4 ++--
>  5 files changed, 10 insertions(+), 10 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof