Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <e6b53360-6fa7-a295-cba1-9a27e2b3665f@seas.upenn.edu>
Date:   Sun, 3 Apr 2022 14:34:48 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] HID: hid-ntrig: fix the error handling code in
 ntrig_probe
Content-Language: en-US
To:     Jiri Kosina <jikos@kernel.org>,
        Mingxuan Xiang <mx_xiang@hust.edu.cn>
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Dongliang Mu <dzm91@hust.edu.cn>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220313150237.1214062-1-mx_xiang@hust.edu.cn>
 <nycvar.YFH.7.76.2203301722301.24795@cbobk.fhfr.pm>
From:   Rafi Rubin <rafi@seas.upenn.edu>
In-Reply-To: <nycvar.YFH.7.76.2203301722301.24795@cbobk.fhfr.pm>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

The writable parameters are also settable as module parameters and I suspect are not really widely used. I used them for tuning the defaults and dealing with unreliable devices, not in the course of normal use.  So I agree creation of the sysfs nodes 
should not block probing and using the device.

Thank you for working on the error handling,
Rafi