Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <3e1dfdde-d9f3-9e16-82a6-7b5497981bdd@gmail.com>
Date:   Sun, 3 Apr 2022 18:43:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] staging: r8188eu: simplify control flow
Content-Language: en-US
To:     Sevinj Aghayeva <sevinj.aghayeva@gmail.com>,
        Pavel Skripkin <paskripkin@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev
References: <20220403155111.GA333187@euclid>
 <ed0e9f7b-9ba9-b0c8-8261-397bf793b9b9@gmail.com>
 <CAMWRUK6K77KpRkCkruL=RQcmA1opbvapyPJOA-EFpYdXxY8ujQ@mail.gmail.com>
 <4ccc9ac3-c542-cd32-0cbb-7cdabbf0dbf9@gmail.com>
 <CAMWRUK7g7BqUL1NziBfbc6Epx7G8Xos47sKAtcimDZYmG-hVgA@mail.gmail.com>
From:   Michael Straube <straube.linux@gmail.com>
In-Reply-To: <CAMWRUK7g7BqUL1NziBfbc6Epx7G8Xos47sKAtcimDZYmG-hVgA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/3/22 18:29, Sevinj Aghayeva wrote:
> Ah, I see. You run it on an email file that contains the patch. I
> could reproduce what you saw when I ran checkpatch without any options
> on an email file. But my usual workflow is to modify a file, e.g.
> rtw_mlme.c and then run "checkpatch.pl -f rtw_mlme.c", in which case I
> cannot see the "Alignment should match" error. So it looks like if you
> do not specify -f then checkpatch.pl enables --strict option.
> 

Hi Sevinj,

I'm also not a checkpatch expert, but on my system this works without
--strict too. I applied your patch to my local tree and get:

/scripts/checkpatch.pl -f drivers/staging/r8188eu/core/rtw_mlme.c

[snip]

CHECK: Alignment should match open parenthesis
#1638: FILE: drivers/staging/r8188eu/core/rtw_mlme.c:1638:
+               if ((p->PMKIDList[i].bUsed) &&
+                               (!memcmp(p->PMKIDList[i].Bssid, bssid, 
ETH_ALEN)))

[snip]

You can also run checkpatch on the patch files (without -f).
Then it's easier to see if you introduced new issues.

regards,
Michael