Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 4 Apr 2022 18:31:51 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     David Kahurani <k.kahurani@gmail.com>
Cc:     netdev@vger.kernel.org,
        syzbot+d3dbdf31fbe9d8f5f311@syzkaller.appspotmail.com,
        davem@davemloft.net, jgg@ziepe.ca, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        phil@philpotter.co.uk, syzkaller-bugs@googlegroups.com,
        arnd@arndb.de, paskripkin@gmail.com
Subject: Re: [PATCH] net: ax88179: add proper error handling of usb read
 errors
Message-ID: <20220404153151.GF3293@kadam>
References: <20220404151036.265901-1-k.kahurani@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220404151036.265901-1-k.kahurani@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ncY0hGKqkN4Z5M9BzSOhYzONoYpzU424xtjgFY4CeK9udhxBXYLPwk3xtf62?=
 =?us-ascii?Q?VuZ0YSTrc3JHvW1X16c/VhetTJVFRs81UI4ozDRX5BuWOMdJXiuHV8rFg06w?=
 =?us-ascii?Q?iuzN+JhVQZyNLhDDWa3axt97n8DzkQPxUMeEttQtDSUWhjuO0s+7DlOYO38z?=
 =?us-ascii?Q?csKC1vU8C0MdPEeA4bMvXJlhpRo2Tj4WEi8rEwIlXtBYh6fK7KX3onMxFpiI?=
 =?us-ascii?Q?2FZVp4jOpdA2/9wMnsP8brWJMjvd7fzg5mWX/axmMoLHGY78W2YfHEBqyP5s?=
 =?us-ascii?Q?fL8kFXi7mnsC2aR8aXgqky4j6xLczDcFSfF8beSHcp2V3OdEdq2RLphwKs+e?=
 =?us-ascii?Q?BPDGfuPmGaROcOLoODJe2dimbRwLv6Bd9XY8ICcBDNDsy89Js0NPgYUovN+S?=
 =?us-ascii?Q?v6uy/CR+GMAeCDkkN4glLlNNw3tj4lgPMITB2oluzPNVhuHzdQNZ+jtyYOvI?=
 =?us-ascii?Q?Q6x93cVoiun3BHrnOJex+UTC/G33z0AqCeRnxQn7tWgF2u1oF0RAnhdvp0jI?=
 =?us-ascii?Q?oNtYe8ddKfJI64EqmeQ9w73pAnYARTYCvCvJlwd/DNA4vL3SzYyEf8JKcUxX?=
 =?us-ascii?Q?Hqb0AgACO/hOi/ah73s2t/Oox6ChMqbFhwE0PmBUr0+HT0TDg3q+d+Oobvus?=
 =?us-ascii?Q?GHQI+AVbiCizfUJqQ/UY5QTJR2Bb9crJNiiSqYAGFUo8cg2n5YSvsbbb5cxV?=
 =?us-ascii?Q?20IxSziyX8Igh16hn6fJ9MODV2OSaxOcvZbmcLr6wU11vA+FWzd1Ip5Jiv31?=
 =?us-ascii?Q?7LEkZVHaTEdw6tpgmVhlJA31O5xEIFvPaiZIC7AUxLd+SIC3BMaKOcncmMx9?=
 =?us-ascii?Q?O6EyUXaxoVkOhSroVsCe3pu0d9LToBA3ml8I0OBPLchQ/XB82Yz0t9Mj0G0O?=
 =?us-ascii?Q?xwtVqj0yOAAjqUt3R7mLsNThNL+3/u+31Pyh3XMpfb3OTSqdrpVivgA9lkMh?=
 =?us-ascii?Q?oB4NXYQJWCS49tUWd46ea3K0L6J5EhWpLztMc362E0bQ6UfcWdFNWqjey1dl?=
 =?us-ascii?Q?9bG8SAvEZNJF0+M1OdkDI94O/xggkgZGT3HO0lHLnL0gKK2OLoXcjcGqQvYy?=
 =?us-ascii?Q?2Juv3WooG5mVxzurI0UOoWhGR5x47M5FeVnqQb5lqgPDQU7rktLHUV34e/U8?=
 =?us-ascii?Q?ozFKXYqJHuR/avH8hYNYJRTMl5lfLh+iQonrDJ2mnZAfVM4trwW4UQ0sgF07?=
 =?us-ascii?Q?AigQ9yxe9cAuYRyy/YzTMjLXfSB8rL7d8tSkfG0/OkDiyZzAP/bUHSpuSBbe?=
 =?us-ascii?Q?b/4nFQshHANN/O/Z7o1PegvfowPNGX7DzcN48KsxdvfXwJc13JOKR+tHYYoR?=
 =?us-ascii?Q?xtD0CwJ+Z+V8zV7AkN3NjftR7c7OsG5jwD1VWTZJCbeMHfNleGyat+NZZ81Y?=
 =?us-ascii?Q?wdffrqbKybJegS/zJMIkS0Wfn5eAc9K9LKOsdyjKZoQFfQp/fHZpWuKuERV0?=
 =?us-ascii?Q?9SItlJ1rS48z11hS2Gn9jbeiMEe+GnlXybGzjPYC/MjKpkCO9x8C+JJHK9KF?=
 =?us-ascii?Q?wEkX7S3MlAmTPxoF5ysUAHrhaSsIUfe08fg4Ww96xLnnxtuZ4hknR4DjNrqB?=
 =?us-ascii?Q?9QWsV3pTT0nt+q5D668jgvyzz7qND2lijRaluRaHZMVdmLye8Qf5tH+MAm7d?=
 =?us-ascii?Q?ZGkMyBu833XT9b/diCRucELSwjSR7IAPCZsO0IXHIXKS46orvOiyDFlvHhLw?=
 =?us-ascii?Q?w+4ck0B2iD3mYos249asMne9SEgPduC035akRRkw4yBSMM+vtqjd4J4aHZtg?=
 =?us-ascii?Q?RokAVltio0lji+HJCw9Ki2DTOVCaBbk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b63c65d-d95b-4caa-d61a-08da16504cd5
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 15:32:17.4716
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JodALE6sbgjGMzubxoYlix814gpSKYcAKhJQo/u3JsxRJUvprAcZy+tGp/09vT8b+OjqSWKkNFajIDUB6Ahq1ghT4fwUT+B61s2U9i9wywA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5138
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-04_06:2022-03-30,2022-04-04 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204040088
X-Proofpoint-ORIG-GUID: YkhTZ-0pLdzrtrNdoymZrdDcZOvuADnl
X-Proofpoint-GUID: YkhTZ-0pLdzrtrNdoymZrdDcZOvuADnl
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index e2fa56b92..b5e114bed 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -185,8 +185,9 @@ static const struct {
>  	{7, 0xcc, 0x4c, 0x18, 8},
>  };
>  
> -static int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
> -			      u16 size, void *data, int in_pm)
> +static int __must_check __ax88179_read_cmd(struct usbnet *dev, u8 cmd,
> +		                           u16 value, u16 index, u16 size,
> +					   void *data, int in_pm)
>  {
>  	int ret;
>  	int (*fn)(struct usbnet *, u8, u8, u16, u16, void *, u16);
> @@ -201,9 +202,12 @@ static int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
>  	ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
>  		 value, index, data, size);
>  
> -	if (unlikely(ret < 0))
> +	if (unlikely(ret < size)) {
> +		ret = ret < 0 ? ret : -ENODATA;
> +
>  		netdev_warn(dev->net, "Failed to read reg index 0x%04x: %d\n",
>  			    index, ret);
> +	}
>  
>  	return ret;

It would be better to make __ax88179_read_cmd() return 0 on success
instead of returning size on success.  Non-standard returns lead to bugs.


> @@ -1060,16 +1151,30 @@ static int ax88179_check_eeprom(struct usbnet *dev)
>  
>  		jtimeout = jiffies + delay;
>  		do {
> -			ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_SROM_CMD,
> -					 1, 1, &buf);
> +		    ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_SROM_CMD,
> +					   1, 1, &buf);
> +
> +		    if (ret < 0) {
> +			    netdev_dbg(dev->net,
> +				       "Failed to read SROM_CMD: %d\n",
> +			               ret);
> +			    return ret;
> +		    }
>  
>  			if (time_after(jiffies, jtimeout))
>  				return -EINVAL;

The indenting here is wrong.  Run scripts/checkpatch.pl on your patches.

regards,
dan carpenter