Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Martin Kaiser <martin@kaiser.cx>
Cc:     Ira Weiny <ira.weiny@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label
Date:   Sat, 02 Apr 2022 15:22:23 +0200
Message-ID: <2108195.Mh6RI2rZIc@leap>
In-Reply-To: <Ykg3Xfb4vjjGSyKc@martin-debian-2.paytec.ch>
References: <20220401183513.26222-1-fmdefrancesco@gmail.com> <1724388.VLH7GnMWUR@leap> <Ykg3Xfb4vjjGSyKc@martin-debian-2.paytec.ch>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On sabato 2 aprile 2022 13:45:33 CEST Martin Kaiser wrote:
> Thus wrote Fabio M. De Francesco (fmdefrancesco@gmail.com):
> 
> > > >  	pnpi = netdev_priv(netdev);
> 
> > > >  	if (!pnpi->priv)
> > > > -		goto RETURN;
> > > > +		return;
> 
> > I cannot see how pnpi->priv might ever be NULL.
> 
> Even if pnpi->priv was NULL, we wouldn't need the check. It's ok to call
> vfree(NULL).
> 
> > After the two removals I've talked about above, the code will always call 
> > vfree(pnpi->priv) and then free_netdev(netdev).
> 
> That makes sense.
> 
> Best regards,
> Martin
> 
Hi Martin,

Thanks for reminding to me that a vfree() on a NULL pointer is a no-op.
I'm going to submit a new patch with the purpose to re-work rtw_free_netdev().

Thanks again,

Fabio