Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 4 Apr 2022 12:59:57 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ira Weiny <ira.weiny@intel.com>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label
Message-ID: <20220404095957.GW3293@kadam>
References: <20220401183513.26222-1-fmdefrancesco@gmail.com>
 <YkdjhGtMwnbJcz+P@iweiny-desk3>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YkdjhGtMwnbJcz+P@iweiny-desk3>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mIa0RxWW20D1FPGgkCBLh9FpyjcowyYBJMhyasAVkOort1FsFS9GKbKXux/i?=
 =?us-ascii?Q?pSxtdvUtUewUAyewIj8wK3a6IkEGAiAiepPL7ngrzPwSkAmwwaWGlvEEfdab?=
 =?us-ascii?Q?OZ9MUml1dQSQaoyROvo6/0Kcln/63PaipDekRVg9BsK5yRTRsAilu++o7WhX?=
 =?us-ascii?Q?/zkol9/OKCd44+GkfDbVDHhImvPZZiNuoMsFl0AYJIp6Rkv/SDdB/xRMJA/l?=
 =?us-ascii?Q?zAHTqLX6ArVh+f18e/KDEKggv8VAM6f1ATgMRf5wwignVOusNOwwjkl/ybWX?=
 =?us-ascii?Q?k8N+a0nltqjEkio2QzP/1doxICie4ZsltF+WIsIA3XC/u+R5kRhDfp3iNtmR?=
 =?us-ascii?Q?Q0CAo9Slhb2FluljPFZ+UoxzkpiPyScKoWYMEYRJh67aYT//gNbpbucZNLLQ?=
 =?us-ascii?Q?UQ6yjXGjKJ7Ar9HBwpH49C2+4NkDnCY7jma9yRi2H8RC2bvP74lwL6KCc0ME?=
 =?us-ascii?Q?GXpWO0YqLPC7LG6Cd8JJi/IMRFuZl1wr0xpVpf4KoS0ScxbVgWZaVtCTe0cs?=
 =?us-ascii?Q?qsB+tcEMqmDJs0H0iShxdRVCknMnnobAw4Tceo9z0k1h4CSvKGFp8T//zGMh?=
 =?us-ascii?Q?/DoFtD0AqUfxJkxXQje9NFQhX0fiW/9lHf3LPlrwgxdrz9/qmLPQL14D+Jbi?=
 =?us-ascii?Q?DF8aiTA9lCT5YWzDzd9N73KvvEIVCyltjD/fYUcr1opKENHlyIZbdzVW6qG0?=
 =?us-ascii?Q?ApXwOp4FNTjUsOxcJizl5sTwmN9nJkaX92QwDKwm4kjftNnQt0iuX2Lo2XHR?=
 =?us-ascii?Q?6oIx/nDDUisz9jjrZqap7QTrxvrsD6Q6RRQiv4+G3JcNz12r7yCW+Z2Ro/li?=
 =?us-ascii?Q?SKQ18BurxETSmQz4Z21LO/Kvg/OX42WILrQH/N/AnbkwevZ81WhFcqwwKUk9?=
 =?us-ascii?Q?DR7MiE2tthEIJx3kmZEoGB7wxW+IgG81yaZvQk8RpFlTzXIhwMMCdRP7HBlw?=
 =?us-ascii?Q?KJvd9JgXR9F9rX3F6owiUrz1ueztY5XkK9Db5JMAMNmnVCXPr8L1SwtXAFJX?=
 =?us-ascii?Q?FY4EEFMTlzlBuO3Vpg6v8e5FqNuLSusnMm7KX5v/h3cf9Ioko73PUkYL4Mf6?=
 =?us-ascii?Q?H4Y47xREmD6Kl9CZvZ9pX/II6TVkCVnGxXXwZcmjwo9fuXZJRW+/1g4BhAml?=
 =?us-ascii?Q?WgqVk71xVsocAS0309hUll0p3xYS78vb+JilbPHSfHb5PbndkpCyByM52MUl?=
 =?us-ascii?Q?y80zJV0YABP1Y12DbMYccQQpyOVyF3zvB29uPOpFf1o9rpSe5sHVtaKWaijt?=
 =?us-ascii?Q?NeKouuBgHwcLytcB30m87MUrEOfQJ2vZjRQyOtynDttyUH7aQs2NY89yukEM?=
 =?us-ascii?Q?4umZHD9HUNNR3dxvhKGTSZCAUXR2vk3YjBij5Hj9rkQy3mC6rtTi0U1naXHQ?=
 =?us-ascii?Q?+d2LcT/b1zYD/8Ryh7yA1PLqJg2/nrhZ/5KHZSexNpJR5J0m4kW71s+cc9fQ?=
 =?us-ascii?Q?S/oIKH89jynFHKW5QhkTIocdeIkMjFsFSWR9NTYHvuPGPaJ8jhHMSxv23gBu?=
 =?us-ascii?Q?rDK57a49lK4+Ie0rv14cOxYiAb1B2DdcoFk4dXAj/q1aZ/veugsBK2xVqY+Q?=
 =?us-ascii?Q?9JEOExRVhMsL+jSoCpqpNjmJQ3Ve9MMMx3lbgIlzzz55NSBFR7SZS31LJK3W?=
 =?us-ascii?Q?s3yhPw8YtXF5PRzj/R16Ooo3i54Rhyx+R2hsUYNoSgdEVfUkxi9TwSqPb+hZ?=
 =?us-ascii?Q?gqOuMIYAk96WyLZ1xhz/lpE5yykPM094UZfTCsvNwjIuTViASXo3gH7ldUjD?=
 =?us-ascii?Q?sNO0+eDDB2gE+LuTVRxVmjjS0m1xNoE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69af3f12-749a-42f0-3d1a-08da1621e74d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 10:00:09.9020
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SMolf/MkYFYNvFFX9GbCv93XhffWgsr5Pz7UsnWbEITa58518Doui/BiOw31xwoL/0grhiiYeQsAh3k2KgEQRSIfjuU7Q5Pq8bE7VzTuF+8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3806
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-04_03:2022-03-30,2022-04-04 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0
 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=885
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204040055
X-Proofpoint-ORIG-GUID: BcF6VMCI23SE4d1q15ymQqR1yGKO3CU1
X-Proofpoint-GUID: BcF6VMCI23SE4d1q15ymQqR1yGKO3CU1
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 01, 2022 at 01:41:40PM -0700, Ira Weiny wrote:
> On Fri, Apr 01, 2022 at 08:35:13PM +0200, Fabio M. De Francesco wrote:
> > In function rtw_free_netdev() there are two "goto" jumps to a no-op exit
> > label called "RETURN". Remove the label and return in line.
> 
> Thanks for the patch!  However, A good commit message lists the why and what of
> a change.  I don't see a why for this commit?

People, stop belly aching about commit messages.

"Delete no-op goto" is sufficient justification.

regards,
dan carpenter