Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sun, 3 Apr 2022 16:44:24 +0200
From:   Marc Kleine-Budde <mkl@blackshift.org>
To:     linux-sh@vger.kernel.org
Cc:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Rich Felker <dalias@libc.org>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: make iounmap() a static inline again
Message-ID: <20220403144424.f5akrad75xtkncgz@pengutronix.de>
References: <20220105085746.1116726-1-mkl@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="y5qda4tomsttcgy4"
Content-Disposition: inline
In-Reply-To: <20220105085746.1116726-1-mkl@pengutronix.de>
Precedence: bulk


--y5qda4tomsttcgy4
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 05.01.2022 09:57:47, Marc Kleine-Budde wrote:
> The patch
>=20
> | 98c90e5ea34e sh: remove __iounmap
>=20
> removed the __iounmap macro for the NOMMU case, but also converted the
> static inline no-op iounmap() to a macro, resulting in lots of unused
> variable warnings.
>=20
> This patch coverts the macro into a static inline function, similar to
> previous patches in the sh arch:
>=20
> | 4580ba4ad2e6 sh: Convert iounmap() macros to inline functions
> | 733f0025f0fb sh: prevent warnings when using iounmap

The problem still exists in linus/master, can someone take this patch?

regards,
Marc

> Fixes: 98c90e5ea34e ("sh: remove __iounmap")
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Rich Felker <dalias@libc.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  arch/sh/include/asm/io.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
> index cf9a3ec32406..4960b8ff1ad4 100644
> --- a/arch/sh/include/asm/io.h
> +++ b/arch/sh/include/asm/io.h
> @@ -271,7 +271,9 @@ static inline void __iomem *ioremap_prot(phys_addr_t =
offset, unsigned long size,
>  #endif /* CONFIG_HAVE_IOREMAP_PROT */
> =20
>  #else /* CONFIG_MMU */
> -#define iounmap(addr)		do { } while (0)
> +static inline void iounmap(void __iomem *addr)
> +{
> +}
>  #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
>  #endif /* CONFIG_MMU */
> =20
> --=20
> 2.34.1

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--y5qda4tomsttcgy4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmJJssQACgkQrX5LkNig
011irQf9HZnQq5ATktTlhzEDcsWEtrTO/zuIuVRQjCjJkoXxx/AXnmr1Bxdhpqpl
XrJRgk8pqsrkK1RBHLJNKS19NU6ujciVKnOSbJ1hQkQhiXC9CLZI8O0X+PkyrbbZ
de5pUts2RqImI3s+ejZVCAeGnmaEmp0VAKYmehxbAhwGnRmdxkpYa6Yi/iC3Mhxs
p0eM6hdbm2wYbMI/jTLUAkZ+vTmK3uG7vHg7Z2m3HWMwQ2024GGiSS97LDKblpEa
hfCUQ5gfM9Y4BG1S/QOYkB5bl43ZUkLUOk7Gn2Yqvwz4vGugzZ0js53B9YtI+ZKl
4M/1OI/zd2SHm+ONDwjy4uHfbuj7pQ==
=O1BU
-----END PGP SIGNATURE-----

--y5qda4tomsttcgy4--