Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Sat, 2 Apr 2022 17:51:31 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Lars-Peter Clausen <lars@metafoo.de>, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org, Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH v2] iio:proximity:sx9324: Fix hardware gain read/write
Message-ID: <20220402175131.75bb95de@jic23-huawei>
In-Reply-To: <CAE-0n50T9uqcB9EK-RnGXPGhd6RWdrsE9pA5FJY9yC58xd=05A@mail.gmail.com>
References: <20220324222928.874522-1-swboyd@chromium.org>
        <20220327155147.52e898b4@jic23-huawei>
        <CAE-0n50T9uqcB9EK-RnGXPGhd6RWdrsE9pA5FJY9yC58xd=05A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 29 Mar 2022 22:25:31 +0200
Stephen Boyd <swboyd@chromium.org> wrote:

> Quoting Jonathan Cameron (2022-03-27 07:51:47)
> > On Thu, 24 Mar 2022 15:29:28 -0700
> > Stephen Boyd <swboyd@chromium.org> wrote:
> >  
> > > There are four possible gain values according to 'sx9324_gain_vals[]':
> > >
> > >       1, 2, 4, and 8
> > >
> > > The values are off by one when writing and reading the register. The
> > > bits should be set according to this equation:
> > >
> > >       ilog2(<gain>) + 1
> > >
> > > so that a gain of 8 is 0x3 in the register field and a gain of 4 is 0x2
> > > in the register field, etc  
> >
> > Example seems wrong...
> >
> > ilog2(8) + 1 = 3 + 1 = 0x4
> > ilog2(4) + 1 = 2 + 1 = 0x3
> > ilog2(2) + 1 = 1 + 1 = 0x2
> > ilog2(1) + 1 = 0 + 1 = 0x1
> >                        0x0 reserved.
> >
> > or have I misunderstood?  
> 
> Nope. I hit the wrong key but your table is correct. Can you fix it when
> applying?

Done and applied to the fixes-togreg branch of iio.git but I haven't pushed
it out yet as I want to rebase that tree on rc1 when it comes out.

After that, please take a quick look check I didn't mess up.

Thanks,

Jonathan