Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <c8461d9c-dda1-3c1e-0e3b-169073e8c4d0@lwfinger.net>
Date:   Mon, 4 Apr 2022 13:47:33 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 2/2] staging: r8188eu: Add line after declarations
Content-Language: en-US
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
        outreachy@lists.linux.dev
Cc:     phil@philpotter.co.uk, gregkh@linuxfoundation.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <860d8e222e2b695ce5cb4f48aa46a7f66e05d8e4.1649082939.git.eng.alaamohamedsoliman.am@gmail.com>
 <19d8f316e43d16c9341f7fe94e68534cf60cc05c.1649082939.git.eng.alaamohamedsoliman.am@gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <19d8f316e43d16c9341f7fe94e68534cf60cc05c.1649082939.git.eng.alaamohamedsoliman.am@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/4/22 09:39, Alaa Mohamed wrote:
> Reported by checkpatch:
> 
> WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
>   drivers/staging/r8188eu/core/rtw_br_ext.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> index 7c664f80fa99..f7811b46db1c 100644
> --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> @@ -313,6 +313,7 @@ void nat25_db_cleanup(struct adapter *priv)
>   
>   	for (i = 0; i < NAT25_HASH_SIZE; i++) {
>   		struct nat25_network_db_entry *f;
> +
>   		f = priv->nethash[i];
>   		while (f) {
>   			struct nat25_network_db_entry *g;
> @@ -339,12 +340,12 @@ void nat25_db_expire(struct adapter *priv)
>   
>   	for (i = 0; i < NAT25_HASH_SIZE; i++) {
>   		struct nat25_network_db_entry *f;
> -		f = priv->nethash[i];
>   
> +		f = priv->nethash[i];
>   		while (f) {
>   			struct nat25_network_db_entry *g;
> -			g = f->next_hash;
>   
> +			g = f->next_hash;
>   			if (__nat25_has_expired(f)) {
>   				if (atomic_dec_and_test(&f->use_count)) {
>   					if (priv->scdb_entry == f) {

Acked_by: Larry Finger <Larry.Finger@lwfinger.net>

That applies to both patches.

Thanks,

Larry