Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3457498pxb; Mon, 4 Apr 2022 17:36:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhG/IpnxGCKr7nrjOw1KXQaGXhEg/7CbD9tdW2ir65gfHbDMzq69eydRwR0MecsFHpL4ac X-Received: by 2002:a17:902:ccc6:b0:156:a94a:9db4 with SMTP id z6-20020a170902ccc600b00156a94a9db4mr845981ple.45.1649118959874; Mon, 04 Apr 2022 17:35:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649118959; cv=none; d=google.com; s=arc-20160816; b=bXv1tbSTCnOnTYDBrFhFbsQjKQEkRBNXzGHq320yer+3fnM7SAEd9af7yQIEjSHXj1 26Hp8FrUjDYevFFIs0gRbuOJ8fT4ck/GG0G49kA46qbfkZpCFtNNdUNuvrUFRh4gfB0z HdHZhcBgCRw4idbqKJC/vcdAclBybvjXwAAmZCMzEOt0DdTJ+0tHg7b3wq9MDQugkAox 3mG9OR8dLWD2402OjxJKSeZvPdzlZhAfrFvqa0SJCm5s5wdYLPj+jLASvzDfojcbBvG1 1vgWrXSGi3NG5HOI7Aor+Ig2QsxJBy+aVmJ6qcgiZIOeCP1rldKFsecqol7ouDCiR3+1 RQsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=FlBsVFEKh4j3VAt6LeTKFsoKsuruo0DcZ5wQSPKgGVo=; b=jVh/gNn1E/ljdtHacHW6ebBDGzayu0O/WD9sgFO9PmWUgj6HML1uNwrUZkmkct4uUZ zrWRhJjv1s8J/TkaxbBRADZsDHB67dA4WHvvvZGIedzSRJYf8k1XMGK1I8XVuYa1fC4l Wofc5gBbMiLeyCDSipnXUDopw+/6T0M6lREG5WOTXPzdvxE3hrE0jzXjOfiWNPc6ARLr H9fxSuwNiC/ce7FwN1dd99Fe+FqfkqHks7jPf6nA5HTLq1LyrEitiCUo0GGTZf35PBmr dSAw+7ZGpvXGvlhH8g8a5WGlgDkR3WRts3fA9gXGAyTb3sEtQ/uZVIXBjMipDhe/qGW1 FB0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gZxNZUcV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id y5-20020a17090322c500b00153b2d16460si12110253plg.104.2022.04.04.17.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 17:35:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gZxNZUcV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8D9E08CCE7; Mon, 4 Apr 2022 16:53:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351637AbiDDN2K (ORCPT + 99 others); Mon, 4 Apr 2022 09:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352518AbiDDN1z (ORCPT ); Mon, 4 Apr 2022 09:27:55 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0457AC0B; Mon, 4 Apr 2022 06:26:00 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id m12-20020a17090b068c00b001cabe30a98dso403055pjz.4; Mon, 04 Apr 2022 06:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=FlBsVFEKh4j3VAt6LeTKFsoKsuruo0DcZ5wQSPKgGVo=; b=gZxNZUcVpHlb+PC0mU029qi8y3yaBV33LkmOZB+zCVqsXIYEND5s0ftLAFjpG+DSvG 3fre2ImlaHs0IToAEnvx8Ge+DDk9/z+wpD4ZGw38SCtRfsEbEO4pjAklfsQgrWcCtlq+ /NChUBrxhCdkVoxZCR6VfOXHeSigso1sRZ7Fc/pZ1khBXeg8xEX1EpjsMh7+AVabZYn2 8yv09bnMza+Qfv1P1GRodT8QGwJ1rbgkjTpmC0siV2jwaa8Rslz2GWkomEftev/V7mHa ewRE3nXenMD+InkvCKfXlyVm/K04usRxrRtQbfpqdnt9H2c9hJBLDrzbLpkOlOI6OBTZ IbFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FlBsVFEKh4j3VAt6LeTKFsoKsuruo0DcZ5wQSPKgGVo=; b=rQLpjFALmkhmS1/49E/nqSYWvAcdDnsufbH9Bc6slIsBpZNpj5d290oNE5fHxUKAUk HkBVEuXqcQ1Z/sgK0o5ytiz5QxTBq/5GsCR14YrTSKU/IBACkZNrTwtkSOlyiJH9/xBT PGawEr472JJStNUfA/lMuXP705f6SafmjVutCnW4SYkF7Zv85+zIW8ARzfpjz/C9s14d u28D7Fk+MZm1E8jb+smS4krkGMjfIAq6l18fBrZ9MJ5qktWN1xyI+c3wh3I3p3hlohGE t1Khvl/G4qme3UeEZVFIzStWxaenQroxwiDktUdswIyXsrHdwYcXzq2Gf6Xp0YjQ4YEf FAXw== X-Gm-Message-State: AOAM532L2ivPLpW7mRQv2jvd4QkoqtB3JHx5CTYg1S/u8nx37ncvidc9 XVQlN4WFVescEBDDSgVuyMyu6LCD7sAv2R5VN58= X-Received: by 2002:a17:903:2285:b0:154:c94:c5b7 with SMTP id b5-20020a170903228500b001540c94c5b7mr22253plh.64.1649078759509; Mon, 04 Apr 2022 06:25:59 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id j3-20020a056a00234300b004faabba358fsm12617039pfj.14.2022.04.04.06.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 06:25:59 -0700 (PDT) From: Miaoqian Lin To: Eddie Huang , Sean Wang , Alessandro Zummo , Alexandre Belloni , Matthias Brugger , Tianping Fang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] rtc: mt6397: Fix potential NULL dereference in mtk_rtc_probe Date: Mon, 4 Apr 2022 13:25:53 +0000 Message-Id: <20220404132553.28064-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_resource() may return NULL, add proper check to avoid potential NULL dereferencing. Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397 RTC driver") Signed-off-by: Miaoqian Lin --- drivers/rtc/rtc-mt6397.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index 80dc479a6ff0..07c6679366e0 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -269,6 +269,9 @@ static int mtk_rtc_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; + rtc->addr_base = res->start; rtc->data = of_device_get_match_data(&pdev->dev); -- 2.17.1