Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3457651pxb; Mon, 4 Apr 2022 17:36:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCt/D8AdTnio+YOIwiooL0qfwpCzn60PZWBvkxCxG+OHUcRG6c2wrpzNmNFyC62wqMQZ9N X-Received: by 2002:a17:90a:a78c:b0:1b8:b769:62d0 with SMTP id f12-20020a17090aa78c00b001b8b76962d0mr945018pjq.227.1649118977056; Mon, 04 Apr 2022 17:36:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649118977; cv=none; d=google.com; s=arc-20160816; b=mXmFztfyWB+a/yHhYs2CnKk5LXm9cXmlCWSQvr+jRZtFa0aJBeIHZT9mpJZ5imVrgU /JGHoMCifK1qV6YEIvwJFcMf3t/JAij7KAo+0R4y+jW+pRL1/daIFalm5SwUWMZtQwPw MmEwppnMA3+PIFVC7/v+aixechMClPJwo68NiDJg5e3qk+TmkwH+tO3txmMkkmMcKYY8 QRdwJl1p4kDbqe4yjFx3WKOUcqoJP1cFKQipQiZGUprTPpa5knGsN311x2iLITkpiP0I BfJPasw2Dbjxmolk829kCJPDhi1bMAzxxjKaD+X0Hmqr5Q7kb6JGEqpVtz/vRFlDisIx dAQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SFEBOkVBt2v7eUVd6t7tUEMAgkCh+TwoOUWan0N1Hos=; b=rf7M1sRJs9vuMWxD/HbRZHRdI//J7ilbHcAi8r982/hsV7Outig0ktRarmxjbz4IfV kj5Aw6aBFAISlgYk3+8vNzCuEzyohdrwTNErdQdorA81/X1FIxDsy21a6YNNGJ/AxDMT sLRYNHuGzcwIQG8XPkbA9tdZ1Ya8IE8MXOWmYUH8+7U5X9Rx7gNLW/bYUK/+O0MgAPIE bNlMc1pwU8mnuzmNIPs3Pji10sPQ6+D0RnZ33/cU0OPylBJKmMXv92MjrRLQSnZ+vOpz X9g+SqrLxs8wBRljkDU4+Eq+Ix7mrEcGAsvSfw0KT3tvdnLNXS+0N0gQZ+l8sC+n5j/W +uRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k35KrcyP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 204-20020a6217d5000000b004fa3a8e0036si10745180pfx.237.2022.04.04.17.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 17:36:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k35KrcyP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E7CBE8CDA0; Mon, 4 Apr 2022 16:53:22 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377724AbiDDHn3 (ORCPT + 99 others); Mon, 4 Apr 2022 03:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377725AbiDDHnT (ORCPT ); Mon, 4 Apr 2022 03:43:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C8C3B00A for ; Mon, 4 Apr 2022 00:41:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1B79AB80EDA for ; Mon, 4 Apr 2022 07:41:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 298C9C2BBE4; Mon, 4 Apr 2022 07:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649058081; bh=SFEBOkVBt2v7eUVd6t7tUEMAgkCh+TwoOUWan0N1Hos=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k35KrcyPmVFXi+Gy2GWiGVFUahIER0Mp79Rv4sRPCzurenul1pPyA3KyvosugQcTS 1+U+my+IW7vsGQkB101wUgRGopoe3W6hwqsnlrk+cyQ0w1KWqrapbpTXU9huTNI55l 5+j4pPfyXEhouT+Tug+qkeZfesxoQXOvH69b/TkD6SsQTst/lkSYrIeHQDZ+wTWV8I BT4L/ZteXWbk7077YCQcQDJZG8kvn5viavEgZlv894QuZU470ZY90w9wuEItr4SU9B XWIJrmDy6A+DkA2+ho3qluOUaZJrVaqoCHTVOB53PzqkSYJtAk7C1hgtQZlvsQvq95 M6mphAauWj74Q== Date: Mon, 4 Apr 2022 08:41:16 +0100 From: Mark Brown To: Yang Li Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, tangmeng@uniontech.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH v2] ASoC: amd: Fix an ignored error return from platform_get_irq_byname() Message-ID: References: <20220304004543.11797-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZxoYiHOv0fHvjypM" Content-Disposition: inline In-Reply-To: <20220304004543.11797-1-yang.lee@linux.alibaba.com> X-Cookie: A rolling disk gathers no MOS. X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZxoYiHOv0fHvjypM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 04, 2022 at 08:45:43AM +0800, Yang Li wrote: > The return from the call to platform_get_irq_byname() is int, it can be > a negative error code, however this is being assigned to an unsigned > int variable 'adata->i2s_irq', so assign the value to 'ret' concurrently > to solve this problem without affecting other functions. This doesn't apply against current code, please check and resend. --ZxoYiHOv0fHvjypM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJKoRsACgkQJNaLcl1U h9BT8gf8CSb8vfR5YFVec3em+YC6KNuko+8bu/rJE2FhxYDaW0+TitAAQbNhfhR+ /2NrU8KwenZTLE32B0MAOFYEPpXCITV+6ObDeXiDRQ773oBso8cMdEt87sh+nQNj 16ld/gg6nGG5Eym/8gwsMZ0tOkOAlLMwW3ZTeSnspZNFykPne0/8UPC+rpigHY2o Nk1Jg1/XlihxB9I1yzvZQDTZKErxmVxsKWiYzVDyxQrB7/rroV/TfARFipOOcsPy mOiuj+jtbl/lIRToLcravIOG8qRNCZaO5Eaqc9GtfAV1B7FZAAGBAC6bxHq5tbwy xCj2phXjjXH0PqU8sAm4Mu2THhCsHA== =mzRX -----END PGP SIGNATURE----- --ZxoYiHOv0fHvjypM--