Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <9a584eac-6ac9-e4ed-ef90-49569f4a4baa@linaro.org>
Date:   Sat, 2 Apr 2022 22:38:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v3 9/9] dt-bindings: qcom: qcom,gsbi: convert to dtschema
Content-Language: en-US
To:     Kuldeep Singh <singh.kuldeep87k@gmail.com>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mark Brown <broonie@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-spi@vger.kernel.org
References: <20220402184011.132465-1-krzysztof.kozlowski@linaro.org>
 <20220402184011.132465-10-krzysztof.kozlowski@linaro.org>
 <20220402202917.GA36054@9a2d8922b8f1>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220402202917.GA36054@9a2d8922b8f1>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 02/04/2022 22:29, Kuldeep Singh wrote:
> On Sat, Apr 02, 2022 at 08:40:11PM +0200, Krzysztof Kozlowski wrote:
>> Convert the Qualcomm General Serial Bus Interface (GSBI) to DT
>> Schema.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  .../bindings/soc/qcom/qcom,gsbi.txt           |  87 ------------
>>  .../bindings/soc/qcom/qcom,gsbi.yaml          | 133 ++++++++++++++++++
>>  2 files changed, 133 insertions(+), 87 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt
>>  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml
> 
> Great initiative to convert everything in one go!
> 
> [...]
> 
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml
>> new file mode 100644
>> index 000000000000..b97e359f3f90
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml
>> @@ -0,0 +1,133 @@
>> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/soc/qcom/qcom,gsbi.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm General Serial Bus Interface (GSBI)
>> +
>> +maintainers:
>> +  - Andy Gross <agross@kernel.org>
>> +  - Bjorn Andersson <bjorn.andersson@linaro.org>
>> +  - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> +
>> +description:
>> +  The GSBI controller is modeled as a node with zero or more child nodes, each
>> +  representing a serial sub-node device that is mux'd as part of the GSBI
>> +  configuration settings.  The mode setting will govern the input/output mode
>> +  of the 4 GSBI IOs.
>> +
>> +  A GSBI controller node can contain 0 or more child nodes representing serial
>> +  devices.  These serial devices can be a QCOM UART, I2C controller, spi
>> +  controller, or some combination of aforementioned devices.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - qcom,gsbi-v1.0.0
> 
> Only 1 entry? const.

v1.0.0 looks like there could be some more, although they did not reach
mainline. The GSBI seems to be replaced by different blocks, so maybe
there will be no new entries here.


Best regards,
Krzysztof