Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 4 Apr 2022 10:56:09 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Guo Zhengkui <guozhengkui@vivo.com>
Cc:     Mustafa Ismail <mustafa.ismail@intel.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        "open list:INTEL ETHERNET PROTOCOL DRIVER FOR RDMA" 
        <linux-rdma@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        zhengkui_guo@outlook.com
Subject: Re: [PATCH linux-next v2] RDMA: simplify if-if to if-else
Message-ID: <20220404135609.GA2911054@nvidia.com>
References: <YkVu3vqjIPFRSGtM@unreal>
 <20220331130525.14750-1-guozhengkui@vivo.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220331130525.14750-1-guozhengkui@vivo.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8JOiT4SprqigkgcQ+1oTTJmwlkuXx5VmZ8O6jvxUPtyxvQNwgzlI0ZtlRgz2?=
 =?us-ascii?Q?QEbVhA+gkvFKduEwGq7T1utaujOMqY3/ZCIcSuDH9jJrKKxGkHaa0PVB1dSg?=
 =?us-ascii?Q?sObvFjtczt+YolQuNJ8B+Z5IwfXdOPs9q7zhn09ituUdx997K9TeCuSOAKhB?=
 =?us-ascii?Q?PMpNZb3wSl9q2bMrinAGtWL6VteIFDzPFDt6nmILx138Kw0b2REdwGKL05Qi?=
 =?us-ascii?Q?SXXz0wm8+iWQ+DlFgvc+5BBAToh6KOEnQTZCk4xyullLExaJ8lOOhQV2hakh?=
 =?us-ascii?Q?zgzXanW4zZ9oJDDAgxiPcpEGlMZvz9mm+47g2DiaZ4II2Mjaqsi/ysVMWzSE?=
 =?us-ascii?Q?oyMQTKvb2qlUlMTwnj2x625xi2ZFF1IEbt4gP/9NE/rjintVxaiMThDNAuN7?=
 =?us-ascii?Q?blre6IY+1MElJQmzyQ0GH4gH0u4aroaXJ4fMipKDX/+B79AbB46DOqC2Q8f8?=
 =?us-ascii?Q?CfDcdttqagreVT9aiEfcPKh978aJEhGYGOXwsUZ14P+6NZnxEUJmt0gGHqnA?=
 =?us-ascii?Q?lAnT+npM7IJBxC2SOg6FehRRJ3fR6DkG0qKDU1OIw+4nDa6hTduvK2GRUEoh?=
 =?us-ascii?Q?mLs49gkxs5hKXFzAZiLNocmIxzjO5vj0Iq3eKbc/WW5C+pk1htabM3gepVx+?=
 =?us-ascii?Q?rOgTNMkosauY/rcPgtoogR3AV1UWhkb1JKQTik4Y9Gxz+z+2s82j9HG45MnO?=
 =?us-ascii?Q?QW0holSIo2MVgPUTuHnFgw9IyHfhxE6dlZR2c4wWHGTo8mXl5KSeODFrEmyQ?=
 =?us-ascii?Q?ZSA4jq5KW+JzNAog+Yez2CDJCeWoHfOEiUUM/2BWuKuLOLBtRxWbOMPQKu73?=
 =?us-ascii?Q?cBCWw2joqjIKw9j/1IRm9nKpb5M4f4eT/k5kV66gBH7Ed5zXrB0xmIKZQaKN?=
 =?us-ascii?Q?aDLkIhL+Uc5k7nAiKzAJwb5hQo5qXRDwLc8IiMoiq2WqiDgnpdeikmQ8Gp4F?=
 =?us-ascii?Q?o8lEa69QLQzNWiaWqN4IFvP7JbBWIc6XdmkCNBhYAggBhYRXsh/ck2p0A18W?=
 =?us-ascii?Q?abWsfAwxHc2Hvs9Mn6DtDPQWzic98Wf7//2P+F/I5PG3VRa0D6Nowl/pjKoj?=
 =?us-ascii?Q?Rt9uexRIXh5NrRWDmP+pDFZ3SegW41ESQmCBx1yC6PrmO2kI3Xc33Gt3Dc36?=
 =?us-ascii?Q?rezsvAITZEp4auLbMq1Len1YPz551mHhJa8hCM3Vzq7fQVtXhaq59cyLtY8C?=
 =?us-ascii?Q?/rjcdn+Hj58x8Uw4UdLhQ+w6UGuHYhKm0YwfP/oCTGGnjAnTYvnP0QS8qIer?=
 =?us-ascii?Q?KJurDDNcCMx/pZOXqH+xt8vMX8SMJduYIEcSeulNlvzqydD1b2A3Vj6Uy0ge?=
 =?us-ascii?Q?VC2EK4YHE2xSJ6oQRXDT35558qvq9/48MfRG7n+Wa7FSUzPBP6Jss58z58Ba?=
 =?us-ascii?Q?9fF8owHkjEYtjVcjyK9XuXG5XZ7pM5Ivmo6z66mdG+ry7DbXHM2tF40JJPVm?=
 =?us-ascii?Q?hqdGwHUW2OF5c/rMo7rmirTBEzvlg2SxSVtxyHoK7A4zsN9YCRL2WIj3+ZHq?=
 =?us-ascii?Q?hLu1rF/dZFdkLoT/YK7bRpjRJchVSqc1cQ/W3WbWjJCThv5/JNDKdAY/AqjK?=
 =?us-ascii?Q?Zdp1xfsdQJL+LNw3Ep/GZZTujXpQ7yxzQ9Itzwchj61XimkMB0PchSRqYuSr?=
 =?us-ascii?Q?84CCm5JzCbpXlaEjjFgFVNuc/dP2iBbFoT9BnRk6odzG2UsrQnnsvqploB4c?=
 =?us-ascii?Q?jD5tYUh8hfHA9cBLb/StDCNYwp27+YauI7j5QcBwBlaqUS2Hgri+mNRL+fCn?=
 =?us-ascii?Q?UQXwQ99nqA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61e5a5ad-d26e-411d-d214-08da1642e00d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 13:56:11.2125
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rRlQCzZP70i6zJAP0NcWlb3GS5kp3yjLLpuMIoUcVkmKN0hUy+Kb6ibqPdHP6/kj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4424
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 31, 2022 at 09:05:25PM +0800, Guo Zhengkui wrote:
> @@ -632,7 +632,7 @@ static int handle_join_req(struct mcast_group *group, u8 join_mask,
>  			kfree(req);
>  			ref = 1;
>  			group->state = group->prev_state;
> -		} else
> +		} else {
>  			group->state = MCAST_JOIN_SENT;
>  	}

This doesn't compile.

Jason