Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3465413pxb; Mon, 4 Apr 2022 17:51:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZYJWhfO9gvoVf+F537x+MMSKHTm1aF/3PUziR9eL25yUhI+YoqUOxtREpx834sIuhrPVh X-Received: by 2002:a17:902:ef43:b0:156:9c5d:b0fe with SMTP id e3-20020a170902ef4300b001569c5db0femr817527plx.158.1649119895714; Mon, 04 Apr 2022 17:51:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649119895; cv=none; d=google.com; s=arc-20160816; b=cqsCNvXIoCUdX62jOuIIVuAz3FR2UevodKBxMcwe56QIb9TgpIUC18G8tExYKkfmgu Qvemi98pTUTrygh+w7ONZpt/dn7WeFgPXOfQxfY0D/Kss11KIblhN8mnDgoOilZoSWZ5 UH88ITBswQT783hB1EWxnWh+pCVoiwAWeOb4tmwa58Jl4pJpxmVg0wZsL6C1LV4XfZ5z Sal6cVLxdEKfio9Du0nTAyO8uNA8ymtZsOx7mN6qXrejPz/F7kZsrqJDzS1LsZR8JsRB Eji2NwYtRCGdvJn6FcKMbt9ljPnRC/sa5rypJwJiBaAyXg/+lhuApuqnSfCyDLym207l M1yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:dkim-signature; bh=+x8xeE7VdwyEBg9gBJjb/VSkL3ctOrEYGykxx0ig/m0=; b=hOzU0P56NhHA0Q49nA73OirZucd1+FB+eCQbJnor6p9bS9eYsi4omkJTgPn7t2ifEz gaGAmzfU0L7CpsxHXLqTcSdwvUgWOLtd2qUVvV0fbc4wm2t5Y3Z5r3G/vBDo8IazEzMQ 5Cmxaik/PrQtrUHAIWT81BktRI1ROn4YwWBTEjGq5e5VPuMYYro5sz1MNKyTxg9/zadI MR5n+Z9ZnYMTlYqkB8lX7Cvicwj7LQ0ZmOoPsSjAlPYAgr+JBbEE5dVCPaL4dEgc14BM suVO2/83ftaDobwQGxnnpHCpwTOfNJea3xLXog+ywXinQ7X5B7St5pxH0CIsOldenVN9 DUcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aIIJqQOl; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id n14-20020a170903110e00b00154aa5ec43bsi12919816plh.154.2022.04.04.17.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 17:51:35 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aIIJqQOl; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ADE2FECC44; Mon, 4 Apr 2022 17:00:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380126AbiDDV7U (ORCPT + 99 others); Mon, 4 Apr 2022 17:59:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380060AbiDDSvT (ORCPT ); Mon, 4 Apr 2022 14:51:19 -0400 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43D053137D for ; Mon, 4 Apr 2022 11:49:23 -0700 (PDT) Received: by mail-oi1-x22e.google.com with SMTP id 12so10978263oix.12 for ; Mon, 04 Apr 2022 11:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+x8xeE7VdwyEBg9gBJjb/VSkL3ctOrEYGykxx0ig/m0=; b=aIIJqQOlgGEaPFjQYKZkBfSoalRDYuXCqe3vleD+YoMT6FyQdOFPNf+S+9sxlwUq54 NmltyIWDy33kTR0OTRadOhK77QdqSl8Vr+QvqTOBdxzTwwZoyooJtH7PAoM4B6VuHvOb mnKMngV7nKSgJ1NYzzG0jE2zETbUAFXGphzJoGcUTTRIAspUa2tNMrIYjM7MWIWIy/8E NjJS7bznd7wBf5/40L9ymVkjSitPiflm5WaSfgHVSllrk9/yCcHtgWJ+KTmIMLY7VEhr o2TpSk48hwsKaRx3fAQt2RGKCujfvasVxP9JLA++ZfvQi49nDSq+okk9BBSdlu/rffvk cO1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+x8xeE7VdwyEBg9gBJjb/VSkL3ctOrEYGykxx0ig/m0=; b=R3FbIAvaNstONR5LrL0tNQIVWBNxZqtoiGMXiZQZTBUFbUmcfnzLgznNP42LJfDgjX jOSGidS+c5GcLjySTf63M5ZAYYpL+C1CzxrqyV8zL3XG+7troMaPPX41KCFix7O+CqIu QdCCthreqQW2fPtOUxl5ksK6Y1iiXuA5lH34mUp77vSripFlrM3KbJrSfrz8Nildf07U ZfhSx0z4IskLfaH7wo+FHKJFxR48EiRHrQNSFY4y/UA8/Ias6CsoHrGY03CkKqE+/PpZ kqSW7j6T6N5BHeFp27959sJFpfgnjJNMAPP5LBv7Fqlj1AgCELKEIXw2b0NX3ClH48cx 5D3w== X-Gm-Message-State: AOAM530l5ilR9gOGJH0lLThQ9nsxnVavAJPAq2hHE+s2Y9wgpTUFkYY+ DBPja6WLZQLqWVDAv9PT9Ao= X-Received: by 2002:a05:6808:9ae:b0:2d9:a01a:4bf4 with SMTP id e14-20020a05680809ae00b002d9a01a4bf4mr238080oig.283.1649098162576; Mon, 04 Apr 2022 11:49:22 -0700 (PDT) Received: from ?IPV6:2603:8090:2005:39b3::1004? (2603-8090-2005-39b3-0000-0000-0000-1004.res6.spectrum.com. [2603:8090:2005:39b3::1004]) by smtp.gmail.com with ESMTPSA id m17-20020a0568301e7100b005b256697d7csm4795089otr.72.2022.04.04.11.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 11:49:21 -0700 (PDT) Sender: Larry Finger Message-ID: <547963ab-4922-3208-fe63-07e0756890d9@lwfinger.net> Date: Mon, 4 Apr 2022 13:49:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] staging: r8188eu: remove unnecessary blank lines Content-Language: en-US To: Alaa Mohamed , outreachy@lists.linux.dev Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220404145217.15069-1-eng.alaamohamedsoliman.am@gmail.com> From: Larry Finger In-Reply-To: <20220404145217.15069-1-eng.alaamohamedsoliman.am@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/22 09:52, Alaa Mohamed wrote: > Reported by checkpatch: > > CHECK: Blank lines aren't necessary before a close brace '}' > > Signed-off-by: Alaa Mohamed > --- > drivers/staging/r8188eu/core/rtw_ap.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c > index 2ff78ed1faab..ac6effbecf6d 100644 > --- a/drivers/staging/r8188eu/core/rtw_ap.c > +++ b/drivers/staging/r8188eu/core/rtw_ap.c > @@ -188,7 +188,6 @@ void expire_timeout_chk(struct adapter *padapter) > spin_lock_bh(&pstapriv->auth_list_lock); > } > } > - > } > spin_unlock_bh(&pstapriv->auth_list_lock); > > @@ -381,7 +380,6 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level) > /* set ra_id, init_rate */ > psta->raid = raid; > psta->init_rate = init_rate; > - > } > } > > @@ -455,7 +453,6 @@ void update_bmc_sta(struct adapter *padapter) > spin_lock_bh(&psta->lock); > psta->state = _FW_LINKED; > spin_unlock_bh(&psta->lock); > - > } > } > Acked_by: Larry Finger Thanks, Larry