Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <e0397927-06fc-933e-f73a-794e0629e0fd@amd.com>
Date:   Mon, 4 Apr 2022 11:57:08 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] drm/amd/display: cleanup extern usage in function
 definition
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch, wenjing.liu@amd.com, waynelin@amd.com,
        Anson.Jacob@amd.com, Yu-ting.Shen@amd.com, keescook@chromium.org,
        nicholas.kazlauskas@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220403142137.2234322-1-trix@redhat.com>
 <513a5993-2cc5-54fa-2d6c-f4162d76ab0e@amd.com>
 <462e2f2a-0cc8-2e2e-93b6-504cc12aa768@redhat.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <462e2f2a-0cc8-2e2e-93b6-504cc12aa768@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWFoVjkvS3Z5QnZwY2Rwei8zUm5lZEFJYmtEZlVvNmFnaFJYT3FjM0dYUUxB?=
 =?utf-8?B?K2hWa1pNUmMwRU5PWTFTOXQ3cGE4R1VEbitWYXRwMVFZb3NpODNtQ25OTjY3?=
 =?utf-8?B?WXJRQWdYOEtHSkl0ek9weVZFQTAzMkZDVER5RkRxa0J6bDlWbnNqZkEra3Zy?=
 =?utf-8?B?R3VWbHd2Z1NySmZGSVB2Q1h3d3hBbmRwUHFMcW5TMW5UTFV4aUdqVG5yaWdr?=
 =?utf-8?B?SU80U3lMNTFPZUJ1eDJXNVBtS29nKzhybGJUME5RSHFiYzloZHVESXRkdm5R?=
 =?utf-8?B?c0NYanNGQWkzMDlHTUNTTktOV1kvZ0ZHcTdpQVpSYnhqT0NFeFovU2hocjQy?=
 =?utf-8?B?MU92OGFlVmpyWHdIYXllUVhUUVhYUDBWSHNkckhHa1VmSTNkNmI1RUI2RGZU?=
 =?utf-8?B?MnR3KytpbnJBMERJREI2d3FYM3dUMzNta3hlS0wwVENXaWs2Y1V6N3BsemNn?=
 =?utf-8?B?K2tCeHJBUUR4bFovWDVJelhIcGZWSTRnQWhPam56c2lPR1I2L0tuTWEzZno5?=
 =?utf-8?B?ZUxJdGhkZFFPNTh5NjFhT3RJM3liaFIxYVJVbTlrVCt6YkorYUloUFB5eXlK?=
 =?utf-8?B?U21sdzJXWXp2eXRHZWQ1aEdwVlluR2o0ekZVTVd1TWFBdDF3VjJwUFA4bjIv?=
 =?utf-8?B?d0xIZzA3R1M4ZlhLTE1FNk9yTlM1UEdIVFhPTnE0WSsvS1ByQ2U2SHNXRGZp?=
 =?utf-8?B?TVRGWU1aeWRuWll2S2dWaWsrOCtYZnRlTnAxNkFkT1pyTlhhaUVnaDNyQjVN?=
 =?utf-8?B?MkxMazVJZ2VTbWxYbVhyaTdoaGNLVkJxQTFCcVdHUGxzaDhmU1hQemJGYmJ0?=
 =?utf-8?B?MXA3OTRLQ1JsUEZVWGhSMXdMWlFmTzcxWmgrZVg2dVJaVWlhTHJGZ0tNdHNQ?=
 =?utf-8?B?VEpxZlZ5UDFMK0dvYWlmT1liQ3hXSFh3MG41WkVPbGJoMm1GMm5mNnRXQndr?=
 =?utf-8?B?YkVxdVVQMXhuanVNa2tndi9VZjRnS0dsSUd2QkxpNkxHVGc5UzgrdmRqb3l6?=
 =?utf-8?B?dktyRmkxS2pGZUFBTmwyM0QzYUFUdE9KNWZHV2JabWU2cTVxT01ZYW8wNThx?=
 =?utf-8?B?L3MxOEU5c3cvVFErazA2WmdJSUM4UkJhR0JteXhTOTF1VS84aE4zVkZEU0VT?=
 =?utf-8?B?Y1owelRyWVJ4c0s2RUFERmhwZ01hSW9zbjF0SkNMQ29ObUE1UzZHYjlSalZJ?=
 =?utf-8?B?VlVRaUwzb0dkMndtT1RUeDYrbnpPcEVOcWxBbmdiMmJURWh5Vlp0cDBWU05O?=
 =?utf-8?B?NWZPV2tXbHphTWlDMDFpOEc5ZFFLY1JaMit6aDhXZldIMXlsZ3VBaFVwRGFV?=
 =?utf-8?B?VDVXdk0zTXVMTGRIVXo4cWoyUGRwYTlDamNDYTJZWTA1bmMzTCtocHMzVld5?=
 =?utf-8?B?ZVVtUVlIRnRnck9SRVpUanQxT1Q0WDl1U3hvQSs0cFFBWVVaODBEQWttdlZS?=
 =?utf-8?B?WmhLdDQ1ODVXOHR5Y1R0Rys4eHNPRzlJaTQ5M1FoQkE1TEh1a2VnbDZXdk8v?=
 =?utf-8?B?TDMvWlg0L0ZvbmRDN3MxQWZhTDY5QmhMTU1UUE9WRW1Ebk1XN1lrM0x0bDIw?=
 =?utf-8?B?ZElpMkZiZ09Uc1NKMnAvdVpEelVJL1lTT1gzT0VOUDR3dWZjZmYzZzM2azAy?=
 =?utf-8?B?ZjNTeTJjM21TV1RzbWtaOUVmYyt1ampIZDdKTTJpU0dMZHF6ZWd5eFh6dkxT?=
 =?utf-8?B?RkhZWjZRbUF6SFl5c1VMVUpScm1KalZOUDJMUmt5U3NTdHQ5M2ZobFVzeS9m?=
 =?utf-8?B?YUpqa0xwZnBucGpPd0N5SEFWNWxqNUptOE1zektzSHdMQzBWMkQzcy9zdEo0?=
 =?utf-8?B?TFhWcWNjcEc3TDlCemtWQTJsYkpkTkF6UUZNaDRHZ2lCVzZLenQyUTBRY0NX?=
 =?utf-8?B?ZnpvdFRvV2R3U0pVR2czQ2dCTGd1TkYwOFg1VmxDdkZCcnpvYks5ZlFUdzBs?=
 =?utf-8?B?bnorZHBQOTNWQWJxd1N6Ly9aTDJEa1AvTUdWNitlNGF6MFg3cDAxRVJhdnl3?=
 =?utf-8?B?d2h6Y2UvL1k5c095OTdQL2ZZQ2J4T2luZEtrRDYwRVF2Q2p3bTVnb2Zmb2tR?=
 =?utf-8?B?N1FJQXloajBxNTgxSHEwL3FxMUM1Rmo5S080L3NGWjZ4bXNWWGdpUHg3OGJL?=
 =?utf-8?B?TUVBZ1VYYzVvOGRxdHZXVzl6VjA3dE90OVpoNkdyNkJSTWZjV05lTm9WeEhT?=
 =?utf-8?B?cnJXNmJEaHdsVmdFbXo1aitaN2xpbEtla1plaUR5bENRRnc4L2pMNmpWaklo?=
 =?utf-8?B?dmZuNFg2MnkxazVGZDVKc3V0eDZKVGw5a0tnd2RMUVBSbDdkczA1Vnp2Z3p4?=
 =?utf-8?B?U3BMZ2ozdVJaclN3L2Q4Zy9nWnhxMDZicFdxRk94WEhWVVBWMmtjZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9952ec56-6f73-4060-590d-08da1653c845
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 15:57:12.6461
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LC+bw/sAM1kJH32zjmHRV0k2rYU25njytlU09Fo1NfjRYFJylDtb6FLsvv0LFlTylscqvXU2bb2c+xagE1dq0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2397
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-04-04 11:43, Tom Rix wrote:
> 
> On 4/4/22 8:22 AM, Harry Wentland wrote:
>>
>> On 2022-04-03 10:21, Tom Rix wrote:
>>> Smatch reports this issue
>>> hdcp1_execution.c:500:29: warning: function
>>>    'mod_hdcp_hdcp1_dp_execution' with external linkage
>>>    has definition
>>>
>> Which branch are you using?
> 
> linux-next from 4/1
> 

Apologies. I was looking at the wrong function.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> Tom
> 
>>
>> I don't see the 'extern' on
>> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c>>>
>> Harry
>>
>>
>>> The storage-class-specifier extern is not needed in a
>>> definition, so remove it.
>>>
>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>> ---
>>>   drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>>> index 6ec918af3bff..1ddb4f5eac8e 100644
>>> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>>> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>>> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
>>>       return status;
>>>   }
>>>   -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>>> -        struct mod_hdcp_event_context *event_ctx,
>>> -        struct mod_hdcp_transition_input_hdcp1 *input)
>>> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>>> +                         struct mod_hdcp_event_context *event_ctx,
>>> +                         struct mod_hdcp_transition_input_hdcp1 *input)
>>>   {
>>>       enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
>>>   
>