Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <ba21a1d3-26bb-cc80-57b5-6bd416de5e93@gmx.de>
Date:   Sat, 2 Apr 2022 23:29:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] parisc: Switch from GENERIC_CPU_DEVICES to
 GENERIC_ARCH_TOPOLOGY
Content-Language: en-US
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     James.Bottomley@hansenpartnership.com,
        linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220401154137.GA3745625@roeck-us.net>
 <57e79014-25e6-62d3-27de-64797e43992b@gmx.de>
 <927a54f9-b413-0c71-461d-28ed9d5ece96@roeck-us.net> <YkdiDJZ/XHODymRk@p100>
 <6353bc69-901e-32e7-e736-00dd6a09a1ea@roeck-us.net>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <6353bc69-901e-32e7-e736-00dd6a09a1ea@roeck-us.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 4/2/22 23:27, Guenter Roeck wrote:
> On 4/1/22 13:35, Helge Deller wrote:
>> Hi G=C3=BCnter,
>>
>> * Guenter Roeck <linux@roeck-us.net>:
>>> On 4/1/22 09:47, Helge Deller wrote:
>>>> Hi G=C3=BCnter,
>>>>
>>>> On 4/1/22 17:41, Guenter Roeck wrote:
>>>>> On Thu, Mar 24, 2022 at 07:46:50PM +0100, Helge Deller wrote:
>>>>>> Switch away from the own cpu topology code to common code which is =
used
>>>>>> by ARM64 and RISCV. That will allow us to enable CPU hotplug later =
on.
>>>>>>
>>>>>> Signed-off-by: Helge Deller <deller@gmx.de>
>>>>>
>>>>> This patch results in the following traceback when
>>>>> booting generic-32bit_defconfig - SMP in qemu.
>>>>
>>>> That's strange, because I just built this generic-32bit_defconfig mys=
elf and
>>>> it boots up nicely in qemu for me. The only thing missing is CONFIG_C=
GROUPS=3Dy so that
>>>> systemd can start.
>>>>
>>>
>>> Did you disable SMP (that is what - SMP was supposed to mean) ?
>>> Also, note that the system does boot fine, it just spits out the warni=
ng.
>>
>> The patch below fixes the warning for me.
>> Could you try?
>>
>
> I did, and it fixes the problem. I just sent a Tested-by: in response to
> your patch.

Thanks for testing !!
Helge


>
> Guenter
>
>> Helge
>>
>>
>> From: Helge Deller <deller@gmx.de>
>> Subject: [PATCH] parisc: Re-enable GENERIC_CPU_DEVICES for !SMP
>>
>> In commit 62773112acc5 ("parisc: Switch from GENERIC_CPU_DEVICES to
>> GENERIC_ARCH_TOPOLOGY") GENERIC_CPU_DEVICES was unconditionally turned
>> off, but this triggers a warning in topology_add_dev(). Turning it back
>> on for the !SMP case avoids this warning.
>>
>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> Fixes: 62773112acc5 ("parisc: Switch from GENERIC_CPU_DEVICES to GENERI=
C_ARCH_TOPOLOGY")
>> Signed-off-by: Helge Deller <deller@gmx.de>
>>
>> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
>> index 52e550b45692..bd22578859d0 100644
>> --- a/arch/parisc/Kconfig
>> +++ b/arch/parisc/Kconfig
>> @@ -38,6 +38,7 @@ config PARISC
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select ARCH_HAVE_NMI_SAFE_CMPXCHG
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select GENERIC_SMP_IDLE_THREAD
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select GENERIC_ARCH_TOPOLOGY if SMP
>> +=C2=A0=C2=A0=C2=A0 select GENERIC_CPU_DEVICES if !SMP
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select GENERIC_LIB_DEVMEM_IS_ALLOWED
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select SYSCTL_ARCH_UNALIGN_ALLOW
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select SYSCTL_EXCEPTION_TRACE
>