Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3481072pxb; Mon, 4 Apr 2022 18:20:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjRTxPgRZW3ZSypPltwUytz9fJJPn56FGGGpoZifr8aS0s8Ubz/5cXar/vRpJVqwqflPwy X-Received: by 2002:a17:902:ce8b:b0:154:6031:b569 with SMTP id f11-20020a170902ce8b00b001546031b569mr867188plg.128.1649121629386; Mon, 04 Apr 2022 18:20:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649121629; cv=none; d=google.com; s=arc-20160816; b=F1R+9HQP4JHKoRexpFk9huxaOo/xqZIQqNV7YmCC1GPiepo4bIbbF92RQ39RDmAyFw rjav/coLjuFGYK6Vl+Soq1005OF55rj9JaXwgwnyQIhG3AlXQSLV+Akc6uKP0F1UmNzq OmO19AJKZL1Pr+pptf9knVE3UAXpK6awIYm04wiHVtPekU6BqtOCoAXy+1nlDewc/jbh TyCD+8+9s4ryZ7pJMe0aLDM8MhUtP4piPQ9p3pTQoPrPQmLl7xkOmoc1If1f82hLg6BP rv8tn6Wa9YFy7c2hKvynp9Tl2SBVLXYYQrmVjPXuvJWTaAaitvE9En8/bvg4U7/oG5Xj 1Hhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=r2j/pcW1fvMsyQZ6vu4g8yHXh5I4NDXXn+Z1PC/1UbE=; b=CGOR3dhtKZcODLtU8FJWU1flPr9TLERdJqyQ8bHbyKRf4dt5N+V3tb+X4cN82hc0FV jYh+pGrGF5vQZsucdWmBeqT9aRjIdHqpWrOUIltA3UHJ2i8xYCWC/DbmMonP50KPw6Lw ROJJzsK0eo43Oey+AVSnF0Sdq5f9NAYJ19jFK0KJX0PoN4pBEU7RI8/mZykUCQ9wRr92 /NrJEXAyCWC8RogmJ6FJx1FnEHuDVw0AH2kyDEkaG+3NWsPA3zYwHkGGUzgJtrIGHmnO VbO+NsU65I2sL2rolr3oJim7rQo/9qF1WHoPNSZhKfK7eOhGIxVE5v6lz2qRCjyRaEdP 0Suw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id mw17-20020a17090b4d1100b001c613fa106asi775888pjb.163.2022.04.04.18.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 18:20:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0DB6C7B565; Mon, 4 Apr 2022 17:23:28 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378796AbiDDP6a (ORCPT + 99 others); Mon, 4 Apr 2022 11:58:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378771AbiDDP6X (ORCPT ); Mon, 4 Apr 2022 11:58:23 -0400 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9849E15A17; Mon, 4 Apr 2022 08:56:26 -0700 (PDT) X-IronPort-AV: E=Sophos;i="5.90,234,1643641200"; d="scan'208";a="115683064" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 05 Apr 2022 00:56:25 +0900 Received: from localhost.localdomain (unknown [10.226.36.204]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 0584B40037EF; Tue, 5 Apr 2022 00:56:23 +0900 (JST) From: Lad Prabhakar To: Sean Wang , Vinod Koul , Matthias Brugger , dmaengine@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Prabhakar , Lad Prabhakar Subject: [PATCH v3 3/3] dmaengine: mediatek-cqdma: Use platform_get_irq() to get the interrupt Date: Mon, 4 Apr 2022 16:55:57 +0100 Message-Id: <20220404155557.27316-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220404155557.27316-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20220404155557.27316-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static allocation of IRQ resources in DT core code, this causes an issue when using hierarchical interrupt domains using "interrupts" property in the node as this bypasses the hierarchical setup and messes up the irq chaining. In preparation for removal of static setup of IRQ resource from DT core code use platform_get_irq(). Signed-off-by: Lad Prabhakar Reviewed-by: Andy Shevchenko --- drivers/dma/mediatek/mtk-cqdma.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c index 41ef9f15d3d5..f8847c48ba03 100644 --- a/drivers/dma/mediatek/mtk-cqdma.c +++ b/drivers/dma/mediatek/mtk-cqdma.c @@ -751,7 +751,6 @@ static int mtk_cqdma_probe(struct platform_device *pdev) struct mtk_cqdma_device *cqdma; struct mtk_cqdma_vchan *vc; struct dma_device *dd; - struct resource *res; int err; u32 i; @@ -824,13 +823,10 @@ static int mtk_cqdma_probe(struct platform_device *pdev) return PTR_ERR(cqdma->pc[i]->base); /* allocate IRQ resource */ - res = platform_get_resource(pdev, IORESOURCE_IRQ, i); - if (!res) { - dev_err(&pdev->dev, "No irq resource for %s\n", - dev_name(&pdev->dev)); - return -EINVAL; - } - cqdma->pc[i]->irq = res->start; + err = platform_get_irq(pdev, i); + if (err < 0) + return err; + cqdma->pc[i]->irq = err; err = devm_request_irq(&pdev->dev, cqdma->pc[i]->irq, mtk_cqdma_irq, 0, dev_name(&pdev->dev), -- 2.17.1