Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3489594pxb; Mon, 4 Apr 2022 18:38:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQgjSKAHwkeu1BYPTaKFXUx2D49TMTnq3hj6oAFgxa9Ls3BqeM7yR2UjTWRDiHE1cZ1ifg X-Received: by 2002:a17:903:22cb:b0:156:c64b:fa34 with SMTP id y11-20020a17090322cb00b00156c64bfa34mr985678plg.100.1649122688121; Mon, 04 Apr 2022 18:38:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649122688; cv=none; d=google.com; s=arc-20160816; b=xXasd5K1cL2pLFj7TYv8pZR742qTrkYWg+kCA5+m/tkWrWZCn6KoYG4UBm3akt8PWI z8tnopvj3qWVbgcqB9eC75R1wkSFRVOBaN5D5wqD9agU+t6VEIrm3pROzpQIv0rwbZ9r V3SA3so5qhEFJdC0CQxrLIYWAhvTWoTZjTHPutuuX23cCdGfLG+DD6/BNZRbXJMq+iN0 5HW3d6crTC3TY8bcKJbzkUNL6YOxNIYM3gCWikAPb9KW6kJ1nVCtTL98z3HxWCcbHlKh Dwd8F9GTPIpgttTlQZCC7lbVwM/+p3fvdMRWBDkvVHnBIbYs/SPeJofdsxZWcTT25ZQg ODvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=kVXOau0G8SadTthzNAHHFAJXW+6903XrTiZEOmvCc28=; b=SyF2aQxBLvG3+3oNrwPrwzuuuhZPFWv8LPE5y6WKPQsA8hlqnwT/oI5MpNwHtZttZs q/f5zXC8rWW0Jx1X+EG1Bvxi2096pRLAl3u6YEisCiqUVJkQP8Px5RGHcfKYqQs/s/K9 DzPCYwYkaX1XIecuVjNt/JiBM+vg4GwR0XIvLkLm4X4SAn+Rc2W9/TflNY8phSIcdr22 r0rZ1xQsm72tpoXRuMcSJ+Zl7yAld6piATOgEP9sIrGrYJn7qPztT02Jv5TYMTqVEs96 x4zHxork32ckdQrEHKlH0lxaBjUz+BjFgpTEylBH34bbe6l2tsXloywbToSelurXTh7d 4YOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=pMccEIrl; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f7-20020a170902ce8700b00153b2d16540si12343113plg.328.2022.04.04.18.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 18:38:08 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=pMccEIrl; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0992E1148; Mon, 4 Apr 2022 17:31:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241368AbiDDXPF (ORCPT + 99 others); Mon, 4 Apr 2022 19:15:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243154AbiDDXOn (ORCPT ); Mon, 4 Apr 2022 19:14:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8971E24BD8; Mon, 4 Apr 2022 15:55:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 482E0B819DE; Mon, 4 Apr 2022 22:55:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B060DC2BBE4; Mon, 4 Apr 2022 22:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649112918; bh=YJPKmsV50zrBbXBnSBP0IPEb8ro9ZtjvwhW0Jj1bEm8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pMccEIrlU08djbT7wpa1ZN4nuH6BttjslEaHrMrXBm3RIBKlSfoT0f/FcYT2iS3ls IYcRnNyMZ2Ls6Geib4sGfeWHOyVNPrHRYk5vsSDvKGz4SQVWlct+pYgglSnVLUFkJ2 f9M0YKMLgA0eGO3o2jNb33HftQnjOIzmrwYzIOVU= Date: Mon, 4 Apr 2022 15:55:16 -0700 From: Andrew Morton To: Jakob Koschel Cc: Mike Rapoport , David Hildenbrand , Oscar Salvador , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." Subject: Re: [PATCH] fs/proc/kcore.c: remove check of list iterator against head past the loop body Message-Id: <20220404155516.a5fb4c23ee017a7212e4b22c@linux-foundation.org> In-Reply-To: References: <20220331223700.902556-1-jakobkoschel@gmail.com> <20220331164843.b531fbf00d6e7afd6cdfe113@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Apr 2022 09:19:57 +0200 Jakob Koschel wrote: > > Speaking of limiting scope... > > Fair point :-) > > I see you have applied this already to the -mm tree. Shall I still move the iterator? > The hope is to remove the 'iter' variable altogether when there are no uses after > the loop anymore. I don't really understand the question. My plan is to merge your patch with my fixlet immediately prior to sending upstream.