Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <99f1181b-fde2-43a5-9b6a-c0c3a8b3933f@linaro.org>
Date:   Sun, 3 Apr 2022 17:30:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 6/6] dt-bindings: power: supply: qcom,smb2: add bindings
 for smb2 driver
Content-Language: en-US
To:     Kuldeep Singh <singh.kuldeep87k@gmail.com>
Cc:     Caleb Connolly <caleb.connolly@linaro.org>,
        Sebastian Reichel <sre@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Amit Pundir <amit.pundir@linaro.org>,
        Sumit Semwal <sumit.semwal@linaro.org>
References: <20220401202643.877609-1-caleb.connolly@linaro.org>
 <20220401202643.877609-7-caleb.connolly@linaro.org>
 <20220403071426.GA49153@9a2d8922b8f1>
 <798f0244-95dd-cf2d-7bc5-02c72c7fa327@linaro.org>
 <20220403133122.GA49428@9a2d8922b8f1>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220403133122.GA49428@9a2d8922b8f1>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/04/2022 15:31, Kuldeep Singh wrote:
> On Sun, Apr 03, 2022 at 09:56:25AM +0200, Krzysztof Kozlowski wrote:
>> On 03/04/2022 09:14, Kuldeep Singh wrote:
>>> On Fri, Apr 01, 2022 at 09:26:43PM +0100, Caleb Connolly wrote:
>>>> Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger
>>>> drivers.
>>>>
>>
>> (...)
>>
>>>
>>>> +    pmic {
>>>> +      #address-cells = <1>;
>>>> +      #size-cells = <0>;
>>>> +      #interrupt-cells = <4>;
>>>> +
>>>> +      smb2@1000 {
>>>> +        compatible = "qcom,pmi8998-smb2";
>>>> +        reg = <0x1000>;
>>>> +
>>>> +        interrupts = <0x2 0x13 0x4 IRQ_TYPE_EDGE_BOTH>;
>>>> +        interrupt-names = "usb-plugin";
>>>> +
>>>
>>> In-between new lines may not be required.
>>> And DTs use tabs instead of 2 spaces, we can follow that here also.
>>
>> The DT examples in bindings use spaces. Either two (like YAML) or four
>> (for easier reading).
> 
> ok, since example snippet is taken from DT that's why I said four
> spaces(tab) as it will be closest to actual env.

You said "use tabs", which is 8 spaces in Linux. So to clarify - we do
not use tabs here, so do not use tabs.

>>>> +        io-channels = <&pmi8998_rradc 3>,
>>>> +                      <&pmi8998_rradc 4>;
>>>> +        io-channel-names = "usbin_i",
>>>> +                           "usbin_v";
>>>
>>> Channel-names can be written in one line.
>>
>> They match the format of io-channels, so this is quite readable.
> 
> io-channels doesn't exceed max characters in line(i.e 75) even after
> being clubbed. Won't be better if kept in one line?
> This might be personal perspective but I thought it's worth mentioning.

I find current code readable. The other option would be fine as well,
kind of does not matter to me much.

Best regards,
Krzysztof