Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3491541pxb; Mon, 4 Apr 2022 18:41:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3zPufGIljbDH4O3atcWGcUuXeb4XWFi2THImgpfs6lYaUWlmNJuB5Jw5x9Z7l//xJFJgv X-Received: by 2002:a17:90b:2246:b0:1c6:5781:7193 with SMTP id hk6-20020a17090b224600b001c657817193mr1354717pjb.48.1649122902056; Mon, 04 Apr 2022 18:41:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649122902; cv=none; d=google.com; s=arc-20160816; b=yM/w36QIR2pwBEdV2VLXCOEv1o+tt/ri8HFfgBdziT0eT5Te2cCiF47kpjs0+Xe32Q K+yR855O25O3fjT55Xtl39hAaZ4GK0bRmejKeuiNpH+u6beTRcdOTlLQ4+ZXVWMnvbBZ CgB25gtW3u82jKgDayNDJXwoOt3FABhvSGYvhSFG9mwGfClmw1mF3acVuR9ODveIZ83M fk/T3TIDf1xPunNAIunRGZJDRojHVagUroElUxo8wREUcyeJOPS5egOFEZpzgrgsiusb Em+DxWAHXKeuSlkIzd809IM/aUNzKlLPTYEppbOMwXcsHChgygO/HcqG79J6goIf60Cw Me7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2HjVlEdlul+lX8f7wTuHDWSA2vrSz2EQiEfHXKjpjQA=; b=HKuI5AJHYsQknOPprGWH+ArK+aWBLHGosRhghGg5dj2Ns+lsvsrxN2vSA4ROv8y3w6 BcNaXdZRFNk1HI4W6dFB3jL95vcz0AHizAOAmqoc3pAZhKzrUFr68eWUsJ4KsP7HXH8f N3JUdTAcb9CxWdAlbG7LtgkkfIANpVzt7Uq8NCfr6fnypeUaSmQyKBQJ4bP1fhVCGm7M TJqbzuJSeokw3twkPub8qaw9wE6t55V8EFZlMaAs1axkV97cPtq5MpHGfHtukANXiSHi 01WHDy9IvYwnMsoVBG40R1TlwQ7Qdgya8+LhkyF9vSSkT3ms5absKcQ/7wKK6MvAVeDY 5Q1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=l59mXDjK; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d6-20020a170903230600b00153b2d16520si11887841plh.296.2022.04.04.18.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 18:41:42 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=l59mXDjK; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 50CFB284E6C; Mon, 4 Apr 2022 17:38:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243684AbiDCSsh (ORCPT + 99 others); Sun, 3 Apr 2022 14:48:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234612AbiDCSsg (ORCPT ); Sun, 3 Apr 2022 14:48:36 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0C473207A; Sun, 3 Apr 2022 11:46:39 -0700 (PDT) Received: from zn.tnic (p2e55dff8.dip0.t-ipconnect.de [46.85.223.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E98FD1EC03C9; Sun, 3 Apr 2022 20:46:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1649011594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=2HjVlEdlul+lX8f7wTuHDWSA2vrSz2EQiEfHXKjpjQA=; b=l59mXDjKhhUMPxGyiKT5DqGFArOaluj0rtOErU/Kmc6OR2Ykb0xgnSdo4Eyi1AISV5hs9z nw71ZvTedtXnzJMSILspBrlQg/TyemPcww0YQ225kU6gjbNS+er+UNOAhCEmtTd9/JsczC ipHhGjzNthdXa7Cj9jj7Qw1YsbxIdYU= Date: Sun, 3 Apr 2022 20:46:30 +0200 From: Borislav Petkov To: Ammar Faizi Cc: Thomas Gleixner , Alviro Iskandar Setiawan , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Tony Luck , Yazen Ghannam , Linux Edac Mailing List , Linux Kernel Mailing List , Stable Kernel , GNU/Weeb Mailing List , x86 Mailing List Subject: Re: [PATCH v6 2/2] x86/MCE/AMD: Fix memory leak when `threshold_create_bank()` fails Message-ID: References: <20220329104705.65256-1-ammarfaizi2@gnuweeb.org> <20220329104705.65256-3-ammarfaizi2@gnuweeb.org> <87wng6ksjl.ffs@tglx> <215ca9e7-b719-d5b8-c6db-1d71544d47be@gnuweeb.org> <00347b4a-e719-9dac-b42b-05a3f117fd46@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <00347b4a-e719-9dac-b42b-05a3f117fd46@gnuweeb.org> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 04, 2022 at 12:45:04AM +0700, Ammar Faizi wrote: > > Yazen, Borislav, please take a deeper look on this again. I will send > > a v7 revision to really make it simpler by moving that "per-CPU var write" > > before the loop. > > (only if it's really safe) Don't bother - I've discussed it with tglx offlist. The current solution remains. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette