Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Eric DeVolder <eric.devolder@oracle.com>
To:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
        eric.devolder@oracle.com
Subject: [PATCH v6 5/8] kexec: exclude elfcorehdr from the segment digest
Date:   Fri,  1 Apr 2022 14:30:37 -0400
Message-Id: <20220401183040.1624-6-eric.devolder@oracle.com>
In-Reply-To: <20220401183040.1624-1-eric.devolder@oracle.com>
References: <20220401183040.1624-1-eric.devolder@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6XEhXALry3Pb5c/XWp17v76Jc4u0BSrhxvuFPJj8ncMDHmfnXsFUO12hy7Va?=
 =?us-ascii?Q?psgO4290Otrg7BBgf7PTUGg9RwMIXFpI8VFAcqroaNEtZ1T/cyDGpVLOf8ik?=
 =?us-ascii?Q?vZlJ47Q6kRxRtuEdFMjkGk6PYIWQYOIkwsQNB6MMORL/LbT4sMWSyVEZH3z+?=
 =?us-ascii?Q?kCAub1vdiYeDmrxqlCFBeJME+2Fjfg/qtesxq6S8/kzWeB8T/N9hF2VJn3ro?=
 =?us-ascii?Q?Vms7l9pxsZT0fHiBrcJTLIAxmsXj6ZdPSQU/Cm9WpwneF2crZ55/hUZr1lBv?=
 =?us-ascii?Q?dqRX/O2OLXjhm7hhhGGvC27igwfGP2u3hoioPQ4RUJ1KMe8GUpFlCMKzIH87?=
 =?us-ascii?Q?pmbEpjeKtzl5c0kP0aMDVzCKT60u7hV8yyhIDRGimPn86Z5bmZAU8UlbyDsZ?=
 =?us-ascii?Q?RN1jYTKuW0bOYBvwh6J9mZNnF2WGTV9l9mHJI1WC2DaIWX3JUMWsKEW3dnW9?=
 =?us-ascii?Q?96pTKaZTrlHB6Z6nkHmwO1HImc3oJ8NsBb+e39pHxATMLDP8EURM3+WIOCZG?=
 =?us-ascii?Q?VKtxvSGOVOFxaNjkQEXo/z7/AbeVYHKzbcniC/xZKQFCYU3yvOVX7TaVgOre?=
 =?us-ascii?Q?Svc/d2yyx1Z6nrrZEhbHuTrVKmkS5fscn2ASILQOE/gr76q20n/34MFNgz+D?=
 =?us-ascii?Q?IUykY50IsAUI6s5AKDC33BkKoaoG2hZ33kjQFxpe62HeXbE6B4pB4ru6Y1j6?=
 =?us-ascii?Q?qnYHORJx0UbeUR+t+t+QMsa5utJ+NC5SW6MsJdWYbTplKIYNbV8Uge+ct/x8?=
 =?us-ascii?Q?4oHvNAoS09rGH+jzD0KjAoriTyOaP8QO1lkgSkauD/Y+3arvMySdau0QJwqs?=
 =?us-ascii?Q?hbXTWW84Wl3N8HdvZji//5YrC5iAsu00oE6UQiNuoobZUiah6yleHm7goj7x?=
 =?us-ascii?Q?nDiGI2AQCHusgCJw60dYAP8xPeGGCRv7ouCtTV+bwHH+baDILm+eR0qm9xgC?=
 =?us-ascii?Q?KMIhE0WwoEBGJt0VeHxNKdhrFPeeOz3NstUbhbOQGikFTq0lwanR/aycHHDw?=
 =?us-ascii?Q?3lWnc/DFScH2Fe1gjEan58pis5EuPM1UiLr42KXyFxZag/lf3Tn+bRDDSyF8?=
 =?us-ascii?Q?xJ/575QQK3fEX/Z7qQdXTlUTtVx97m72Mc1adE4Tqc5kVljF6ShPLd64+sc8?=
 =?us-ascii?Q?2iAY4t6oeiidhS/buFmBMs/HQry/pWBhRLyc72yf/kXyCQw63sD1MtNqCst1?=
 =?us-ascii?Q?n6Srxu9BHJGqvFfY7u6M6/rmEcaSS2OASgNVG/l+lE/xaj2xdjg1A6mxTSob?=
 =?us-ascii?Q?5RkHE7xhhPL3MopC6SZ3QFaxly+m+UEQcHRKjPMQA4dqbDuaxz0pHotNiaJ7?=
 =?us-ascii?Q?GWWpMmDXOuGkDnjpqFQM6FjR5wAPJ5IYTNuZaV6BhiLdb3WLY1E1RL/0Ihet?=
 =?us-ascii?Q?JtWxcGTz/Pla5rOawgihZBPgDRhufNEBoXOXINJCQsgpUxvQ43zdrPufC/Lz?=
 =?us-ascii?Q?ZEsIRzgLSsFnwBZLJWj5Ft0WNxW7SMBXZUF4InODtrdwjlqy27lSfeIdnUrD?=
 =?us-ascii?Q?IYYHrUF7lzi4eQ//yLaAxOx5XzOOK2G+pMyU1UKHnBGgSGzAxC9SVA5s7bZE?=
 =?us-ascii?Q?aOnWZvksLTlYcb5R2uxX3wbsPBuvnEU8wCpglrvfA6flXv8MTXAvdsNAGPGT?=
 =?us-ascii?Q?VuvfAsDZ1kYJPc/PSDNnnY1xCGwjmil7YP6lrc0pkmDmu83yvDcW9aXbMKta?=
 =?us-ascii?Q?x6NhwTbKySmeV93ryGwjg26LB/DstcfI3Jn5DwqCOyNN65xMKTM3Z6XagG6K?=
 =?us-ascii?Q?hDqZaG5NncSa1yzyaBctsfkQMUzvoDQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86480e38-5fef-484a-a0d7-08da140dcb14
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 18:31:10.1697
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e8YbbJRZ44rdhR88U5fgqiHNMgGRknCMgrnLj3TNtqM95lom15fbVsBh1YZenKgcoLdu4bQTE+dGF/d3Is3ZGSeGS0gbzTYJPiVcrkN5Ifs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3268
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-01_05:2022-03-30,2022-04-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 spamscore=0 mlxscore=0 phishscore=0 malwarescore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204010088
X-Proofpoint-ORIG-GUID: tnjTQmq1b7JlxD_PM-XbPamGPYkGr9uL
X-Proofpoint-GUID: tnjTQmq1b7JlxD_PM-XbPamGPYkGr9uL
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When a crash kernel is loaded via the kexec_file_load syscall, the
kernel places the various segments (ie crash kernel, crash initrd,
boot_params, elfcorehdr, purgatory, etc) in memory. For those
architectures that utilize purgatory, a hash digest of the segments
is calculated for integrity checking. This digest is embedded into
the purgatory image prior to placing purgatory in memory.

Since hotplug events cause changes to the elfcorehdr, purgatory
integrity checking fails (at crash time, and no kdump created).
As a result, this change explicitly excludes the elfcorehdr segment
from the list of segments used to create the digest. By doing so,
this permits changes to the elfcorehdr in response to hotplug events,
without having to also reload purgatory due to the change to the
digest.

Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
Acked-by: Baoquan He <bhe@redhat.com>
---
 kernel/kexec_file.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
index 801d0d0a5012..94a459209111 100644
--- a/kernel/kexec_file.c
+++ b/kernel/kexec_file.c
@@ -765,6 +765,12 @@ static int kexec_calculate_store_digests(struct kimage *image)
 	for (j = i = 0; i < image->nr_segments; i++) {
 		struct kexec_segment *ksegment;
 
+#ifdef CONFIG_CRASH_HOTPLUG
+		/* This segment excluded to allow future changes via hotplug */
+		if (image->elfcorehdr_index_valid && (j == image->elfcorehdr_index))
+			continue;
+#endif
+
 		ksegment = &image->segment[i];
 		/*
 		 * Skip purgatory as it will be modified once we put digest
-- 
2.27.0