Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH] taprio: replace usage of found with dedicated list
 iterator variable
From:   Jakob Koschel <jakobkoschel@gmail.com>
In-Reply-To: <877d8a3sww.fsf@intel.com>
Date:   Sun, 3 Apr 2022 13:53:06 +0200
Cc:     Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Content-Transfer-Encoding: quoted-printable
Message-Id: <6118F17F-6E0B-4FDA-A7C4-E1C487E9DB8F@gmail.com>
References: <20220324072607.63594-1-jakobkoschel@gmail.com>
 <87fsmz3uc6.fsf@intel.com> <A19238DC-24F8-4BD9-A6FA-C8019596F4A6@gmail.com>
 <877d8a3sww.fsf@intel.com>
To:     Vinicius Costa Gomes <vinicius.gomes@intel.com>
Precedence: bulk

Hi,

> On 31. Mar 2022, at 19:58, Vinicius Costa Gomes =
<vinicius.gomes@intel.com> wrote:
>=20
> Jakob Koschel <jakobkoschel@gmail.com> writes:
>=20
>>> On 31. Mar 2022, at 01:15, Vinicius Costa Gomes =
<vinicius.gomes@intel.com> wrote:
>>>=20
>>> Hi,
>>>=20
>>> Jakob Koschel <jakobkoschel@gmail.com> writes:
>>>=20
>>>> To move the list iterator variable into the list_for_each_entry_*()
>>>> macro in the future it should be avoided to use the list iterator
>>>> variable after the loop body.
>>>>=20
>>>> To *never* use the list iterator variable after the loop it was
>>>> concluded to use a separate iterator variable instead of a
>>>> found boolean [1].
>>>>=20
>>>> This removes the need to use a found variable and simply checking =
if
>>>> the variable was set, can determine if the break/goto was hit.
>>>>=20
>>>> Link: =
https://lore.kernel.org/all/CAHk-=3DwgRr_D8CB-D9Kg-c=3DEHreAsk5SqXPwr9Y7k9=
sA6cWXJ6w@mail.gmail.com/
>>>> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
>>>> ---
>>>=20
>>> Code wise, patch look good.
>>>=20
>>> Just some commit style/meta comments:
>>> - I think that it would make more sense that these were two separate
>>> patches, but I haven't been following the fallout of the discussion
>>> above to know what other folks are doing;
>>=20
>> Thanks for the input, I'll split them up.
>>=20
>>> - Please use '[PATCH net-next]' in the subject prefix of your =
patch(es)
>>> when you next propose this (net-next is closed for new submissions =
for
>>> now, it should open again in a few days);
>>=20
>> I'll include that prefix, thanks.
>>=20
>> Paolo Abeni [CC'd] suggested to bundle all net-next patches in one =
series [1].
>> If that's the general desire I'm happy to do that.
>=20
> I agree with that, having one series for the whole net-next is going =
to
> be easier for everyone.

I have all the net-next patches bundled in one series now ready to =
repost.
Just wanted to verify that's the intended format since it grew a bit =
larger
then what was posted so far.

It's 46 patches changing 51 files across all those files:

 drivers/connector/cn_queue.c                            | 13 =
++++++-------
 drivers/net/dsa/mv88e6xxx/chip.c                        | 21 =
++++++++++-----------
 drivers/net/dsa/sja1105/sja1105_vl.c                    | 14 =
+++++++++-----
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c          |  3 ++-
 drivers/net/ethernet/intel/i40e/i40e_main.c             | 24 =
++++++++++++++----------
 drivers/net/ethernet/mellanox/mlx4/alloc.c              | 29 =
+++++++++++++++++++----------
 drivers/net/ethernet/mellanox/mlx4/mcg.c                | 17 =
++++++++---------
 drivers/net/ethernet/mellanox/mlx5/core/eq.c            | 10 +++++++---
 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c       | 12 =
++++++------
 drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c   | 21 =
++++++++++++---------
 drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c      |  7 +++++--
 drivers/net/ethernet/mellanox/mlxsw/spectrum_mr.c       | 12 =
+++++++++---
 drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c | 25 =
++++++++++++-------------
 drivers/net/ethernet/qlogic/qed/qed_dev.c               | 11 =
++++++-----
 drivers/net/ethernet/qlogic/qed/qed_iwarp.c             | 26 =
++++++++++++--------------
 drivers/net/ethernet/qlogic/qed/qed_spq.c               |  6 +++---
 drivers/net/ethernet/qlogic/qede/qede_filter.c          | 11 =
+++++++----
 drivers/net/ethernet/qlogic/qede/qede_rdma.c            | 11 =
+++++------
 drivers/net/ethernet/sfc/rx_common.c                    |  6 ++++--
 drivers/net/ethernet/ti/netcp_core.c                    | 24 =
++++++++++++++++--------
 drivers/net/ethernet/toshiba/ps3_gelic_wireless.c       | 30 =
+++++++++++++++---------------
 drivers/net/ipvlan/ipvlan_main.c                        |  7 +++++--
 drivers/net/rionet.c                                    | 14 =
+++++++-------
 drivers/net/team/team.c                                 | 20 =
+++++++++++++-------
 drivers/net/wireless/ath/ath10k/mac.c                   | 19 =
++++++++++---------
 drivers/net/wireless/ath/ath11k/dp_rx.c                 | 15 =
+++++++--------
 drivers/net/wireless/ath/ath11k/wmi.c                   | 11 =
+++++------
 drivers/net/wireless/ath/ath6kl/htc_mbox.c              |  2 +-
 drivers/net/wireless/intel/ipw2x00/libipw_rx.c          | 14 =
++++++++------
 drivers/rapidio/devices/rio_mport_cdev.c                | 42 =
++++++++++++++++++++----------------------
 drivers/rapidio/devices/tsi721.c                        | 13 =
++++++-------
 drivers/rapidio/rio.c                                   | 14 =
+++++++-------
 drivers/rapidio/rio_cm.c                                | 81 =
+++++++++++++++++++++++++++++++++++++
 net/9p/trans_virtio.c                                   | 15 =
+++++++--------
 net/9p/trans_xen.c                                      | 10 ++++++----
 net/core/devlink.c                                      | 22 =
+++++++++++++++-------
 net/core/gro.c                                          | 12 =
++++++++----
 net/dsa/dsa.c                                           | 11 =
+++++------
 net/ieee802154/core.c                                   |  7 +++++--
 net/ipv4/udp_tunnel_nic.c                               | 10 ++++++----
 net/mac80211/offchannel.c                               | 28 =
++++++++++++++--------------
 net/mac80211/util.c                                     |  7 +++++--
 net/sched/sch_cbs.c                                     | 11 =
+++++------
 net/sched/sch_taprio.c                                  | 11 =
+++++------
 net/smc/smc_ism.c                                       | 14 =
+++++++-------
 net/tipc/group.c                                        | 12 =
++++++++----
 net/tipc/monitor.c                                      | 21 =
++++++++++++++-------
 net/tipc/name_table.c                                   | 11 =
+++++++----
 net/tipc/socket.c                                       | 11 =
+++++++----
 net/wireless/core.c                                     |  7 +++++--
 net/xfrm/xfrm_ipcomp.c                                  | 11 =
+++++++----
 51 files changed, 452 insertions(+), 364 deletions(-)

Please let me know if I should split it up or if there are certain files =
that might not fit.
Otherwise I'll post them beginning of next week.

>=20
>=20
> Cheers,
> --=20
> Vinicius

Thanks,
Jakob