Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3492992pxb; Mon, 4 Apr 2022 18:44:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7gQ2aEMO7rFJil59VT9O87m3BWXSft7jLksGQSWq9rOcYYqXH1uqSdvTe8RMwi1jE1HhI X-Received: by 2002:a17:90b:2406:b0:1ca:ab60:60ae with SMTP id nr6-20020a17090b240600b001caab6060aemr1318621pjb.226.1649123084464; Mon, 04 Apr 2022 18:44:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649123084; cv=none; d=google.com; s=arc-20160816; b=NS8T/N03AEOBXXjGX68tUPFDYtXnp45tXZpnv9anVhRc/3jjP4rhMlPxCJ8GdIyMBr TKFdnQHpon6PJKZkcXB1Wbjwm4wdnjShcgkF7rJAgdnP4LEMbLbLuxoK9W6oEV3oRjnt oW42bMeGz5jlp6Q4ZuwQaP/+Xt86gt7NDxjwTkrIM8lFg6n0P+bfu/jg0cNOAagaUPSS Mn72l8h6G9kQTV4lndmntI/e5CzBSfaD8yU4vyWigaHjes6K0HrAJ3iA9trXdlT8ZI2j g3A8pdTG3y3xmkrmuwalhzYWvzO0SVge47l6CSeCqtHY4nWNxQQSxb64G2noKlN1nWqh TNhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3lAFfHy33FJv196rnV5yMyEFhXSQMIQgUO/mtSRSAR0=; b=HIjT4NPLEIHBP8gFVC93wBjcvAuJTEPGVipL5Tqed14eRiydlMy7MC3qsMxRlzZRg0 Qn5Pn1sMeB/gMc8DHuZ95s1dSJT5at5VQlt6I+WkNNh9S3/CKcHHzng7o/MwDjEa2wIP hMyrEGBq5uPYLatiBa7k6ggnm/1rmNU6FIjfovBEJc2Nnzm+ZB2+uESuhv5UGcLBmD8r nf7ivRy+J41pe7lShkb7iOHxbQNWX4FlEXaHUUeiaLqVJwGwnQM4kWG1e5wPFzaN2UCf JiIEOT1R2SLoBtH/DaGsj0d84hm0lfIavGs3plMemA3SOym876w0nM7aGeq48gdqdhh6 MUTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ingics-com.20210112.gappssmtp.com header.s=20210112 header.b=zqgM88tM; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id p17-20020a170902e75100b00153b2d16486si12823352plf.142.2022.04.04.18.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 18:44:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@ingics-com.20210112.gappssmtp.com header.s=20210112 header.b=zqgM88tM; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B98B02AE9DD; Mon, 4 Apr 2022 17:43:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356563AbiDCNZQ (ORCPT + 99 others); Sun, 3 Apr 2022 09:25:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234624AbiDCNZP (ORCPT ); Sun, 3 Apr 2022 09:25:15 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E36592FFF3 for ; Sun, 3 Apr 2022 06:23:20 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id b13so6647694pfv.0 for ; Sun, 03 Apr 2022 06:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3lAFfHy33FJv196rnV5yMyEFhXSQMIQgUO/mtSRSAR0=; b=zqgM88tMjPT3479UPmMgW/1Vt5OomA8m2uBCmnttd3pYcGNkHVGngtiW19+GXq3j1R 1crt3TMtSfzxzaL/X+V5e3D2FpErMnah3HnC3tg4jJw96HD3VlaUPDcItFAzxt7X56j7 a20shh/U9SrDZIjoUdtC75aUgrrdeVYWdV+y9pUXjgN0yA1XfhAbMq9rXpUQ4/6UcKw3 MciZtQ2VV5zSXHi5TV7ZcyfwOWpkcuB+WJoFu2CFADcrQJM5BwdD5ynCiysupSlgp6E4 XvF6LNU/LyVytPz4ici+1+/35ug3sLzrxXHlAz9Cjsk4LcLbI7iUqQ6EYYvQ89MyaCXN t14g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3lAFfHy33FJv196rnV5yMyEFhXSQMIQgUO/mtSRSAR0=; b=WnN6tKyKJm6/2cyhTyiP9u27r/muBzmNAsnZwZHn+5uDa/SiVFI5XaIqx0HY3hZgCr /D7wH1cMuyGwhZH73HlAyZpk7ZVGX98sotYOZzcwZAZfJXC1A4SwUuEnXlv6CE8a4N4N BfCpMeLWxLGe3xyCjskQElOxdXGfDRmgafPXSviB9zPY+0AWDUTh7VuUerh3wZIMHeaa hU0+nQYmGfhHPu/RtQ0FXDXXqGRIoSASsPeLvw7QQyUX0dnkTY360UTEfLiQtkIPuifs Orc/rRoAkaxME4jeENn09bfohLATnyVVffgAg1mSTFvBFLyA88O36f2atohk43Qdxx+p f/rg== X-Gm-Message-State: AOAM533tguJxryEmroq9UhoLD7r0DMEaA5W8HZ/X4ojcGj210lR9b14U GFPONY/gMrY2F0+wXKbt2fP4Zw== X-Received: by 2002:a05:6a00:1593:b0:4fb:344:2c40 with SMTP id u19-20020a056a00159300b004fb03442c40mr47937240pfk.44.1648992200299; Sun, 03 Apr 2022 06:23:20 -0700 (PDT) Received: from alpha.. (122-117-179-2.hinet-ip.hinet.net. [122.117.179.2]) by smtp.googlemail.com with ESMTPSA id d16-20020a056a00245000b004f7728a4346sm9277203pfj.79.2022.04.03.06.23.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Apr 2022 06:23:19 -0700 (PDT) From: Axel Lin To: Mark Brown Cc: Manivannan Sadhasivam , Cristian Ciocaltea , "Liam Girdwood linux-actions @ lists . infradead . org" , linux-kernel@vger.kernel.org, Axel Lin Subject: [PATCH] regulator: atc260x: Fix missing active_discharge_on setting Date: Sun, 3 Apr 2022 21:22:35 +0800 Message-Id: <20220403132235.123727-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Without active_discharge_on setting, the SWITCH1 discharge enable control is always disabled. Fix it. Fixes: 3b15ccac161a ("regulator: Add regulator driver for ATC260x PMICs") Signed-off-by: Axel Lin --- drivers/regulator/atc260x-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/atc260x-regulator.c b/drivers/regulator/atc260x-regulator.c index 05147d2c3842..485e58b264c0 100644 --- a/drivers/regulator/atc260x-regulator.c +++ b/drivers/regulator/atc260x-regulator.c @@ -292,6 +292,7 @@ enum atc2603c_reg_ids { .bypass_mask = BIT(5), \ .active_discharge_reg = ATC2603C_PMU_SWITCH_CTL, \ .active_discharge_mask = BIT(1), \ + .active_discharge_on = BIT(1), \ .owner = THIS_MODULE, \ } -- 2.32.0