Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 4 Apr 2022 16:44:26 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Wander Costa <wcosta@redhat.com>
Cc:     Wander Lairson Costa <wander@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Johan Hovold <johan@kernel.org>,
        "Maciej W. Rozycki" <macro@orcam.me.uk>,
        Lukas Wunner <lukas@wunner.de>,
        Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        =?iso-8859-1?Q?Andr=E9?= Goddard Rosa <andre.goddard@gmail.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        David Laight <David.Laight@aculab.com>,
        Jon Hunter <jonathanh@nvidia.com>, phil@raspberrypi.com
Subject: Re: [PATCH v6] serial/8250: Use fifo in 8250 console driver
Message-ID: <Ykr2OmXZyByrZ1uu@smile.fi.intel.com>
References: <20220401194645.1738747-1-wander@redhat.com>
 <20220401194645.1738747-2-wander@redhat.com>
 <Ykq7FXhQfsvr9TtC@smile.fi.intel.com>
 <CAAq0SUn4Z2y4-7fJcZ-T5rrnuwdJCt2+W-bGGmCxU6t+pA165A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAq0SUn4Z2y4-7fJcZ-T5rrnuwdJCt2+W-bGGmCxU6t+pA165A@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Apr 04, 2022 at 10:27:30AM -0300, Wander Costa wrote:
> On Mon, Apr 4, 2022 at 6:32 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Apr 01, 2022 at 04:46:42PM -0300, Wander Lairson Costa wrote:

...

> > > +     use_fifo = (up->capabilities & UART_CAP_FIFO) &&
> > > +             /*
> > > +              * BCM283x requires to check the fifo
> > > +              * after each byte.
> > > +              */
> > > +             !(up->capabilities & UART_CAP_MINI) &&
> >
> > Perhaps you need to also comment why we are using tx_loadsz and not fifosize.
> 
> Maybe it is better to document their difference in the struct
> declaration and not in a random usage.

Here, when one reads a code (as a non-familiar with the area), the use of
tx_loadsz confuses if one saw previously fifosize used somewhere. So, I agree
that it's good to document in the structure, but here it's also good to have
a comment to briefly hint the reader why this and not the other one is used.

-- 
With Best Regards,
Andy Shevchenko