Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <bdd168a8-b260-0653-f835-a7814a8fd4c8@gmail.com>
Date:   Mon, 4 Apr 2022 10:02:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V2] Fix unsafe memory access by memcmp
Content-Language: en-US
To:     Charlie Sands <sandsch@northvilleschools.net>,
        gregkh@linuxfoundation.org
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        paskripkin@gmail.com
References: <YkpdVyuQguGzPSNE@sckzor-linux.localdomain>
From:   Michael Straube <straube.linux@gmail.com>
In-Reply-To: <YkpdVyuQguGzPSNE@sckzor-linux.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/4/22 04:52, Charlie Sands wrote:
> This patch fixes sparse warnings about the memcmp function unsafely
> accessing userspace memory without first copying it to kernel space.
> 
> Signed-off-by: Charlie Sands <sandsch@northvilleschools.net>
> ---
> 
> V2: Fixed checkpatch.pl warning and changed variable name as suggested
> by Greg K. H. and improved error checking on the "copy_from_user" function as
> suggested by Pavel Skripkin.
> 
>   drivers/staging/r8188eu/os_dep/ioctl_linux.c | 21 ++++++++++++--------
>   1 file changed, 13 insertions(+), 8 deletions(-)
> 

Hi Charlie,

thanks for your patch. Looks good to me, but you should include
staging: r8188eu: in the subject line.

"staging: r8188eu: Fix unsafe memory access by memcmp"

thanks,
Michael