Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <039c9eada49e9eeca48c39c5bea0fac0ab68c673.camel@intel.com>
Subject: Re: [RFC PATCH v5 038/104] KVM: x86/mmu: Allow per-VM override of
 the TDP max page level
From:   Kai Huang <kai.huang@intel.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jim Mattson <jmattson@google.com>, erdemaktas@google.com,
        Connor Kuehl <ckuehl@redhat.com>
Date:   Mon, 04 Apr 2022 12:41:16 +1200
In-Reply-To: <YkeUDJP1AWKU/ixG@google.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
         <5cc4b1c90d929b7f4f9829a42c0b63b52af0c1ed.1646422845.git.isaku.yamahata@intel.com>
         <c6fb151ced1675d1c93aa18ad8c57c2ffc4e9fcb.camel@intel.com>
         <YkcHZo3i+rki+9lK@google.com>
         <43098446667829fc592b7cc7d5fd463319d37562.camel@intel.com>
         <YkeUDJP1AWKU/ixG@google.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 2022-04-02 at 00:08 +0000, Sean Christopherson wrote:
> On Sat, Apr 02, 2022, Kai Huang wrote:
> > On Fri, 2022-04-01 at 14:08 +0000, Sean Christopherson wrote:
> > > On Fri, Apr 01, 2022, Kai Huang wrote:
> > > > On Fri, 2022-03-04 at 11:48 -0800, isaku.yamahata@intel.com wrote:
> > > > > From: Sean Christopherson <sean.j.christopherson@intel.com>
> > > > > 
> > > > > In the existing x86 KVM MMU code, there is already max_level member in
> > > > > struct kvm_page_fault with KVM_MAX_HUGEPAGE_LEVEL initial value.  The KVM
> > > > > page fault handler denies page size larger than max_level.
> > > > > 
> > > > > Add per-VM member to indicate the allowed maximum page size with
> > > > > KVM_MAX_HUGEPAGE_LEVEL as default value and initialize max_level in struct
> > > > > kvm_page_fault with it.
> > > > > 
> > > > > For the guest TD, the set per-VM value for allows maximum page size to 4K
> > > > > page size.  Then only allowed page size is 4K.  It means large page is
> > > > > disabled.
> > > > 
> > > > Do not support large page for TD is the reason that you want this change, but
> > > > not the result.  Please refine a little bit.
> > > 
> > > Not supporting huge pages was fine for the PoC, but I'd prefer not to merge TDX
> > > without support for huge pages.  Has any work been put into enabling huge pages?
> > > If so, what's the technical blocker?  If not...
> > 
> > Hi Sean,
> > 
> > Is there any reason large page support must be included in the initial merge of
> > TDX?  Large page is more about performance improvement I think.  Given this
> > series is already very big, perhaps we can do it later.
> 
> I'm ok punting 1gb for now, but I want to have a high level of confidence that 2mb
> pages will work without requiring significant churn in KVM on top of the initial
> TDX support.  I suspect gaining that level of confidence will mean getting 95%+ of
> the way to a fully working code base.  IIRC, 2mb wasn't expected to be terrible, it
> was 1gb support where things started to get messy.

OK no argument here :)

-- 
Thanks,
-Kai