Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3508283pxb; Mon, 4 Apr 2022 19:14:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyq+5vVll18iUlCLesRLPxTBB9/SkKFqeLWWsuDrlmAr4hxKWtBgpDo7db9RBhLdUSg4nnR X-Received: by 2002:a05:6a00:140c:b0:4e1:530c:edc0 with SMTP id l12-20020a056a00140c00b004e1530cedc0mr1257137pfu.18.1649124872239; Mon, 04 Apr 2022 19:14:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649124872; cv=none; d=google.com; s=arc-20160816; b=DIgpE9g/CeVvCT5IQqrBYo8hXieeNbC+OKedcoGwKu2PX+EqcPBBTG5yGVbynwwnj1 UEnjKPL/dxNgNsVrDK5YYqNe4stosfbN3wplI+KoEwTzFAk3Jwlxonsby4bCr9lvg/Ef EcKvUK1EEBDD46cbMkN4C0xTnFowz31VNS706HU6ITqu/lDeGlEx6i/5tLBjIFoVtk4p tRasPWDXCDC/l5Ta6cerVk9PRJz//jFsvur83unr/+8v0AxQykZQo0UNW2JOASs1fgdw H7m8BrU8RyQlmrm9EMwdfInJAQayxlG4mzh1CnQggtT4uqZXzIfWjqmAzNGkCd4CSvUE NneQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=oQXip11/mOq1QEIb7Uh7PfUGeTnBxSjdGMNgDU3H0ac=; b=UM4W17Z3Iqnt1IIiafcni6DAhdgKLFTvSzYkxxoMmW1C+M/kF+UInLU9cHkN+pG9Hm l8Pn7NESBWQJzIx0+BWyCCrCl8kgiYPz66BqXGPd2Ggs+tuEU1+4E6JigvgzSE7SX5Vn Do+xV/TBY1+TR2rf7jx27g34p1ykCkf2xlOOeWI21cTLauawrwjc3ZqdJ5JTPz2N3zuu ZcJyU0t0Itid2Ipzcpf02p7DOvUjQeUrE6/m6jChl7Qe2D8WRcjhU0niWym7wH08UpY8 51SuRA1PEzbLfWws2wbA4dqnWpE2AKn65AY4DS4UuRoey7QJeQlqA3u+iVbCKPzB4kOt /kHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="sFPpy6/1"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id h6-20020a632106000000b003816043f10dsi10769988pgh.770.2022.04.04.19.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 19:14:32 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="sFPpy6/1"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 82E3C273835; Mon, 4 Apr 2022 17:37:17 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378054AbiDDO7K (ORCPT + 99 others); Mon, 4 Apr 2022 10:59:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348346AbiDDO7I (ORCPT ); Mon, 4 Apr 2022 10:59:08 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD3141CB1B for ; Mon, 4 Apr 2022 07:57:12 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id x21so11887463ybd.6 for ; Mon, 04 Apr 2022 07:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oQXip11/mOq1QEIb7Uh7PfUGeTnBxSjdGMNgDU3H0ac=; b=sFPpy6/1ERVilOjkhoNtdU6pzyexFt9dvn8SKKMJfIG2Qtk3XLX6kW46rCfdemme06 QLVikzfPklS+9789YRedbVZNG9vCKmAXYBqTm+oxmSoXtl7AEU9lAaUa5jWqs9UYE9sM yFECOLoBML1fKtj4hqurE1FBRLG7nsR1mpmLYtb5ijpgb6frVlG1HTH0L96Epwz/Kyz7 /DjT9HpXAGnx+MUwOrA9zFVUEGhhPS2zohqq/7QJJDqEBtdzjIkyXPAaZ4+FGbv9CfFv fBMcu+KM0UNHhn7zzrqdnQFSR6CG0Sk216wg118fddoib1KIuZl5NG+K4xOVbSVAQT4D CY1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oQXip11/mOq1QEIb7Uh7PfUGeTnBxSjdGMNgDU3H0ac=; b=ydtS4eojKHhfbD2YIc0VBBvgYi2PLQstFn6Ibv3o8xdq0684XQbm7lOOk2FywTUA+g j1YK7wi9lqwc2FuiZ9zVFeXzxQN4R42k3quUaRBdh+Tb1/vo1tU8DtYxE7QnKp9TBYMI 3Ik6qvC7XbUcKUe3mspo9Z7yjNWpvlmIfXIT3RP195cBsCJZILhSkXe6/EuTGUYiiOqC lu8c+XamchwEiAIjipRwbyLtvVsBNOTpcWsNVJ2AAJmi65qQ/mUm6+UL0ATnBtOFJnFD O3WnUWHxSaqugrVICXfUkJ6DW6WcsUZayZgkWeCBiqWL7dl/QN6nEdZE7iNBgwDra7p4 Am/A== X-Gm-Message-State: AOAM531bnkXLl2A0qZox4Ia//XMPWOCiDWUjEtZ4akOlIWwvOQem1BhJ LqUsnYvENq7Jc3hDNrwIKnVNYnKQBxqTgMRtczGlrQ== X-Received: by 2002:a25:d897:0:b0:63d:af73:1115 with SMTP id p145-20020a25d897000000b0063daf731115mr185537ybg.274.1649084231809; Mon, 04 Apr 2022 07:57:11 -0700 (PDT) MIME-Version: 1.0 References: <20220329124017.737571-1-glider@google.com> <20220329124017.737571-32-glider@google.com> In-Reply-To: <20220329124017.737571-32-glider@google.com> From: Alexander Potapenko Date: Mon, 4 Apr 2022 16:56:35 +0200 Message-ID: Subject: Re: [PATCH v2 31/48] kernel: kmsan: don't instrument stacktrace.c To: Alexander Potapenko Cc: Alexander Viro , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , Linux Memory Management List , Linux-Arch , LKML Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2022 at 2:41 PM Alexander Potapenko wrote: > > When unwinding stack traces, the kernel may pick uninitialized data from > the stack. To avoid false reports on that data, we do not instrument > stacktrace.c This patch is not needed anymore if we unpoison the stack traces passed to __stack_depot_save() from KMSAN core.