Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220401015828.2959505-1-victor.liu@nxp.com>
In-Reply-To: <20220401015828.2959505-1-victor.liu@nxp.com>
From:   Jagan Teki <jagan@amarulasolutions.com>
Date:   Fri, 1 Apr 2022 20:22:32 +0530
Message-ID: <CAMty3ZC6pLJXP=kxwFeZj6CF87ASvoxz9+8Z-7O+DCNwtcLHcQ@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge: nwl-dsi: Drop the drm_of_panel_bridge_remove()
 function call
To:     Liu Ying <victor.liu@nxp.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Robert Foss <robert.foss@linaro.org>,
        =?UTF-8?Q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>,
        NXP Linux Team <linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 1, 2022 at 7:26 AM Liu Ying <victor.liu@nxp.com> wrote:
>
> Since this driver has been changed to use the resource managed
> devm_drm_of_get_bridge() to get bridge from ->attach(), it's
> unnecessary to call drm_of_panel_bridge_remove() to remove the
> bridge from ->detach().  So, let's drop the drm_of_panel_bridge_remove()
> function call.  As nwl_dsi_bridge_detach() only calls
> drm_of_panel_bridge_remove(), it can also be dropped.
>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Guido G=C3=BCnther <agx@sigxcpu.org>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---

Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>