Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3523219pxb; Mon, 4 Apr 2022 19:50:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw558NFVD5apqU0+8BmQLprGpAMH0mmGR0JwE2Idoc9M98TPHskOsYTM8HQjndEsVkIQqBz X-Received: by 2002:a17:90a:aa8a:b0:1c9:bfd8:9a90 with SMTP id l10-20020a17090aaa8a00b001c9bfd89a90mr1498786pjq.118.1649127010785; Mon, 04 Apr 2022 19:50:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649127010; cv=none; d=google.com; s=arc-20160816; b=cyPvfpO9Dx5yHtmvbNJpEa3JusDQpR9Yhe7eKNMYSUzHzwB2KxDkuP9pgk45BrJ1S+ 8Xz5pE9hk2jinSUE9tin4FFAKzBVXc1QsEU3LTf9fIqS+NmB367v1lQuabEB88RNUdjH I0AEJpMjIGWGDXXv672Mn8SrXu0lCUg5h9y3/WO57sayK2M/i7+5AbfkndPYjc3eHoDY B4pGaOfkS6nUQTUEtuiuGHA/pUzvkqCe6NBIs6rZfU1+xN+6TiprkkVUF3ip9sEh+p2A cIPJs0istafRu2e1zSo52tKpIxdj0GCwPqFRiAwS+1qTJSCIJsB2qSSo8jczB9Jk7dWo MUKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id; bh=9aUSkfCyh4kUmbGbhLtrRS6XncdxscmKrdIGfukhV8o=; b=gQTWzMOLmz5UnX9koOgs1FAsxWPNmu4z8XgBFzt289RVGNYNQfynilueH92oWfgFch UxBd0cBzOxj6xEEU44c+i+xZy4w9oypW9kHfZw5Hv1i+XD+1HJVMwlasyQQK7hCL/cgv VFxGgr40yDA0ygtRa4luPs/mz7QsG+TXiYlMAv29bZH3LLxzA/yyDVtbnmuoEE3r6WHL WdpTPdBBh+EAHzKrsyY2gdulowOXywlqSazdPHaD74MAHoGimdaantb5yXtcLbmUMatw qWLgEJ6L0YI6VQgf/Uyvai1rt5kygfknn2A5sfTf1JS2fayFVRt6tgJIKiSEIMzgv4Zm 7qYw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id kb12-20020a17090ae7cc00b001c6a62efe0dsi1025615pjb.89.2022.04.04.19.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 19:50:10 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9D85E435BF0; Mon, 4 Apr 2022 18:13:50 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376373AbiDDNzJ (ORCPT + 99 others); Mon, 4 Apr 2022 09:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346907AbiDDNzF (ORCPT ); Mon, 4 Apr 2022 09:55:05 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8234::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16AA03EABC; Mon, 4 Apr 2022 06:53:08 -0700 (PDT) Received: from ip4d144895.dynamic.kabel-deutschland.de ([77.20.72.149] helo=[192.168.66.200]); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1nbN8k-0007Bt-C0; Mon, 04 Apr 2022 15:53:06 +0200 Message-ID: <539ff0c5-a95b-836d-e1c6-39f64ee2a418@leemhuis.info> Date: Mon, 4 Apr 2022 15:53:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17 Content-Language: en-US From: Thorsten Leemhuis To: Basavaraj Natikar , Basavaraj Natikar Cc: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, Linux Kernel Mailing List , "regressions@lists.linux.dev" , Marco References: <048ef583-4a8f-96b0-68a3-45ab9ec8d6df@leemhuis.info> <0499f8ae-6966-be4b-5af8-e7e568bfcd5f@amd.com> <6fe27103-5e35-5f16-d213-29bd71412f5b@leemhuis.info> <7dfb121f-848c-873e-f3cc-43239c264f21@amd.com> <0a33735c-dd43-4305-ff92-7b9ac2c6a0d9@leemhuis.info> In-Reply-To: <0a33735c-dd43-4305-ff92-7b9ac2c6a0d9@leemhuis.info> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1649080389;1ce2c595; X-HE-SMSGID: 1nbN8k-0007Bt-C0 X-Spam-Status: No, score=-1.4 required=5.0 tests=APP_DEVELOPMENT_NORDNS, BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.04.22 09:25, Thorsten Leemhuis wrote: > On 04.04.22 09:18, Basavaraj Natikar wrote: >> >> >> On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote: >>> On 01.04.22 21:47, Basavaraj Natikar wrote: >>>> Committed patch is disabling the interrupt mode and does not cause any >>>> functionality or working issues. >>> Well, for the reporter it clearly does cause problems, unless something >>> in testing went sideways. >>> >>>> I also cross verified on 3 system and working fine on 5.17 and not able >>>> to reproduce or recreate. >>>> [...] >>>> ------------------------------------------------ >>>> >>>> Looks like this is not regression. May be some hardware/firmware bug. >>> Well, from the point of the kernel development process it afaics is a >>> regression, unless the testing went sideways. It doesn't matter if the >>> root cause is in fact a hardware/firmware bug, as what matters in the >>> scope of the kernel development is: things worked, and now they don't. >>> For details please check this file and read the quotes from Linus: >> >> can you help to answer the below questions: > > Me? No, I'm just the Linux kernels regression tracker trying to make > sure all regressions are handled appropriately. :-D > > Marco, can you help out here? Marco replied in private and allowed me to forward his reply: ``` I can't since, as mentioned previously, this is the only AMD laptop device that I have. I am sure this is a regression for me, even if the issue is firmware related. I have tested the 5.17 stock arch kernel and the sensor is gone. With the last three patches reverted the sensor is back and working fine. I would love to verify if the issue is hardware or software related, but being outside of AMD and with AMD not releasing any public information with datasheet/specification on their Sensor Fusion Hub I really can't say anything specific. This still remains a regression, since the hardware was working before and now it doesn't. By the way, I already have seen also this rework of this specific driver https://github.com/conqp/amd-sfh-hid-dkms that even added a still missing handler for the lid sensor switch for disabling touchpad and keyboard, and all efforts tried to merge it upstream with all sorts of issues. Regardless of everything, this is a driver supported in kernel by AMD engineers, so all of this doesn't matter. On my hardware this three patches break a previously working hardware. ``` Ciao, Thorsten > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > P.S.: As the Linux kernel's regression tracker I'm getting a lot of > reports on my table. I can only look briefly into most of them and lack > knowledge about most of the areas they concern. I thus unfortunately > will sometimes get things wrong or miss something important. I hope > that's not the case here; if you think it is, don't hesitate to tell me > in a public reply, it's in everyone's interest to set the public record > straight. > >> Did you attempt to test it multiple times on the tip of the git to see >> if the problems goes away? >> >> if same test is performed multiple times with or without reverting patch >> on same platform (laptop/hardware/firmware) on which issue is observed >> we may see same working/issue behavior. if it is regressing then always >> it should work with or without reverting patches on same laptop. is this >> the case here? >> >> I don't see any regression here. I requested to retest with other >> hardware/platform/system also as per my above test (output) all working >> fine in 3 different platforms and not able to reproduce or recreate for >> my side on 5.17. >> >> Thanks, >> >> Basavaraj >> >>> >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandling-regressions.rst&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nv4ZzNeRgRCrjnEgh5wHGcqSAHaCffdWxGm%2BsjiPu0Y%3D&reserved=0 >>> >>> Ciao, Thorsten >>> >>>> Just curious reverting this patch how it is working just suspecting >>>> firmware undefined behavior. >>>> >>>> If possible, please check on other platform/system also if same behavior >>>> occurs. >>>> >>>> Could you please provide me platform/system details so that I can check >>>> this behavior? >>>> >>>> Thanks, >>>> Basavaraj >>>> >>>> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote: >>>>> Hi, this is your Linux kernel regression tracker. >>>>> >>>>> I noticed a regression report in bugzilla.kernel.org that afaics nobody >>>>> acted upon since it was reported about a week ago, that's why I decided >>>>> to forward it to the lists and all people that seemed to be relevant >>>>> here. It looks to me like this is something for Basavaraj, as it seems >>>>> to be caused by b300667b33b2 ("HID: amd_sfh: Disable the interrupt for >>>>> all command"). But I'm not totally sure, I only looked briefly into the >>>>> details. Or was this discussed somewhere else already? Or even fixed? >>>>> >>>>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jXu50hKBHkHzjOrfEQ0sXme3%2BdliBd%2FleA%2F9oE61EpI%3D&reserved=0 : >>>>> >>>>>> Marco 2022-03-25 15:22:19 UTC >>>>>> >>>>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=o443EB8xRW%2BwEi7pxB82A8B0oty64pBSQwAEU4sF2UA%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working. >>>>>> >>>>>> Marco. >>>>> Anyway, to get this tracked: >>>>> >>>>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4 >>>>> #regzbot from: Marco >>>>> #regzbot title: input: hid: input from the accelerometer disappeared due >>>>> to changes to amd_sfh >>>>> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jXu50hKBHkHzjOrfEQ0sXme3%2BdliBd%2FleA%2F9oE61EpI%3D&reserved=0 >>>>> >>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) >>>>> >>>>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of >>>>> reports on my table. I can only look briefly into most of them and lack >>>>> knowledge about most of the areas they concern. I thus unfortunately >>>>> will sometimes get things wrong or miss something important. I hope >>>>> that's not the case here; if you think it is, don't hesitate to tell me >>>>> in a public reply, it's in everyone's interest to set the public record >>>>> straight. >>>>> >>>> >> >> >>