Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 4 Apr 2022 16:33:13 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Michael Straube <straube.linux@gmail.com>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        "open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: staging: r8188eu: how to handle nested mutex under spinlock
Message-ID: <20220404133312.GC3293@kadam>
References: <356c24cf-625b-eea2-2c04-ce132d881cac@gmail.com>
 <bf1137fa-5051-a834-0c1f-042c5a8074a3@gmail.com>
 <1858641.taCxCBeP46@leap>
 <2366209.jE0xQCEvom@leap>
 <617af7b6-eeac-372a-7bbb-828db11a2aa9@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <617af7b6-eeac-372a-7bbb-828db11a2aa9@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B3ZH0Z7qAFaRgfk+zNcAWoV+JNrzF0/MBA1KWd4f7XpYZ1jmTkD9G1ggOFs5?=
 =?us-ascii?Q?xPBpyEzV+mm1Lk6xM/8I69vfd73+sdGo7zx61oIGxY/qqnKFfpyOkHlsvdEv?=
 =?us-ascii?Q?S1T5tQp5zOC4RHTRwJtlLQTNqUNPDE+gmXcvA7PF4PsvV31VLgRYREnT2bZa?=
 =?us-ascii?Q?XFnf89JVqL7MTGk3QzApoeE2cbg08v7bpoUJ9JulLIHlTFU34yUuqZPbGoHZ?=
 =?us-ascii?Q?/FPPnMdYXmVlmSEFvbfFrlcJLqANTZyq6SNYX4dfwyDuAvgRvzw23S3TCEWs?=
 =?us-ascii?Q?IkDADAiveGhfNhRdLurtnKjNLFUiVgid4zLm3eFPfEnB2YtRBcmzM9P+siCJ?=
 =?us-ascii?Q?ybzcpT7onaP3vk6fAbuRC7QoUs4wVpkDwERBvA+IclbR5PgHWXnFZ1fPXKvw?=
 =?us-ascii?Q?zHyCfxviLYKR3W8nwUD/ZsqyMAbAjQeWGVI886LcHmzEGfRtjEJ4yARPCnJA?=
 =?us-ascii?Q?W5AcQnd0QFlQULuERtGrpS4e8aTRWKA3hd96TY7vyVcqoOPgardBXNBKEc9o?=
 =?us-ascii?Q?XkOX5ufdbjq2aVxPXMeYQsiEDBC6bUNwMj1279p+mLIkmB+7+lFDi2zb+xDR?=
 =?us-ascii?Q?Z2mifqYahF30ZPR8RfPFY1YKoWPs8No2QuQU3gatdB/lczkJl7IMzKlck4gP?=
 =?us-ascii?Q?LMNfenmfcQ+UX7j1eWMjJ3DjvWX/cqtOgTtpEKLvlJHzqIzkvcQZRTlw3OgO?=
 =?us-ascii?Q?umhb3roOxQqxQcT0ztMsvLpCmLDJZv+SE4bju2cLRMSjG6jAlMvSqVGGTjvP?=
 =?us-ascii?Q?VA+xy8puLaPeFtIQfO4smKaR2MFid6SqggY7VJYQBplE6M/Iam7RpqIY7tN3?=
 =?us-ascii?Q?2x+AcDvhcDrgEHHVlFLpDeyFNaTtg2P3IaZCyKZxEQvLOqSbup6uI6oZLQQU?=
 =?us-ascii?Q?E/Yc0aZa0rRDFG5ekZnvFkpEiIT2IfkqkP/jwj0cRolsL1M8kFvedVvueUVq?=
 =?us-ascii?Q?Sp3nvyKZxazknXxlsYqqc+6iO3tLQ7828nZhPgeD6fCtUfG2o5n9InmcK4NG?=
 =?us-ascii?Q?dlxglajqrR+x0jQJIM9L7AISDYmpZRZ9Cf5tU5Z+Hu6eSAVprvmRaT7Zk1XW?=
 =?us-ascii?Q?1SZi8It3EU8RpKP2gsrqtRnSfXRDdV/FEdxKJbuSZRD0dCAENOlundJ0Pekf?=
 =?us-ascii?Q?op2uZm1rBMI8BGduGtaS/ljBLikjmOMYapV5xuAZUEEmU1smH8UXcBW7xE71?=
 =?us-ascii?Q?FtkidEt2kSDUlIoQf/KCxKwdJqqAICWsQsY3vmdHnua4eHb7AKNsw8eOuo4L?=
 =?us-ascii?Q?wROjFj3zM5qA8jrjoRs8aqRqwu5bVv0zvjsIQLfeA0k8xg3F+PdiItECP6X2?=
 =?us-ascii?Q?GUUpCPh4bth+zrmTEYq8fk3rlPBvtth4XufqhdDjTQ9rAZhxqyhYF3IE017w?=
 =?us-ascii?Q?FQWWwQ8R5gGzXf+MykC11h+iDTgqi9RuyI5VK+RQoAmXcPx55oRn5h5xsKMP?=
 =?us-ascii?Q?KRoaKrD3i1CHjV4+hkPnqjMKqnyK+KDDi8eM6NDx1hgh1XDQZ4u1fd8oP4Oz?=
 =?us-ascii?Q?6HxiffdYD1KOWv2CCsdRi+vJo9MW+hyqiPGc5JBTb9UTry7nIcUnfGe7TPIj?=
 =?us-ascii?Q?ivPKy5WSMGu9wzjv1kyGtprOaiJnQI1Q73nHo85Nt4Nef4nu4nf6JMSaW2nZ?=
 =?us-ascii?Q?ZsjKL8X/f5s9K+FhCtoCZvshEcF6tJeeqLKkdii+6nnnuWdOw5/rhthiP+A8?=
 =?us-ascii?Q?56pVdHGmXQq38Rpfgn3GWCYkP23OMEoG/5KI1f8+iGLje/xhF83Yh5AbJLMh?=
 =?us-ascii?Q?/R2mK8g/hxYrc8JAzo0GT40RvqqiK0g=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 404a3c9d-97d3-4a5c-65d8-08da163fb714
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 13:33:33.9008
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7h3/sAsphzaZNChgnnU83zTqFAQotFgoC7UbuxxHv/Mkq+VdIAJesOkE/KArPcRkHafJI9TN7bQBR18+nvotf7TtL5d/x0zA5Mig1DAHXzE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3968
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-04_05:2022-03-30,2022-04-04 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 mlxlogscore=676 phishscore=0 spamscore=0 adultscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204040077
X-Proofpoint-ORIG-GUID: AccQxUZLVh25-2w8BVO00dctxtTFVUyB
X-Proofpoint-GUID: AccQxUZLVh25-2w8BVO00dctxtTFVUyB
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Apr 03, 2022 at 02:18:04PM +0200, Michael Straube wrote:
> On 4/3/22 14:10, Fabio M. De Francesco wrote:
> > For a list of all the paths to a given function you may use Smatch:
> > 
> > ./smatch/smatch_data/db/smdb.py ips_leave
> > 
> > or
> > 
> > ./smatch/smatch_data/db/smdb.py call_tree ips_leave
> > 
> > But perhaps you already know how to do it.
> 
> Yes, but thank you anyway. :)
> 

My email (gmail account) has been so weird recently.  I don't know why
I'm not getting Fabio's emails...  Presumably they will show up in a few
days.

The other command to use is:

$ ./smatch/smatch_data/db/smdb.py preempt ips_leave
rtw_set_802_11_disassociate() <- disables preempt
-> _rtw_pwr_wakeup()
   -> LeaveAllPowerSaveMode()
      -> ips_leave()

I save that to a file, open it with with vim and run a vim function
`hall` (for highlight all) from my .vimrc file.

" Use :hall to highlight all the words in a file (for debugging sleeping bugs)
function HLall()
  let a=[]
  %s/\w\+/\=add(a, submatch(0))/gn
  let @/ = join(a, "\\|")
endfunction
cnoreabbrev hall call HLall() <CR>:set hls<CR>

That highlights all the functions is the call tree, then I use cscope to
jump to rtw_set_802_11_disassociate and follow the highlighted functions
to ips_leave().

regards,
dan carpenter