Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753682AbXEAOQZ (ORCPT ); Tue, 1 May 2007 10:16:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753976AbXEAOQZ (ORCPT ); Tue, 1 May 2007 10:16:25 -0400 Received: from canuck.infradead.org ([209.217.80.40]:52640 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682AbXEAOQX (ORCPT ); Tue, 1 May 2007 10:16:23 -0400 Subject: Re: condingstyle, was Re: utrace comments From: David Woodhouse To: Geert Uytterhoeven Cc: Satyam Sharma , Andrew Morton , Christoph Hellwig , Roland McGrath , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org In-Reply-To: References: <20061127165138.GA2991@lst.de> <20070430040213.BF9901801A4@magilla.sf.frob.com> <20070430091121.GC31397@infradead.org> <20070430100917.439ebfc8.akpm@linux-foundation.org> Content-Type: text/plain Date: Tue, 01 May 2007 15:16:13 +0100 Message-Id: <1178028973.2875.78.camel@pmac.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 (2.10.1-4.fc7.dwmw2.2) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 33 On Tue, 2007-05-01 at 11:00 +0200, Geert Uytterhoeven wrote: > > if (veryverylengthycondition1 && > smallcond2 && > (conditionnumber3a || > condition3b)) { > ... > } It's horrid. I'd much rather see if (veryverylengthycondition1 && smallcond2 && (conditionnumber3a || condition3b)) { ... } Even if that does take it over 80 columns, the 'failure' mode will be that it gets wrapped round to the beginning of the screen or truncated at 80 columns -- and for the _majority_ of the time, it doesn't matter. Unless you're paying particular attention to the logic and debugging the statement, a 'high-level' view of what's going on is perfectly sufficient; you don't actually read every character anyway. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/