Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3529607pxb; Mon, 4 Apr 2022 20:04:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeDKtV5I0PtxU1b9JEVZlUyZUNtpVAB7Qc25xO7g+OGAIUyGFicW4EljcE0r73zHpKpN1b X-Received: by 2002:a17:902:ce87:b0:156:5c6e:b6e4 with SMTP id f7-20020a170902ce8700b001565c6eb6e4mr1236094plg.12.1649127888720; Mon, 04 Apr 2022 20:04:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649127888; cv=none; d=google.com; s=arc-20160816; b=ouQbRNDqjvyb+/X4XYnxSASPI9va1W/OavFZGqGsLFpHdJQPgMb3PwTT1LvZ4w4TwD dHRAupdNACXiS1vhcI0jSVbZxAp/gIr3uACvDeduqAudDDgS1D3HjossPcpcRa6SYGoO 2eorGhC3UKEddIANA0+pK78bZdub1Q1xtpHAWuSt43y9RNYas7ktyRXsVNgvOBozOo8T hpGmAOdJAmgO+nD4a38B5wrM8V+1k0QCj+W/SE3FWn9dlHpohrQtIggv3CQ+woQKWns+ mUYQOcjBU228bAy9qaOogajs3gAguQtfKUFNEtTkou1F70KreF3W+DXkhibTx4zY6nOZ vo4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VP9DZjk6ZczTz6Snvbre433wZ+Z/QMRd5nCRz0IXdXs=; b=yPMWfhJanEnlX8yBokIdy2YC/YsYjpdv2uGDfm6Ze2wumOLyvQgInYHzsO3By3FO8v 8L/wOdlZQ3JH10Bl3hKpmAIV/lnNiBfODWdJwkcE+1mNBtTnHlKfFK6RpDGdMYLtddJo 3mewg6doBJ15lVqssfALbyOZCX6Bu8tvP4FGWExPkYwsupU67UpHgGQ3K3OS+FTvuyKv +QgFprfAibtjlmHpnhLIRDTQUVSYzlOc7UyKRWXPEGyJeTY0fAETNyP0CsTeJIICpl0l eiqjGDZPuHn4a9EoZqYSxgQvRWyQD34tyR9+tLYZ2hIYItycbGxUlStWZ3V7whixU4qV Aygg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Fa13p9Gd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id r2-20020a639b02000000b003816043f033si11323127pgd.552.2022.04.04.20.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 20:04:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Fa13p9Gd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 17AAB33A8CB; Mon, 4 Apr 2022 18:29:06 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237179AbiDBBgp (ORCPT + 99 others); Fri, 1 Apr 2022 21:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbiDBBgn (ORCPT ); Fri, 1 Apr 2022 21:36:43 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79FDFC62 for ; Fri, 1 Apr 2022 18:34:53 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id b17so3318254qvf.12 for ; Fri, 01 Apr 2022 18:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VP9DZjk6ZczTz6Snvbre433wZ+Z/QMRd5nCRz0IXdXs=; b=Fa13p9GdwFU7opfjdPo5hVT2m/Oi0qEPLOLVA8J2h8VJD0ZYyOTrzv9oV4wWWUJvZi J7SVkUanyaefso8uRwdkUSi3rhSn5iXHhBK8YzeGv1ChVCCdHGuPDNbKBey6w4j6VR/z jG8YzY8YgCdJ4vE0HqNvrJB4o1kR/jJGsBztyyVjnNSFplV6FdbIbzlFkpglB920KhbZ 2ey6o//f/Aj6q5bdYqa35n0IGWgCWJ61PgUijFclfMLez1yZkbHSgiiG2kpNYu28VSSH iBIEerppBSbHq0BZ7dtgTv/gBR4j+T/jCgX3eOQlbvCRlqVKmlNjgSi+ItC4kh/z4uTT /EXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VP9DZjk6ZczTz6Snvbre433wZ+Z/QMRd5nCRz0IXdXs=; b=Kw4mVJgeuV1PYCE4/EzB6BRqHvsFfyr3HBLeRjRwGk56au8q9lhn/PJwQcsNEy/Txe nOrbXFcTC+gIB93YUbh0adgs3lvem4gDqGW+Y7XJh/dqE5fQHGjX0tQTJzBVFhoTa1Bl 0GBj+/NZ+iIGigvGx1XnIPWby6QNBYTWtEucFsYzlnmcFjx05p7v9W1eETocuHZmsJIz WhE2CXQE8nv80pclhO3zE63fYWrdQ2Ik2jUGcTyf7miDzZZnf2Bkco+qc05MHxC6UagM TczgXNhSor1lRnA7+DtU6Ef242o6MWYtEqXYieQVVmhrNcbZ4RrmgKiEgANBILq4g/gs dq6Q== X-Gm-Message-State: AOAM531MaGaK29rr+RNSyxQQzA1C9jiD2JWCkegkBTs3LWFu24xgdT9P pY0lUJHC574ryuuO/YXa+1M= X-Received: by 2002:a05:6214:cad:b0:441:4269:37ff with SMTP id s13-20020a0562140cad00b00441426937ffmr42562979qvs.128.1648863292699; Fri, 01 Apr 2022 18:34:52 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id v12-20020a05622a130c00b002e1b3ccd9adsm2922207qtk.79.2022.04.01.18.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 18:34:52 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: lv.ruyi@zte.com.cn To: mpe@ellerman.id.au Cc: benh@kernel.crashing.org, paulus@samba.org, maz@kernel.org, nick.child@ibm.com, lv.ruyi@zte.com.cn, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Zeal Robot Subject: [PATCH] powerpc/sysdev: fix refcount leak in icp_opal_init() Date: Sat, 2 Apr 2022 01:34:19 +0000 Message-Id: <20220402013419.2410298-1-lv.ruyi@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lv Ruyi The of_find_compatible_node() function returns a node pointer with refcount incremented, use of_node_put() on it when done. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- arch/powerpc/sysdev/xics/icp-opal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/xics/icp-opal.c b/arch/powerpc/sysdev/xics/icp-opal.c index bda4c32582d9..4dae624b9f2f 100644 --- a/arch/powerpc/sysdev/xics/icp-opal.c +++ b/arch/powerpc/sysdev/xics/icp-opal.c @@ -196,6 +196,7 @@ int __init icp_opal_init(void) printk("XICS: Using OPAL ICP fallbacks\n"); + of_node_put(np); return 0; } -- 2.25.1