Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220404072900.35jca2o26gopi2qb@houat>
References: <20220403022818.39572-1-sboyd@kernel.org> <20220404072900.35jca2o26gopi2qb@houat>
Subject: Re: [PATCH] Revert "clk: Drop the rate range on clk_put()"
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Tony Lindgren <tony@atomide.com>,
        Alexander Stein <alexander.stein@ew.tq-group.com>,
        Naresh Kamboju <naresh.kamboju@linaro.org>
To:     Maxime Ripard <maxime@cerno.tech>
Date:   Mon, 04 Apr 2022 13:05:28 -0700
User-Agent: alot/0.10
Message-Id: <20220404200530.0F406C340F3@smtp.kernel.org>
Precedence: bulk

Quoting Maxime Ripard (2022-04-04 00:29:00)
> On Sat, Apr 02, 2022 at 07:28:18PM -0700, Stephen Boyd wrote:
> > This reverts commit 7dabfa2bc4803eed83d6f22bd6f045495f40636b. There are
> > multiple reports that this breaks boot on various systems. The common
> > theme is that orphan clks are having rates set on them when that isn't
> > expected. Let's revert it out for now so that -rc1 boots.
> >=20
> > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Reported-by: Tony Lindgren <tony@atomide.com>
> > Reported-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> > Link: https://lore.kernel.org/r/366a0232-bb4a-c357-6aa8-636e398e05eb@sa=
msung.com
> > Cc: Maxime Ripard <maxime@cerno.tech>
> > Signed-off-by: Stephen Boyd <sboyd@kernel.org>
>=20
> I really like the attention it's getting now that it's broken, we can
> fix a lot of things :)

Sure! Except that can quickly turn into other attention.

>=20
> It doesn't seem to be restricted to orphan clocks though :/

Oof ok. I was busy last week so couldn't pay much attention.

>=20
> But obviously,
> Acked-by: Maxime Ripard <maxime@cerno.tech>

Thanks. Looks like it just made -rc1 so we can work through the fix at a
more leisurely pace now.