Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220331190257.101781-1-wander@redhat.com> <20220331190257.101781-2-wander@redhat.com>
 <4767809d-5818-ad40-a0e7-b3af40aa071e@kernel.org>
In-Reply-To: <4767809d-5818-ad40-a0e7-b3af40aa071e@kernel.org>
From:   Wander Costa <wcosta@redhat.com>
Date:   Fri, 1 Apr 2022 11:26:15 -0300
Message-ID: <CAAq0SUmZ1u0TLTOq9fcn68oTZ6iHmpALbjhhy3zh6T=Kz1afxg@mail.gmail.com>
Subject: Re: [PATCH v5 1/1] serial/8250: Use fifo in 8250 console driver
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     Wander Lairson Costa <wander@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hovold <johan@kernel.org>,
        "Maciej W. Rozycki" <macro@orcam.me.uk>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lukas Wunner <lukas@wunner.de>,
        =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        =?UTF-8?Q?Andr=C3=A9_Goddard_Rosa?= <andre.goddard@gmail.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        David Laight <David.Laight@aculab.com>,
        Jon Hunter <jonathanh@nvidia.com>, phil@raspberrypi.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 1, 2022 at 1:36 AM Jiri Slaby <jirislaby@kernel.org> wrote:
>

>
> ">" missing here. Doesn't a compiler warn about subtracting different types?
>

My local machine doesn't generate a warning; it causes a build error.
So my question was, how was I able to build and test yesterday in a
remote server? It turns out I built it with make -j40, so I missed the
error message because of the parallel build, and I didn't pay
attention that the output didn't display the modules_install typical
output. Usually, I do my tests in an RHEL9 machine, which ships with
kernel 5.14, but this time I tested in a Fedora machine, which ships
kernel 5.16. And for a moment, I forgot that. So when I booted with
kernel 5.16, I believed I was running my custom kernel. Luckily, v5
mainly was a squash of v4 with this port->state check added. Anyway,
sorry about the typo. v6 is on the way.