Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sun, 3 Apr 2022 16:10:19 +0300
From:   Ido Schimmel <idosch@idosch.org>
To:     Tom Rix <trix@redhat.com>
Cc:     idosch@nvidia.com, petrm@nvidia.com, davem@davemloft.net,
        kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum_router: simplify list unwinding
Message-ID: <Ykmcu5y4Tx8pqhtQ@shredder>
References: <20220402121516.2750284-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220402121516.2750284-1-trix@redhat.com>
Precedence: bulk

On Sat, Apr 02, 2022 at 08:15:16AM -0400, Tom Rix wrote:
> The setting of i here
> err_nexthop6_group_get:
> 	i = nrt6;
> Is redundant, i is already nrt6.  So remove
> this statement.
> 
> The for loop for the unwinding
> err_rt6_create:
> 	for (i--; i >= 0; i--) {
> Is equivelent to
> 	for (; i > 0; i--) {
> 
> Two consecutive labels can be reduced to one.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

For net-next:

Reviewed-by: Ido Schimmel <idosch@nvidia.com>