Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753081AbXEAOqy (ORCPT ); Tue, 1 May 2007 10:46:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752319AbXEAOqy (ORCPT ); Tue, 1 May 2007 10:46:54 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:34341 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753026AbXEAOqw (ORCPT ); Tue, 1 May 2007 10:46:52 -0400 Date: Tue, 1 May 2007 16:46:51 +0200 From: Adrian Bunk To: Andrew Morton Cc: Willy Tarreau , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pcmcia@lists.infradead.org Subject: Re: pcmcia ioctl removal Message-ID: <20070501144650.GB3531@stusta.de> References: <20070430162007.ad46e153.akpm@linux-foundation.org> <20070501084623.GB14364@infradead.org> <20070501085710.GA13488@1wt.eu> <20070501020820.05f0c037.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20070501020820.05f0c037.akpm@linux-foundation.org> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3569 Lines: 97 On Tue, May 01, 2007 at 02:08:20AM -0700, Andrew Morton wrote: > On Tue, 1 May 2007 10:57:10 +0200 Willy Tarreau wrote: > > > Hi Christoph, > > > > On Tue, May 01, 2007 at 09:46:23AM +0100, Christoph Hellwig wrote: > > > > pcmcia-delete-obsolete-pcmcia_ioctl-feature.patch > > > > > > ... > > > > > > > Dominik is busy. Will probably re-review and send these direct to Linus. > > > > > > The patch above is the removal of cardmgr support. While I'd love to > > > see this cruft gone it definitively needs maintainer judgement on whether > > > they time has come that no one relies on cardmgr anymore. > > > > Well, I've not followed evolutions in this area for a long time. Here's > > what I get on my notebook : > > > > willy@wtap:~$ uname -r > > 2.6.20-wt3-wtap > > willy@wtap:~$ ps auxw|grep card > > root 1216 0.0 0.0 0 0 ? S< Apr28 0:00 [pccardd] > > root 1221 0.0 0.0 0 0 ? S< Apr28 0:00 [pccardd] > > root 1244 0.0 0.0 0 0 ? S< Apr28 0:00 [pccardd] > > root 1251 0.0 0.0 0 0 ? Ss Apr28 0:00 /sbin/cardmgr > > > > Yes, that seems premature. feature-removal.txt is pretty useless for > getting poeple off old tools. If we're ever to make this migration we'll > need loud and scary printks coming out of the kernel. Probably it'll take > another year or two to get there *once* we've done that. You already said the same two years ago, and you forwarded a patch implementing exactly this nearly two years ago: commit c352ec8ab87b065cd2edda171811f49ac7d0d5cd Author: Dominik Brodowski Date: Tue Sep 13 01:25:03 2005 -0700 [PATCH] pcmcia: warn on IOCTL usage More visible user information of scheduled feature removal. Signed-off-by: Dominik Brodowski Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds diff --git a/drivers/pcmcia/pcmcia_ioctl.c b/drivers/pcmcia/pcmcia_ioctl.c index 39ba640..80969f7 100644 --- a/drivers/pcmcia/pcmcia_ioctl.c +++ b/drivers/pcmcia/pcmcia_ioctl.c @@ -376,6 +376,7 @@ static int ds_open(struct inode *inode, struct file *file) socket_t i = iminor(inode); struct pcmcia_socket *s; user_info_t *user; + static int warning_printed = 0; ds_dbg(0, "ds_open(socket %d)\n", i); @@ -407,6 +408,17 @@ static int ds_open(struct inode *inode, struct file *file) s->user = user; file->private_data = user; + if (!warning_printed) { + printk(KERN_INFO "pcmcia: Detected deprecated PCMCIA ioctl " + "usage.\n"); + printk(KERN_INFO "pcmcia: This interface will soon be removed from " + "the kernel; please expect breakage unless you upgrade " + "to new tools.\n"); + printk(KERN_INFO "pcmcia: see http://www.kernel.org/pub/linux/" + "utils/kernel/pcmcia/pcmcia.html for details.\n"); + warning_printed = 1; + } + if (s->pcmcia_state.present) queue_event(user, CS_EVENT_CARD_INSERTION); return 0; cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/