Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3538090pxb; Mon, 4 Apr 2022 20:25:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYwXGVk23N1kNfaJPDkT/EJICTp1jNtYwzSJ73JyAQPhJ4VreYX4ihkwVFWecZiRjwGSmh X-Received: by 2002:a65:418b:0:b0:382:250b:4dda with SMTP id a11-20020a65418b000000b00382250b4ddamr1175774pgq.428.1649129115193; Mon, 04 Apr 2022 20:25:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649129115; cv=none; d=google.com; s=arc-20160816; b=jBemb5N7iQMNNCFkdUSrC7KmpbdgKK3bZ3+D/zhLAZ/qdXedKFTXP9wE8Lu3yzu/VY bHJpN38Y/0hKKz3m5uFnh5v9Cpns6F7mUdnMdzUreoJnHB1faJeTldSlRpcA67hf1xRh ivK+yjxl8SjB8IQw4zjLZwPVXlfZxWVfJgZTCUBDLnnffrI+y2ip249txkvdbLBxSA3e MnF8nG8p71cgLTkDal7Hj79FKlLfMxBhIE0G1W2KOBPmTAlu8EnaJhl+0RV0PCqbTEzN 32iM1vL7kG6B9o/D7hQQ9+s7cReon9wayptYP7TL3uEiWWv9oDsBlLuamtcbm8pB8ZhC zsXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :date:message-id:dkim-signature; bh=9cCBVkUbekjSw+j5qn5A9qX8bKkHIGEnNByJ0l5fEyQ=; b=dNOdNOTJuqcX6YGegQrCP/hDeAbT1REq3sPonXKh5M/srSn4gcBzOvzD2K3D881BXN Wd0auo/tQ7KaVF9snKo3TixzosD/+AOpb+73Y979bA1f4G0IK/RfiBAeUzxWzmn4rHC+ AUGpeyoD5hLahvZL5v4pucKEPvPAPpAmH3pxBCL0oaq6LfkDwTjFGhJUMKXkDnYRvxIE xma+xkyaoUYei2h6qkYBoGB35A8gphHKBJ3Fl/pT2B/r9mWoXiCTJ9aYYV+wdrfoIVRu nydCzTRxkGgO29jWkkql0atRrB3DpiMymJF2EsYcOXwWzLSml2IBnfRS8sPiZQI39kTb qF8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MOMuGDXM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x2-20020a170902820200b00153b2d16615si10719989pln.541.2022.04.04.20.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 20:25:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MOMuGDXM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 45768B3DCD; Mon, 4 Apr 2022 18:24:53 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234471AbiDCERC (ORCPT + 99 others); Sun, 3 Apr 2022 00:17:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbiDCERB (ORCPT ); Sun, 3 Apr 2022 00:17:01 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02E2C2FFC9; Sat, 2 Apr 2022 21:15:08 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id jo24so5074078qvb.5; Sat, 02 Apr 2022 21:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:to:cc:references:subject :content-language:from:in-reply-to:content-transfer-encoding; bh=9cCBVkUbekjSw+j5qn5A9qX8bKkHIGEnNByJ0l5fEyQ=; b=MOMuGDXMgpDSbmmdQ49YMEAHLF2pgCcQxxaHF0L04omNxPsz7VsjfHEmnEj8wyA+JO AC9vuPAQG2Y1U3BDYGWxk84vvI1zgl9JAb9IjUQzqHHghDKVtYuMFEQcJBDUnEJOIkwH Qu7u0BmSGHBSXH0TQf1Piq1hz0qkVSEWwGWVk81iEo27XUSHO43Os6lwZNELHoy85ZNA RgYSbyCbnA/g4M9aP9WCCU8QQnodiLwQYyETLF8KQJ9eyXw87aPzVq/tCNmJCmVg+QIc 1s8eRLu65HNGVrFEj59KZXQ3dpiVVdiWLUg1k6z1ONUuqMaQu2IopaxOJHEHxthaKw5x 71IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:to:cc :references:subject:content-language:from:in-reply-to :content-transfer-encoding; bh=9cCBVkUbekjSw+j5qn5A9qX8bKkHIGEnNByJ0l5fEyQ=; b=ydGUg9JDD2Ai7JS7+LuoYQI6etx0XtRBSSgCsYnF8gooWDnqe2p3mddHIrqjhNC1Ng HhJWAA/lTcaGdVfOuA9IwVRY2vsq+eMFhXMYc27J085UiK3ge0S5G7UTr6QdCoqdyC2f DmWjsgGx+3WWldyKJ2N6kTlld3PB4KJBCT/yLrFhJne31Ep5H9RFWE69sO5HKzbgNIl0 IUeahtp0lkYFIHuE/4nAcISkIVEAhZd2KJ/bmauH/NU+0jDW3Euhf0V4XrWfyfM+djIe 4AlIGRUSszMT7XWEpmWbdUL8dcoY2NVvXQr0+QOhjxkGi/b03tIKA3bKX+3PxREAHNT3 0zBA== X-Gm-Message-State: AOAM530wF+o5wYOaCWL7uqqA/wMq9ZJ3uU4ohgFxxpDdF2GHV53ckjIk klXxhZaMv5+Z+0f5705VvSE= X-Received: by 2002:a0c:f18a:0:b0:443:ce3d:542f with SMTP id m10-20020a0cf18a000000b00443ce3d542fmr2278171qvl.106.1648959307066; Sat, 02 Apr 2022 21:15:07 -0700 (PDT) Received: from [192.168.200.197] ([72.49.221.197]) by smtp.gmail.com with ESMTPSA id 188-20020a3709c5000000b0067b147584c2sm3930667qkj.102.2022.04.02.21.15.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Apr 2022 21:15:06 -0700 (PDT) Message-ID: Date: Sun, 3 Apr 2022 00:15:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 To: yaliang.wang@windriver.com Cc: akpm@linux-foundation.org, anshuman.khandual@arm.com, geert@linux-m68k.org, huangpei@loongson.cn, kumba@gentoo.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, penberg@kernel.org, rppt@kernel.org, tsbogend@alpha.franken.de References: <20220310113116.2068859-1-yaliang.wang@windriver.com> Subject: Re: [PATCH] MIPS: pgalloc: fix memory leak caused by pgd_free() Content-Language: en-US From: Donald Hoskins In-Reply-To: <20220310113116.2068859-1-yaliang.wang@windriver.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi there, This fix should backported.  Effectively, all mips64-based Cavium Octeon processors have been broken since the original commit; this has been a persistent and surreptitious issue for the OpenWrt community since nearly a year ago (referencing https://forum.openwrt.org/t/upstream-kernel-memleak-5-10-octeon-ethernet-ko/111827/), and nearly ended with OpenWrt marking the target as entirely unsupported and moving on. We understand that there are ultimately few users of mips64, but it's really important that our memory management work. While OpenWrt can backport until upstream inclusion, I am sure there are other users and software platforms unaware of this fix (and unable to take advantage of it), thus making those platforms on this arch completely unusable.