Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <513a5993-2cc5-54fa-2d6c-f4162d76ab0e@amd.com>
Date:   Mon, 4 Apr 2022 11:22:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] drm/amd/display: cleanup extern usage in function
 definition
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch, wenjing.liu@amd.com, waynelin@amd.com,
        Anson.Jacob@amd.com, Yu-ting.Shen@amd.com, keescook@chromium.org,
        nicholas.kazlauskas@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220403142137.2234322-1-trix@redhat.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20220403142137.2234322-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlV5VlM4dG15OVkzRDIrcHJhZ1I4cEpJL0lRakV2Y2RKYmI4NzVIbG9kYzlW?=
 =?utf-8?B?cjNVZUxmTWM4MHBUeUoxN2dGWGVVYXNsVFFtYnRSOGVvNkc5UXNoUlNDcTht?=
 =?utf-8?B?aDFvandzV3hhVi9scnY2bEtFVWxYNEdZV3hEcmVjbE9WazR2bC9NY2JtTDhN?=
 =?utf-8?B?RnNkQkJ4WlZFS3QvOVNjbmRmcEhXYUlzbnlCNDlpWjVBQmJNVGRLNlhaUmUv?=
 =?utf-8?B?MjByemZjZys5TmlaZFI2Y0s2KzdTU0JMUUFvSkR1SGFVSXZONlpBYVlXeDdq?=
 =?utf-8?B?cHpGOHVkMStwWklORDFzTmZBTkt4eUExK2tPSWpicWJwSmZmbThhQy9Ia0hO?=
 =?utf-8?B?NU1PQ01CcDVuMXhuZVRDMThVUGJBZXVDd0dERnE5MU1EZDFLdEhwVEJMUUtQ?=
 =?utf-8?B?eXp5Y016WTNEeWVxa0NEY2grbkJWczEyS0s0RkVvdnphNEt1UVh2amFERi85?=
 =?utf-8?B?WnowUjd2UUR2dVpHUkI4UFFuUDg4aHRqd2Q4L2pjTDFyOXdBTzUvYlB0Ym5Y?=
 =?utf-8?B?QVEyVG4zZ2N2b0VMdnQ2UzVTUGZBMjl4SFpKZVBSK0g2Rkx0S2I0STJsMEp3?=
 =?utf-8?B?aUE4NWRSeWpFVEpkTkFwaS9QdExrUkhwMWtSakE2RDZML3ZJbmtkTmNzdVFv?=
 =?utf-8?B?UVlvTkovNHl4ZlRVemZFWDZURzJrY3RYVFpWMEQ5b1hIYk1yS2lvZm85MVR3?=
 =?utf-8?B?Q0tzeDZCc0tDd3lxbElXT2l4VFRFTSt6TWh0R1hrZThVYjVKZ2lwWE5Jc21q?=
 =?utf-8?B?cStaeiszOGNKS0Q4TnRRTGVscmQ0Snh4U1lzamw1OTR6TVY1MzBMYXdSK1Ev?=
 =?utf-8?B?ckphZ2Y0NmNqYVpIZDBzbVMwdE16N0M3YVVaOE1JQXYwSHRpeWxadG5iS0ND?=
 =?utf-8?B?ZEtxUllrM0lscGpCL3poZlplbTM3Z3hha0JlS2pMSXVpM2hnVUJnNDcvMklI?=
 =?utf-8?B?QkovZEpyVDdqQW9pNDc1SFNXTDMyU2tpMHlnc3VFbkNCZGE0YVNDM2dHVnF3?=
 =?utf-8?B?M052dUx2OGJsazdOajYrMWxZVGhDRHRkZHRGSDEwQWZOYUdDc2hncW00U3lj?=
 =?utf-8?B?Q3hLRXdMNEVIaEtucEdiT0gxc21pRk1JSGZXY2RLbk5ubEo4TmNLM3YxSHdo?=
 =?utf-8?B?MFB5RlNjdWs1QWxPU2E1UENaUHExd0ZlVGZwMWhZVEFuT1ZObUVjRlNtbzJs?=
 =?utf-8?B?dmRuaWlEdTlKbmF4VW9xWG1POE41VWRDaVliNmVLM20vVTJ2OFVSbzZUMzE3?=
 =?utf-8?B?YzA1VFpCVXJRMG5vWW9objVDcWZ3KzlENGgrN2xXZkg1Sm1mVFpPZWl2cDV0?=
 =?utf-8?B?cjhkY25kYjl3VDJCcHR6NnJ4VzNnQjJEVU9xNXdyek9qZHh3Ny9VVWZoRzRa?=
 =?utf-8?B?ZCsrVTFCaHEzcW1XTjVKMGU1QllCWmh2OHBPYUFicFZjWE9teW54RmZwUGhU?=
 =?utf-8?B?YjdNWXRIeVd5UENUOWF4a2F0aTU5dUFUUDRHbFI1OGlYYjQ2UXNCY1FueUEy?=
 =?utf-8?B?aDY4SjNpMUZQTkRqckpHQWYxWGhXUmx4VWp4VHRVZisrOUl5QzNveHZCWVVF?=
 =?utf-8?B?aHl1YTF2aWpoZW96ZURqalVLR1lNWHhEbTBwVDl6NUx6VnpPM29pbVV4UElJ?=
 =?utf-8?B?ZXNNZEdTYUgyTXdWL3RUeDZGRHN5Qmp5RHBKZXd4eTZsUUdIamJ5TUlUb2JR?=
 =?utf-8?B?ZWErUEZIQUwzVjZ2OHc1K0VDT3hWZHJBVERiUzVRc3VtKzFqUFE4dlRFQUlp?=
 =?utf-8?B?NnUyckMvUmJha2kram5tZ2RTY0F5OUhyS3QxQm9lSGE0eHhxTi9UVlpZSER5?=
 =?utf-8?B?V2lRay92UXEzc0NWY1MxSWorOGlvZUFyVXlsSDNJeGsrOHlqY3M5RTdpYllo?=
 =?utf-8?B?RjJIcCtreHZSMUhmRFFQaW1UMDI5QkNRVncxSDBpYWZCYXMvbW9nWkJGb2ZE?=
 =?utf-8?B?aXE5N3FFYjJoYUwxMlFpREdZY1VacWZ4enVOUE13MHdBeHk3QUExV2tRbjNJ?=
 =?utf-8?B?NVlhNHZmeFQ5L2tqT3Rhcy9MWGdESmRTL2p1VUtIZS96S1k4U1k3MlNUZUls?=
 =?utf-8?B?bFVWUU1zbkY2WXR6ODdqcGdmN1VSNzE5bG9iZTFDQndVSUxRRDVLTTB0VHJ6?=
 =?utf-8?B?YTZaZEJHVmVhM0VQMU0xUUViNWVQd3RHWWxCc1p5ZTByaUZnMGdzamU2d2ZL?=
 =?utf-8?B?cWh2VG8zeHlvLzBqZVZDeDlGaTIyczNrODlGS2JlS1luMzV3ZEJGMVp4WUg3?=
 =?utf-8?B?TmZCSE5uWFV0aGU0MnkvbmExTDkzUjBuOXBDZ3lqVE81VEtxVW43bEE2Mkcv?=
 =?utf-8?B?STlacHV4Mm5JNUkwaDlDUFN6MjhOOHFGNFpUZVlITXoxQjBscUxKUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3002dfc9-4fc2-419d-0473-08da164ef87f
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 15:22:46.0867
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lqi8BQ9jpsZiwJCJByxt0NKYHAlFELZzGMqsNFmwtYLdioPyB1QL/nr6g27SndD+sKNU+HxuQxP8ISnE7s74EA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB4664
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-04-03 10:21, Tom Rix wrote:
> Smatch reports this issue
> hdcp1_execution.c:500:29: warning: function
>   'mod_hdcp_hdcp1_dp_execution' with external linkage
>   has definition
> 

Which branch are you using?

I don't see the 'extern' on
https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c

Harry


> The storage-class-specifier extern is not needed in a
> definition, so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> index 6ec918af3bff..1ddb4f5eac8e 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
>  	return status;
>  }
>  
> -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> -		struct mod_hdcp_event_context *event_ctx,
> -		struct mod_hdcp_transition_input_hdcp1 *input)
> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> +						 struct mod_hdcp_event_context *event_ctx,
> +						 struct mod_hdcp_transition_input_hdcp1 *input)
>  {
>  	enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
>