Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sun, 3 Apr 2022 21:54:13 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Stijn Tintel <stijn@linux-ipv6.be>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, pali@kernel.org, kabel@kernel.org,
        pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net,
        hkallweit1@gmail.com
Subject: Re: [PATCH] net: phy: marvell: add 88E1543 support
Message-ID: <Ykn7ZczbI3Zs+AOc@lunn.ch>
References: <20220403172936.3213998-1-stijn@linux-ipv6.be>
 <YknlRh7MLgLllb9q@shell.armlinux.org.uk>
 <fa04f389-df01-4838-7304-2fb43b919b98@linux-ipv6.be>
 <YknvDRbRznWZpstM@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YknvDRbRznWZpstM@shell.armlinux.org.uk>
Precedence: bulk

On Sun, Apr 03, 2022 at 08:01:33PM +0100, Russell King (Oracle) wrote:
> On Sun, Apr 03, 2022 at 09:30:06PM +0300, Stijn Tintel wrote:
> > On 3/04/2022 21:19, Russell King (Oracle) wrote:
> > > Hi,
> > >
> > > On Sun, Apr 03, 2022 at 08:29:36PM +0300, Stijn Tintel wrote:
> > >> Add support for the Marvell Alaska 88E1543 PHY used in the WatchGuard
> > >> Firebox M200 and M300.
> > > Looking at the IDs, this PHY should already be supported - reporting as
> > > an 88E1545. Why do you need this patch?
> > >
> > Thanks for pointing that out, you're right. Please disregard the patch.?
> > Would it be acceptable to change the name member to "Marvell
> > 88E1543/88E1545" to make this more obvious?
> 
> Unfortuantely not, the driver name is used in sysfs, and as I'm sure
> you're aware, "/" is a pathname element separator and thus can't be
> used.

The name is however reasonably free text. For example:

micrel.c:	.name		= "Micrel KSZ8021 or KSZ8031",

	Andrew