Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3539859pxb; Mon, 4 Apr 2022 20:29:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw445519WbDpbo6gfEuvse2KgDGceb4HvjpL48JtPV5rDLG7F28hwQ0/OQFFVzcPHKnF+7I X-Received: by 2002:a63:7d6:0:b0:399:5aec:2a73 with SMTP id 205-20020a6307d6000000b003995aec2a73mr1146103pgh.245.1649129383776; Mon, 04 Apr 2022 20:29:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649129383; cv=none; d=google.com; s=arc-20160816; b=lxPNxqTROPe03wCxfG6onThkwr1Sq19Mho3rqobKgvZdRd6lXZNtKEUyr6sCwQRUlL GsuRMsbXteNF4Ud3/L+Fzvj3DqSm8mMmpjKnD1oWzPI1QsADsz7z5UdnBAFimUBt2tcp jLMeBLjGVWxVS6bcPgrEubjaui2MzEVp3q1rrW1t+d70UFDMUibhqU4mG2NHpW/iPsg/ /kKFe8ROl/84pxmMc18/j+a+aMtcgaJkFq11u74a+ZNQI1AqfPnu3mJcHSQPVovQ9zT/ +uj9EmZYSTPKe5D7ewUeS61yRK3B40VqaB4Uyq5wL2p/aYa7pTg6/glsoZwPasqkUQye xL6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gqyV4vp9S0X60EY4aDAtM6FlvTYjN6u271pJT2WT0tE=; b=uU+FhB4PVcX8iu/wOQ4KvbbYpsg1JIER4gxGNCpHuQBwO9O0Eqety1jVXl3sokgGHo x17vE37LPZ79y+J/P6j+1Lj5Jgxenw+/c6R8N+iYq8OpFh9BqFn30BqU5taBC5esRAkS q7y3F1/jZTmSB3N3QfqMOBu5WDGlU2N3VhpzvcfRN0y2P0nKgwZaqkLOckEQJH/h45zV fbCsq3dhcKIDLHvc+PE/yijtfuKn99iNK7X5uDDuOz+Lq3GrBZK2W1SNcluaAxM1PqNF HYCTn+EppyIwCs/b8UrtbQqUbbfyFRcn6huvMbZcbDgkT0bOcoA6TTZJG4jLxRyTgTwA eUFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=jTaOPXWP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id c2-20020a170902d48200b00153b2d16453si12574935plg.91.2022.04.04.20.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 20:29:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=jTaOPXWP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D10E533A8E0; Mon, 4 Apr 2022 18:29:06 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358010AbiDCT4Q (ORCPT + 99 others); Sun, 3 Apr 2022 15:56:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239271AbiDCT4O (ORCPT ); Sun, 3 Apr 2022 15:56:14 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03088219A; Sun, 3 Apr 2022 12:54:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=gqyV4vp9S0X60EY4aDAtM6FlvTYjN6u271pJT2WT0tE=; b=jT aOPXWPBLUfVvmpCWD+usZb383FZwC25EspDeMrXjS8b1rMZvYyvXqS7t1pb+jrF/QnhTyqEuR+fzS ybSwbXtMasEruzH54CxpEu1NOCmDVVmRii7DbdOMz1mUm2/bvgOg+c32taDjQ5dW/1jZUrvVg/pd9 owEWK6K+GJXlElQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nb6If-00Dz4E-8z; Sun, 03 Apr 2022 21:54:13 +0200 Date: Sun, 3 Apr 2022 21:54:13 +0200 From: Andrew Lunn To: "Russell King (Oracle)" Cc: Stijn Tintel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pali@kernel.org, kabel@kernel.org, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, hkallweit1@gmail.com Subject: Re: [PATCH] net: phy: marvell: add 88E1543 support Message-ID: References: <20220403172936.3213998-1-stijn@linux-ipv6.be> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 03, 2022 at 08:01:33PM +0100, Russell King (Oracle) wrote: > On Sun, Apr 03, 2022 at 09:30:06PM +0300, Stijn Tintel wrote: > > On 3/04/2022 21:19, Russell King (Oracle) wrote: > > > Hi, > > > > > > On Sun, Apr 03, 2022 at 08:29:36PM +0300, Stijn Tintel wrote: > > >> Add support for the Marvell Alaska 88E1543 PHY used in the WatchGuard > > >> Firebox M200 and M300. > > > Looking at the IDs, this PHY should already be supported - reporting as > > > an 88E1545. Why do you need this patch? > > > > > Thanks for pointing that out, you're right. Please disregard the patch.? > > Would it be acceptable to change the name member to "Marvell > > 88E1543/88E1545" to make this more obvious? > > Unfortuantely not, the driver name is used in sysfs, and as I'm sure > you're aware, "/" is a pathname element separator and thus can't be > used. The name is however reasonably free text. For example: micrel.c: .name = "Micrel KSZ8021 or KSZ8031", Andrew