Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 4 Apr 2022 10:42:09 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niels Dossche <dossche.niels@gmail.com>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Subject: Re: [PATCH] IB/rdmavt: add lock to call to rvt_error_qp to prevent a
 race condition
Message-ID: <20220404134209.GA2905506@nvidia.com>
References: <20220228165330.41546-1-dossche.niels@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220228165330.41546-1-dossche.niels@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MhddzGb2bZiVdHMfqrQWZwysEW22+osW0oHUwzajawarQ4jAAS5p9ZSzXL9o?=
 =?us-ascii?Q?evB98tnSHKmcyb/SuGG0npHKvtHeD60S9ZCpbMxDanLbm0/g4gHVSBlD3v7n?=
 =?us-ascii?Q?XNN9nG6leYxv3GbGSslVzfqrdCUovr7+gPi6JHgzbGbvyNYXvTBdFdFErHBb?=
 =?us-ascii?Q?7bhzj3C6+jFJncGTzXxT/iQOL+3hVFO4forfHQpsAX+iTKuVgdzVNVW1QCLy?=
 =?us-ascii?Q?pgsSN0yAw4MtKin0Jy2xm5ZHy2O4RdaDOueqd7l5luZDKF5rk0bwCWi+x7Mi?=
 =?us-ascii?Q?H9EkU5rNd/8t/cRStVf99E563PSrAYr9JEIv0weUYtSPbfrqSqB4VREWEU6F?=
 =?us-ascii?Q?fzr+R0WrzKcALDB8KBayfZFUHG0wx0JVUs1VtqQph1krXilc6FKe5oF1vpBd?=
 =?us-ascii?Q?DnV7QuI+xRB0Pr9dXHg+qPZK7AKJMAmBrY+HE+lYxm+68wCsRGArclBJL8Pq?=
 =?us-ascii?Q?cpoZC4HlWdysrrhnZ+WzKmGPLb2QwnCDsyAzKmvlTQ58Rs11tv415Ul1Xm7A?=
 =?us-ascii?Q?S+n7vlmqOBqfKDXD+iw1p6iF2TBVsceYnqV8u0jrjfDilGlzeVAHRk1obZgd?=
 =?us-ascii?Q?lrZNNeaf2OvyAtqOuwi2cyK1AIIy44+sCDGR0FsJxy7sFdd+I9SVMM8tUTVQ?=
 =?us-ascii?Q?CbsJ5MWTDaXyCBZPUH7xGUWkv2wH3xFLCI9iDk7/9wTg4h7K55UNx6l0Al1w?=
 =?us-ascii?Q?SQJouwxFUCYZVxKQ/2A6q7B2scb+J93TEwzYtzCIlVYLxgfJ3vCJfbUenUmI?=
 =?us-ascii?Q?UhFOYc3O8IlI7W6eArR4edMlu0iHYAOpOKgwh6T1iBhAE6ljLEciMIagOCkV?=
 =?us-ascii?Q?Fii24HiZTDfuAnSeH4fhluQZ2O34pl+4dAFznlrPAJj2Gp9YJsSKRU8GkHxz?=
 =?us-ascii?Q?U0mr8vcUpieqCTWfXnGlzU+uLYOV4qNZgHH+14mEQ/Isd24KYzedwJTY5wVS?=
 =?us-ascii?Q?PfnysbkvvcoHP8QNNAbSRWtfYkJL8eUph4S/+2yrX+g2V0QMDKbsEDz49e4i?=
 =?us-ascii?Q?qg8N2MIXRM23uLPSB3+AeWR9UVKCn2w08DbmSq7HtLH91T1nVRfeXzLMGoTU?=
 =?us-ascii?Q?2fsy3IcOqRj7Y2WZjxa0Jtt0MfQ/6ItlH8U8vwZSsbOgLQvnfHCjJIaYF4a1?=
 =?us-ascii?Q?g93cspVRVhuERp/qmaTZOE8lazwmg/oZ6xeckrqIoUsxwzQaVonUeQDRO1xM?=
 =?us-ascii?Q?t8qTB4tk3pR8c/PyF2kxqlOEyvf9gfPXXl7wFdxgjksHN9XWscul9C2gkFN4?=
 =?us-ascii?Q?Max8IIYL6FHsRdwoVAH5NksxvWQJ43eri+pTWh8sZujwXTNF0BV1/LMAJodu?=
 =?us-ascii?Q?af2U24C1My22CNSm5zGYNesGd5hVPm9n2VAyN9GAoIjXtelCtKpAnICpopNm?=
 =?us-ascii?Q?AI6Uy1aX/gHbwECWSTMOcNVnE8u+84grhxihvhotg5ZvQBwg2yo08XKuhDKe?=
 =?us-ascii?Q?jraD7n8Y9OxOVIUZQ1cHUlkCx3WFOXsw3YKbyQxG4a5dvK0JhLDr8hExr9BK?=
 =?us-ascii?Q?oDxx3FNYVRVIsOjZgWF/6FJHInR6+rZ0Ki6A204dzp22/rPdM6soS5CRgoQ9?=
 =?us-ascii?Q?DB8ZvZnuXhgUm92zoWHlI+lpEsxFeBAXnksNCkJhyaOU7LJNEt5cpgcZH0aS?=
 =?us-ascii?Q?pfV0UK4OQFIxPl33jMQR4qsE5EwHH7N8tUKTHfO7fkFdwHtpEGFZuIgLSr2L?=
 =?us-ascii?Q?mXGQYQCODa8qJUwhc29fHiDJDq6rFamrYoyXuAid1POun8GvFer6NQVyB5TK?=
 =?us-ascii?Q?G6m8qvFqtg=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80e50b04-7e99-49ba-0aee-08da1640eb32
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 13:42:10.9426
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yJKC4FWpmliMZNWuAjXOQvMmDodcVklDqBEVRe/1BKLicR4CvcDQeswYrrrSZTka
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR12MB2596
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 28, 2022 at 05:53:30PM +0100, Niels Dossche wrote:
> The documentation of the function rvt_error_qp says both r_lock and
> s_lock need to be held when calling that function.
> It also asserts using lockdep that both of those locks are held.
> However, the commit I referenced in Fixes accidentally makes the call
> to rvt_error_qp in rvt_ruc_loopback no longer covered by r_lock.
> This results in the lockdep assertion failing and also possibly in a
> race condition.
> 
> Fixes: d757c60eca9b ("IB/rdmavt: Fix concurrency panics in QP post_send and modify to error")
> Signed-off-by: Niels Dossche <dossche.niels@gmail.com>
> ---
>  drivers/infiniband/sw/rdmavt/qp.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Dennis?

And this too:

https://patchwork.kernel.org/project/linux-rdma/patch/20220228195144.71946-1-dossche.niels@gmail.com/

Thanks,
Jason