Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <54599d6c-204e-d7f6-21b6-15df7acad53d@amd.com>
Date:   Mon, 4 Apr 2022 13:55:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 2/3] x86/mce: Define function to extract ErrorAddr from
 MCA_ADDR
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>
Cc:     x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        James Morse <james.morse@arm.com>,
        Robert Richter <rric@kernel.org>,
        Yazen Ghannam <yazen.ghannam@amd.com>
References: <20220225193342.215780-1-Smita.KoralahalliChannabasappa@amd.com>
 <20220225193342.215780-3-Smita.KoralahalliChannabasappa@amd.com>
 <YkWrlTIK/ZxsQekX@zn.tnic> <YkmeJFXXbu3aLzzw@zn.tnic>
 <Yknsbp+zMh8Uev8+@zn.tnic> <87mth2kkhc.ffs@tglx> <YkoHKTuGaFfsF6qb@zn.tnic>
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
In-Reply-To: <YkoHKTuGaFfsF6qb@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzVsVjQ5eVRzRWtrT1p3TklOUDducUhBWnlqdklqc2F3NGlxODZBTVZhR3Vn?=
 =?utf-8?B?bWJOMXhUVVR3eCtMOEZ0M0Z6dWVuTWJpN1hmOUx0dHVhRzBZWnNXZTVxTVQv?=
 =?utf-8?B?MkF3bFp1SkRQVXRKZlpCaDhrblNkdWwrZzlYbit3ZEJ5a2JDTUwzcUhtbjUr?=
 =?utf-8?B?TE1jL1JuYXd0OENVZlN6czZwaS9xcVR0OWlRSWpKUWtHQTVpYVZET082dXRF?=
 =?utf-8?B?RDllbVRqTTdWSkk4ZkZjOVJjbmpnaVZ6NWsvQ1dtRnBTclJ4WUdSUTJhYmJm?=
 =?utf-8?B?bXVveXJ4aGplVndaU1kvS1dwV2JTU2hVeTQ0YTk2MTE0d0JrbU0rR0s1Y3Nh?=
 =?utf-8?B?K3pvQUVYUFZYRDkyellVV0M2b1ZVK2RjbG94a1NVclZwZWdNWlN0QUwwSCtV?=
 =?utf-8?B?OE1lOE4vejQrMHh3NlBMUWNZYnNmZXZiN3dpT0FiMGFuTmlFNHY0VkQ0Z2JE?=
 =?utf-8?B?SE1tdk1FYnJWQ1VuU09talNKMGdGeHR6NXh1ZERHdW9lQUQ1S3Z4TlR5ekdD?=
 =?utf-8?B?M2tUMGY2amxRUk13SXNWZ1hSTDhnOVdHMDc5VHhCKytpZGdWUFIyazUyWFZH?=
 =?utf-8?B?NDF6b0tLa1dieVg5djJaTWh4WkMrVHI0NnA2cVJJMjdPbTJzSDhuczZScFZ6?=
 =?utf-8?B?bXBFUTBQbW9sMHRQNWNKVyt3SGtrTSt1cVRIUVVib0g1ZUxPRDUwTXR1WjFx?=
 =?utf-8?B?R1VibmpvSnV1TFA4UVJOSGJpM1NmVWV5ajNkNmNaTmxnNHpKSzRhLzFHNW5F?=
 =?utf-8?B?NWt6NGxnMTcwcy84VjgvUWFxV0hULzRIZUZGK005OVg4cFdDd3k4MVI4MlFm?=
 =?utf-8?B?bzlrSFU2MmZNcnVkNVNCWm1lN05kd2p3VXNWcE5tWHNuVElmczgzczRGb0pq?=
 =?utf-8?B?Zmxkd1ltK1NlK2UwZVluVXl4U2sxREdMRUUxeE03SVNWM1NkcVgzVy9YbzlP?=
 =?utf-8?B?SEFhcWFsWml2OEVFTS8wTTA3ZHIzNW1FK0pnMUhKWWlTMDl1UHBHOHFaY1RU?=
 =?utf-8?B?dVNXQitFSXJhamVyaTlBc1Fya3FlMW0vNEtMUC9MTmN4SWI5YlBESEs2Vmdm?=
 =?utf-8?B?MkVqZ1JXTGZlU1J2cTJYeTlSbG9YTENaYjk5L0lwamo0WmM4ckNwRW5ObkNr?=
 =?utf-8?B?V1lqWnB0N0Y2ZXVMd2ZoTVMwWk5LcmkvU2ExUGpldVN6Z1B5bGFJa094MW9t?=
 =?utf-8?B?V2hRZmU4enlJTzdUbmJjaklPTC9YcDAvQnVzQXNMeG5veWozM0ZCRDMzbmFj?=
 =?utf-8?B?aUw2aFVDUnZsZEJUdE1SWm5IYVc3bERVVWtMZGNnTUZIQis2dHp1Yml4NVdH?=
 =?utf-8?B?NFora0pRYVRmemhNYWg5dTJiSm02UjRzWlIzanhmdi9hMmc0dkJ3VVRVelpo?=
 =?utf-8?B?alY5dmNQUFNRUU5uMHJVcG1QNHhLWWVUeXJ6ZGg3M3U5OVhsR3lFT0VxOUho?=
 =?utf-8?B?bCtvdFh2aEI1ZXM3elJqVTdCc2dvZUdRaG5WRmVMVkRUeXFvWHNybTYydm1L?=
 =?utf-8?B?SnF6NzRWanhvNHArOXJIMXpDR3QweGdHMU1NRXpXTDQ0SUJYNUtWQ0xZNEha?=
 =?utf-8?B?NU9hdW9hUk9ETklTazloNFdjSkZEbmZ6LzJEcjNBMDJ4U3B5RkdPRkxpS2Q5?=
 =?utf-8?B?Q3IzRFNpT3lCQU50Rm9QZWVwOFZMZ2ZKTFE5NUU2V2txaUVJbGJRNzNkQnBp?=
 =?utf-8?B?ZDkrZ1NLYzF5ZGw1WittUzdUVGhpVHZRT3dwaHBtNU5MVU1wdkZRQ1lia01C?=
 =?utf-8?B?cUJhb3Z1R0M5TGdBay9hNEx4anVwTmxCalMwWWJmd0g1bVZKTTJYT1kxemVh?=
 =?utf-8?B?cjdUS2FmOURUSWROS3ZsRGRNS3BJMHBzWlN0RWNRNlRJOUpsYzFpdDIxbWdt?=
 =?utf-8?B?Z2FVQWZvVkNMK1I0emoyVWdWV04xVzRyVWRRQy9sVzRFb3ptS2xacDBFa2U0?=
 =?utf-8?B?QnB2SFhXSjVDNUpyelNEQjV4VmpHdmtFZ1VPSjg4MURMSGh6WFdDOW5WWW1y?=
 =?utf-8?B?ZEIrTHNmaGNNZ1JxbEx2VGxUZnpMY204ZUpTb2RzUkovUVlmZjF5TGdXWXl5?=
 =?utf-8?B?dy92S2hWTkRuL0Npby9XZGd0QUJYYlgrTWxSL1ZMMGdNY256WEphRTZmTnF0?=
 =?utf-8?B?Y243aDV1bU5hWi9RQnI3WlJBY3EyL0x2SWRna0hKNHFOVEx2OGYvanhsdkVp?=
 =?utf-8?B?NkV4MFFib21yaGpWejI2Zko1dUlWSnBTcFRkbU9zazU3ZEdJYzV4QklHcVEr?=
 =?utf-8?B?amxtUThmVVNVQ0tZdzRvQUtJTjhlVk55eWExaFgyL2JLZkhNMXVLMlRPU09F?=
 =?utf-8?B?RnlLb0ROcS9xVTFPRnQ2K1FudU93YVZBaFJDcWYzU2tiUkRDdTgzUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 940635a2-e618-499e-8998-08da167d7036
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 20:55:23.8191
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Di7Grt9knniVjrsVsh4PXFnnuKo/81TyGlc5BRxxmtIsthFN/iiiZrfwg6dE63HiZZIFaQfncZ/Ej4Ui9EotCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4283
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/3/2022 1:44 PM, Borislav Petkov wrote:
> On Sun, Apr 03, 2022 at 09:58:07PM +0200, Thomas Gleixner wrote:
>> How is __always_inline supposed to work across compilation units w/o
>> LTO? The callsite is in core.c ...
> Hmm, right.
>
> So even with patch 3 adding more changes to that function I think it is
> still simple enough so that we can move it up into the mce/internal.h
> header so that the inlining can work.
Ok will incorporate all changes.

I didn't quite understand what needs to be moved to mce/internal.h. Was that
addressed to me?  The function call smca_extract_err_addr() is in mce/core.c
and the definition in mce.h
>
> Thx.
>