Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <a4a46d80-d3b2-9e08-c80d-ab72298931f9@intel.com>
Date:   Mon, 4 Apr 2022 17:24:06 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v3 2/3] x86/fpu: Add a helper to prepare AMX state for
 low-power CPU idle
Content-Language: en-CA
To:     Thomas Gleixner <tglx@linutronix.de>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <linux-pm@vger.kernel.org>
CC:     <dave.hansen@linux.intel.com>, <peterz@infradead.org>,
        <bp@alien8.de>, <rafael@kernel.org>, <ravi.v.shankar@intel.com>
References: <20220325022219.829-1-chang.seok.bae@intel.com>
 <20220325022219.829-3-chang.seok.bae@intel.com> <8735ium8bv.ffs@tglx>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <8735ium8bv.ffs@tglx>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1VKS0EvVjFkbGJnMmVwY1BENm8yR3g1WUEvQ08zanVZNW92Z2dCN1dUMGtV?=
 =?utf-8?B?dEJRR1lpSnZDa1laUWtkT0EvVlMwc3lZQzIzOGxKbDdwbTVNUTV1TTdneEVV?=
 =?utf-8?B?SGpBWkRuS1RRaWQydEZTSGd5a1RTVk9vMndLQnBQQTluQ0RzNE44WHNPZmFT?=
 =?utf-8?B?ZGxWMVNIckkzN3N6dS8rdmxRRmh0dm93YjJvZDdaT2ZVNFoyazY3QkovblNF?=
 =?utf-8?B?K01qVXJTUUFHMjBITzU0S3lXY3N6SVdZQlNKek9PYllBR1VUNk5LcVVtNkRZ?=
 =?utf-8?B?bFliRU1kSFB6Y2djMGJmRGhNaDFkc3REd002RlpaVzlqTExNRG91ZHFjcFQ5?=
 =?utf-8?B?NUVITVpLS2MrZ2NVNDNwdVN0SThNR0h6MS9JTDNRYWI2SFNEdHhvOVVvSDdD?=
 =?utf-8?B?NTZDNmNTWTVJMzJlQlVVSCtkSXh6OVJZcXZBMzJOazhyT1RrcnVXSnU2TTNw?=
 =?utf-8?B?SVpFd3lxbGgrMzF5OExwbTJKRk9xbEV1Sm50Z2VIb3B6U2FnTmdJeUNYajNn?=
 =?utf-8?B?TUFsd01zdUpmQ2pKa0owMjluVXZqSndRU1RRT3M0N0JYMmtJa04yOFBWQnNM?=
 =?utf-8?B?Y0lKbFFuYkZJeC9pTUxHQ2t2ME9aYW0wWEtzR1dteGtQM3duVVpZQjh5NFVC?=
 =?utf-8?B?N2MwR0xXV2t3R3JXTnRxL0Q5REZybVdFbmFNbFNsRDFSdTV3dXNJWW4rdUhv?=
 =?utf-8?B?ZEpwK2hKMTZlUmpSalVZT1F2UjNkdis3YzhBdzVmelNrZ3NsM29qcWpKUmhO?=
 =?utf-8?B?N0cwQnJvbU96T3g3VER4Y1VGam0zOTBHeXAyQzlQa3BjMEIzVFZ3OUtHbkM0?=
 =?utf-8?B?c0MxenJWQmFtKzVKWUMxYVZ5OUo0aVRLU2FaWWt0ckZFZlRsK0JOZjIrWDlr?=
 =?utf-8?B?T3gzMVdUTzRnYzd3bWFBSnZKbHhmQlRWMHZWYXFibUd2dzd1Y0hZQ1Y1K1lX?=
 =?utf-8?B?aGEydWFvcU4rcDBUeEZlazRlbklWdXROK3dMNjN4cDFPRGVQVjJnbTVlZmtw?=
 =?utf-8?B?WEFkSWJIKy8rQ1dhMWV4dTE0RlpBL2lDV0FCbEdSYldSRFlBczZyb3R6bVB4?=
 =?utf-8?B?YVdoWjAzUW4wVEhkR0ZQNjlBZ1M4KzFYZUljSDB6d0gxcWJ3dHVVemdOOWJj?=
 =?utf-8?B?S2hkckovOS94QlgyYVdEOFJ1K0ZvYktBOWZuS1M0RHJ5Mkl6U2Q2TW9UbUVC?=
 =?utf-8?B?QmNYaFJibHphMXFoK3hBNk93bXg2YmRZMUJ4SVRneWFmU0cwR1R1SC9XeWRB?=
 =?utf-8?B?Z1IzWHcrQ2EzUHI3blRXVmVuS095WUlOWXozUFFubjdld3JHQ0lyWjVkRVdm?=
 =?utf-8?B?bGpaMDRBQzZRenVxQ2h2NGdQRS9mWURUN09Pc0t4OUhld3hHZC94a0pQa1pS?=
 =?utf-8?B?YUYxWG1OdEgvQWxPMlFsT0N4czdIaWphaHdnSjdKUmJvREpaZ0p4bURrS0Mz?=
 =?utf-8?B?VHdyOHcweHp5QXA1MEdkTUtralJvUFRBOThVK3ozL3BGQnpwLzZqa0o2OVA0?=
 =?utf-8?B?NXVkclZkMVdBWDBWOUJqVFVBQnhRZUo5a3JaWEp2dWNpMUV2N0s4WnFvb3F5?=
 =?utf-8?B?cjhVZEpUSFFqWVQyRmkyVjBqMzRZYldTVDVORTFnLzQwRmdrY09pMzhSWnA4?=
 =?utf-8?B?MFlZWGVzemh6K0toNTl0cDM3ZnY4Rk1rVjNNNGFzMDZmTVkwZlI5YjAxRFJM?=
 =?utf-8?B?a0pqRnpmYXppT09NTzlVZlZqdkI5SUQ3RkdDbkxrODZob3hJOWVMUUNwd0pZ?=
 =?utf-8?B?N2pteFhoQk1SaHdiTFY4NG9PR1RNSWxGbVQ0aEx5VzZ5V0h5SkErYkxPZHFO?=
 =?utf-8?B?SnNtTHBaSkdHSk0vMkZabUt6WWtSM2JFdXFHVGRYUHAxTlErVW5IOEJBb1Vn?=
 =?utf-8?B?N3NGYklBcVYvdndkZWNGY1pORmd1NEhIUVlvOUhGUkMrQjNCTzV6dEZPdC9X?=
 =?utf-8?B?Q05IcHlXUk1vMWE2NHRTejBRN2xhb0h2d3hza3M4T3BaeWRkRHZBRW5BM0FX?=
 =?utf-8?B?MXZzeDRZRVNjVWlLeU0yVUZjcWZBMnk3WndNdjZwMVEzb3AzQ2RmMktLTWJa?=
 =?utf-8?B?Z2o1V09ZRnFCVkh2RjNjcWFVakVXb2g1aC9GeE5KdTlHMk11UzIzTUdOcEw4?=
 =?utf-8?B?SlJSNG5GYTZtRUdZTUVCZFk2Rm9hSDhqV2JYOU15c2tIckE0TEx6UThySkQ5?=
 =?utf-8?B?ZmEydHZlU0V1eEh2aDFjMG5vdHlpWUVSTUZaNjVsOWRpNU0yMmpRbXpzV1JE?=
 =?utf-8?B?a2ZJMzlkeWlPaStpYzc4eTJPby9ZN205UnZXTXl2ZXdWYlBHMFlRKzJEby9X?=
 =?utf-8?B?eitjRTNpb1E2SXhUalFkVEwrQlZtR1FTaEF5RXdQUEkzamtpWHB4SXZWRGV6?=
 =?utf-8?Q?BCccP3wthMw4oV1U=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f7ed047-7b8a-4e47-df19-08da169a9c16
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 00:24:12.9615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xGWifKIjCq1GNLdXUNn/AMbwt5iS8u9O71cBME5PZAz/TsiWbAiax4pYcGSYvhwP8R31cXtphb3AUSsa2N38VGMnOfSrVTDV1gSCzQd7Wfc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5276
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/3/2022 9:37 AM, Thomas Gleixner wrote:
> On Thu, Mar 24 2022 at 19:22, Chang S. Bae wrote:
>> When a CPU enters an idle state, non-initialized states left in large
>> registers may be the cause of preventing deeper low-power states.
>>
>> The new helper ensures the AMX state is initialized to make the CPU
>> ready for low-power states. It will be used by the intel idle driver.
> 
> What about AVX...AVX512? Are they harmless in that regard?

I double-checked with HW folks. Yes, that's the case. Their state 
whether initialized or not does not prevent the processor from entering 
a deeper low-power state.

> 
> If so, then the first sentence above is confusing and should clearly
> spell out that it's AMX which causes that problem.

I see. Will do that.

Thanks,
Chang