Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <tencent_452951FCBB813C31CBE516716C537884D70A@qq.com>
From:   <xkernel.wang@foxmail.com>
To:     "'Greg KH'" <gregkh@linuxfoundation.org>
Cc:     <Larry.Finger@lwfinger.net>, <florian.c.schilhabel@googlemail.com>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <tencent_0A1273526E1E87150578F8B752CF7F178806@qq.com> <tencent_3096E1464A73FF232014CC40B9001C551408@qq.com> <YksAzXHif7Usdfv9@kroah.com>
In-Reply-To: <YksAzXHif7Usdfv9@kroah.com>
Subject: Re: [PATCH 2/3] staging: rtl8712: add two validation check in r8712_init_drv_sw()
Date:   Tue, 5 Apr 2022 09:10:24 +0800
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQO0Uoy989zRJT7S4c8YGkbirmJg/AIqqt/GAmblFDABs2btQg==
Content-Language: zh-cn
Precedence: bulk

On Monday, April 4, 2022 10:30 PM +0800, gregkh@linuxfoundation.org =
wrote:
> You just leaked memory :(
>
> please please please test these types of "fix up error handling"
> changes, as there are lots and lots of ways to get these wrong.
>

It seems that you missed the third email in this series.

In fact, I did not ignore the memory leak problem. But considering that =
there are other paths which can also lead to memory leak, I separated =
another patch to deal with them specifically.

In the next version, I will adjust the sequence of the patches and add =
some descriptions to explicitly show the relations.

--
Regards,
Xiaoke Wang