Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <7f47ea7f-73ee-9010-df8c-9c6c1fefc98d@amd.com>
Date:   Tue, 5 Apr 2022 08:45:07 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [RFCv2 PATCH 08/12] KVM: SVM: Adding support for configuring
 x2APIC MSRs interception
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
        jon.grimm@amd.com, wei.huang2@amd.com, terry.bowman@amd.com
References: <20220308163926.563994-1-suravee.suthikulpanit@amd.com>
 <20220308163926.563994-9-suravee.suthikulpanit@amd.com>
 <426b70a407b774627187e64b011a64bfb7214b36.camel@redhat.com>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
In-Reply-To: <426b70a407b774627187e64b011a64bfb7214b36.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmE4eDZaZVl4QWttYkN4RjZ1R29CSWRzNUo1MnNBZmF4a2lKS292OTdLMmc3?=
 =?utf-8?B?UFBsS2pwVHhRWHlVSXZzZUZsdUY5am84ZmxTRW1uUHNxalN0Qjl1YzliWXRB?=
 =?utf-8?B?R1JkalRSbEZ6YVdkR2RUWFc1MFk2VjVGVDRQTGNBNmpQVFlLTVNVMnBDWC9F?=
 =?utf-8?B?azNLMWJZQkNOd3FTYlBmVVpBK1I5Sld3VjJ0Z3U5eWZEN2VzUURMeU5hK1Jx?=
 =?utf-8?B?MkNqSWh1WFNKQk1ZTk51bXRzYVlZVkRGTlNXY2hNQXc1MWxKY0VWVTJUMHpQ?=
 =?utf-8?B?aDBQbnNwdmxzT0hlZ3pBRVhYbU40enRWY29GOFArK2ZwV3VBNmZsQ2dHOVhp?=
 =?utf-8?B?VEJQNTN6U29tcXozV21oZHlueG9DMTh3RUxLak9ROFZLcytHYlRUU2pwQTY0?=
 =?utf-8?B?MGZSYzZ6MGJLay9ZS2krNnY3TEdVYXhrS0VCdERZRzRxOGV2R0FUQkxmbHJ6?=
 =?utf-8?B?U0d6UDl6UEp2cnlteFUyQS9vR3VJU2lDWGlvNEttRVEzcXUvVFArdVJZSWhx?=
 =?utf-8?B?QTB3U3cxN2VsVnJ5SkZNRjk0MXZkdmg1eFVtT3cwclZQTExrbzNDWDJSS1hn?=
 =?utf-8?B?QlhFNWdnRU95ZXIxY2F2U2RKYUxIWFZlaDJOcFFvb09reVoyWEI1SEF1bCt5?=
 =?utf-8?B?TlNiRG1vK3g3a1JlbHR2TkdUTVNjOGk5WWxVakpyWW5qdC83S0ppODBrckxX?=
 =?utf-8?B?MW1USGt3L3NDV0tVSW1NZlJCMTlMMGFFaGdEd2wvNGd5NE9aaU1YamVPWmth?=
 =?utf-8?B?T1Y3eDBxLzFaSkVocG4ydE1Gd29wS3VkSlU4bGFOQjNEcVZhUTdDOTZuUHpn?=
 =?utf-8?B?dklaVytpcnhqYXdJSk5pNHUyRVZ3VTgzelRFb3MrUGtISmUyYUV3bVUvb3lt?=
 =?utf-8?B?bkt4SXVsaWlOa05RbnJNMDF2QVdMd0hGMlV1WUYxekNnZ0pNUjRYaDRqOS8y?=
 =?utf-8?B?YjhXRkhaQVNtcTNQQUVpWThFbm80K3J5ek9oQlVheDhKRDcxNnNqM1JZR2ds?=
 =?utf-8?B?c0hVUkVJMFpnSVJEd2tFYnMwRVlwcitIOUI2bGhTQUhTVXc3c1Ird3Q1dm9I?=
 =?utf-8?B?ZWJ4aUFCSXBUakEwVGZDaVUvS29vb1dWcm1DWmJWUXFhSWNiWnhEVDQ0WGg4?=
 =?utf-8?B?S3RHYjl3L1BmeUNSU3E3REhaQ2d6dUdJQWVhaURnQ0xmN0Y1UHFGaVM0NTJr?=
 =?utf-8?B?Uk5ndFg4SjVtT1BDK0FaVjdnNWpiUGRXMjJqNWlkMGR2MmgxdXFxVEM5bzhn?=
 =?utf-8?B?dzV5eGtTVUhOTUQyYXZPclp0K1Q1YzZIUlF0MmV6UFJxUytaZVI2Mk9ZckpK?=
 =?utf-8?B?akprcVU5VnZJc3QrSVFRWGFwVVVITFVFeWlpTDIzeWN3RzRncktVbURMMGlD?=
 =?utf-8?B?WUNGZ0dTMURDcm0wOThlaXE3cHkvY2kxVVg1N0JCdndoNjFiaGlPUGVKOHV1?=
 =?utf-8?B?NlV0Rkt4UGphb2hGVjNlUHQ3RHQyVGtRM1V0NzV2eDlaaHE0b2JtV1FQd1lC?=
 =?utf-8?B?M096c2V1amd3aDBXbjNVWDNlZG1xT0MzRDJBWnBDeGhaNlR2RzFxVEwzNlYz?=
 =?utf-8?B?bUFPTlRnczFkaWJzQ2U0Wk5MT3NwNWRRS1lzT0hIcWtxNWYwU2VJbGNuVmtN?=
 =?utf-8?B?NFlhSkY4MUwzSW1Lenl1WEdkMHl1YzE1czNzckJmY251TFlzbm1LYlVvOTdZ?=
 =?utf-8?B?aG41RGh0SlhPSmZGNVlLYUtiMDZLcWlqcmxDR0dOcWVtMk1jK3JzQzI0Tmt0?=
 =?utf-8?B?ZmwzY1R6d2JkejhxcEFxZEFmNjRIY2wzNjRUOFB6SXJHTnhiUHRxYmd0aFUx?=
 =?utf-8?B?UFpIdWk3UXErV2FjcmpUSjA5ZHlXa0s0UWphRjUwcXNJYkoybVVvRVFpYVhY?=
 =?utf-8?B?Z2hocW4yNDVoemxNVElvNFBCOGpySUZOS2VNaXB6VXlBOXZHOVVTMC8zY2hk?=
 =?utf-8?B?elFjSGZoTTNqc0lVcjJVUTBTeTJqMVp1ZTdPYVlTTHRhRXpFVVJDQ016UTBt?=
 =?utf-8?B?b0lqeGFwOGtWSEl1MGJNR2pOVnR4UExhbmdyZXg5Vko2dDdNNHNiODdLYnNP?=
 =?utf-8?B?Zk43bkw1V3hpSVlON0Jvc0FQRll2VDQxNUVNRFBHUzRzMlk1TU9tRWl6d2VW?=
 =?utf-8?B?RGhqR2RiQ0tpMDVnZ2d4MmpiaE5uSDJCQmpXSmpIS2FpK1ZyWFY1WFIxOWVt?=
 =?utf-8?B?c1lQOFEwR2hrblZrMWhERHhSTWhmWEx4UWdwOC9OanlBT1lIUVI0dzVicG94?=
 =?utf-8?B?VStleHBiM0ZTbkEyMjhTOE1Ka05VMjlKUzdFUS8vTVB1OVFlbCtCSGp0eGRx?=
 =?utf-8?B?V2tib0hmSE9GbEljVkNPWUR2VDVMcFMyQUVROFJBQ2FvTTJScjlNMGxpVnBG?=
 =?utf-8?Q?PF6g0Ffe7vGjll/9zZK1le2hPhTZUnAqFu4vV23Z0xbZC?=
X-MS-Exchange-AntiSpam-MessageData-1: 0/dprPUbu46awg==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45939695-2ccc-413a-7332-08da16a5ef17
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 01:45:16.8676
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q43sVZzqerqo6gUTPWzlmRBZSh4nThBkwfuQCN9iTJaHb40CVjyd1y6HJfvBBMJMdEwVH50HSL+3g/VN0O6qvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5980
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Maxim,

On 3/24/22 10:19 PM, Maxim Levitsky wrote:
> I did some homework on this, and it looks mostly correct.
> 
> However I do wonder if we need that separation of svm_direct_access_msrs and
> direct_access_x2apic_msrs. I understand the peformance wise, the
> direct_access_msrs will get longer otherwise (but we don't have to allow
> all x2apic msr range, but only known x2apic registers which aren't that many).
> 
> One of the things that I see that*is*  broken (at least in theory) is nesting.
> 
> init_msrpm_offsets goes over direct_access_msrs and puts the offsets of corresponding
> bits in the hardware msr bitmap into the 'msrpm_offsets'
> 
> Then on nested VM entry the nested_svm_vmrun_msrpm uses this list to merge the nested
> and host MSR bitmaps.
> Without x2apic msrs, this means that if L1 chooses to allow L2 to access its x2apic msrs
> it won't work. It is not something that L1 would do often but still allowed to overall.
> 
> Honestly we need to write track the nested MSR bitmap to avoid updating it on each VM entry,
> then with this hot path eliminated, I don't think there are other places which update
> the msr interception often, and thus we could just put the x2apic msrs into the
> direct_access_msrs.
> 
> Best regards,
> 	Maxim Levitsky

Good point. I will fix this.

Suravee