Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a6964809-ad10-aca8-0776-011c9e6b318d@nvidia.com>
Date:   Tue, 5 Apr 2022 11:35:03 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] ALSA: hda/tegra: Fix hda Jack detection
Content-Language: en-US
To:     Takashi Iwai <tiwai@suse.de>
Cc:     tiwai@suse.com, perex@perex.cz, thierry.reding@gmail.com,
        jonathanh@nvidia.com, spujar@nvidia.com,
        alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220405032607.8489-1-mkumard@nvidia.com>
 <s5hfsms843u.wl-tiwai@suse.de>
From:   Mohan Kumar D <mkumard@nvidia.com>
In-Reply-To: <s5hfsms843u.wl-tiwai@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWpFR3NpbGg0RHhDUlhjRC85YnhyREVOVzJQUXd1M1BXc3k4ejlaOFMvNzcr?=
 =?utf-8?B?UGQweXVDdjltVkdpaDlwd1R3c0pIOWdLSTJmbEJ3V0N4akxvQkVlYjJQRjBZ?=
 =?utf-8?B?M2Q5K2ZJZDQ3Y0p3dFY4dHM1cW1JVzdNTWNsY1BVV3ZwVTU1NExHTWFMSHM3?=
 =?utf-8?B?czhkbmJRNEt3VjhZSkx0UTg3NWprYm1WNDNVZVM2Ujc0a0xPWVZYQ0JJOEtt?=
 =?utf-8?B?ZVNnUXhsNU1BcnhxTXd1dFZaUzlaelJWQnVoSktsa1psdGw1Wm9GaVpqVjgy?=
 =?utf-8?B?bmg1UjNNTlJLaGhWK1hyOGgrVm9xUWxyT1hVaXRGdGN5bHFxaGZvektySUZM?=
 =?utf-8?B?bi9qZzJRb1hLdG5HOERjRnRyY1RiSEVoaFBvVDlKaGdEZHNKbzNWNFdTNGF2?=
 =?utf-8?B?OUdWZ2htaU9Vb1QxMDZ0UE5MbXJUR3F3R25wdGcwMEhpRUc4RkZ1eGdaLzFv?=
 =?utf-8?B?cDhiU0xDQm52TDhzdWZiTG1PTkRFbEx3eXN1ckZBSEhJVjQ3NmRJN2Jsdzdl?=
 =?utf-8?B?dmd5UlNYOVh3SnFmV0RLNjlBbWx4a2l1RUtRMmNTMHBlejN1Ukg4UnVUK0Ez?=
 =?utf-8?B?dGhBeUNpd00zdERHN1BkRG5KeDQxM3FkUUo5UnVncFYxekl2blVXUzk2WnRG?=
 =?utf-8?B?SEJaVGwwc1lqWXZuR2ZHVW5HRUhzMWdCcUVvQWZvWjhnYWNZaWUrcmkwRGZK?=
 =?utf-8?B?YmdtSE00TWxac3dwNisxSHVyYUxKc0I1Y3dXSDJwWU0yRVBaUHhLb0VjYS9l?=
 =?utf-8?B?YndzKzBKOUNLd294S2VyN0tWdG1wV0tHS050UjdsbnBSK0lDbGR6Sm1xN29R?=
 =?utf-8?B?ajRXdXB3b3hXNVcyWmVlSlM0Sm1NV29vcFVtQmlxQ3VWd0VwVi9rZ3lESGVH?=
 =?utf-8?B?SXdSc0tBOXlkcG5oUndQcUVMZytmcExoc3ZWL1d0d0pXNHVzTVB1eXZxaUdI?=
 =?utf-8?B?Z1FGUEs5ajRpYVdqMUIxbXhkQ2N0THFMb3NrczdDSDBhb3pCUFNuczZZcFhs?=
 =?utf-8?B?NlJtUTFBcUdJeXE3SFRKbU9qd2xERCtBV0FWOHgzTEJUNkdhS2Z3MGEyaHFx?=
 =?utf-8?B?RGliQ08yYXkrMHk1VXNkcFYzSm8wWklEZ2JCSDVxQnVwaXJiSGZEZ29nL2xw?=
 =?utf-8?B?M2M0VGQzajFrN2hUQ09FZEVjNy9KVlI2ZzZHMWpSaGZxamdaNWp6QWJDQWt0?=
 =?utf-8?B?bUZEMG5zYXlpTHFkekJ1QlpCRTNpQUt4YmtEVUF6bjdrUEY4dXY0SzlvSXpU?=
 =?utf-8?B?RFBmYlpBWk80TGFDenpvUHZpUHg1bkxVMXF3SmRBcDdjNWNCaEJDc3JtdlpZ?=
 =?utf-8?B?anhTbHh3STBKcGZZdG1hWHpBZEZKVG4zK21lWHU1c1hyUTVTd2hjdzZCVXc0?=
 =?utf-8?B?QjBTUUdwNTRlZXB0KzE4U3duT1l4eCs1SFhUZGtoYUUxTGUydEZ2UCsrSGRY?=
 =?utf-8?B?V21CSmZNU0I4eGlhak40MjU2QWhCeDlBRzNUdkd5WUVOQ1RoeklpVUUwaFl5?=
 =?utf-8?B?NERJcE5xcER3TXlFY0VFNGJ0Q09pbFB3RlFDQ29zRDBueitFei9UTkdmU0Z6?=
 =?utf-8?B?SHp1S0xxVkw1K3ArQjkrRE5lMFZFMWd4bkF1UVlWdzEzTTJCRHRZeFhVRUs3?=
 =?utf-8?B?eFIvR1BoU1RFQUZRRnprbVZDSnVWWW0yK3kzRmdVVGEyL1dPeitaY3FRZ0Zi?=
 =?utf-8?B?S3Jnak1KYTdKUmpYZlhldzlYQ25XRFAzcnNkUmpyUDIrRGFPdE9FNlBNVXZX?=
 =?utf-8?B?TmU3eG05ekFQMEptdnNnLzY4V3g0R2FhaEFzeUJrMW04U1ZjNksvYkIxeFJx?=
 =?utf-8?B?R0NjUUJ6R2FyYUZGMWdWRmxJU3p2UjlLZ1cvY0NyMEVRb2tyNkpnZTlMV0JX?=
 =?utf-8?B?NXRPb29Hd3R1MExmdnJ4Qkh4TUZpL2lwUGtIaVJzbmZSVXpaajc5WjZEaGZu?=
 =?utf-8?B?UHNGNkRzR3VEdkpHSE5xN3RkZ2dUNHlRc0RvOGU1SGJzN0lNVzdqbXN5MC95?=
 =?utf-8?B?V2lRM2t5Y3hNNjFqdXZPdnVKL3J1UlcwMW1qY3VMRTRFY2xEZjdydHM3dWFZ?=
 =?utf-8?B?VWVYc05aNUwvZzcvSmx6amJKaHphNzFiQzdSempjUk91M0YrdHpzSXpSQ1ph?=
 =?utf-8?B?dVVnRVdUT0lCZnovOUJjTmtyczB0bEQyS0MrK0tKU0FDdnB1UjZEanhSRHBT?=
 =?utf-8?B?RzJ5YXdacnVWcWorM2xMQWxESGlCUDNKT1BPTFk3Y25VbU1IamJucERFWW9U?=
 =?utf-8?B?K0JnS3JycHRnQnkrZXNwN0VwT0FkZlRIQXhweGYwaVBCTGxaYWhqMTAwK1F5?=
 =?utf-8?B?dDFjby9nMDRrSkpyeGxVTHZvNDJTc0JRWUpLSUd4bkZGK0NJa0xmQT09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 464f431c-320c-4528-f03a-08da16ca408c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4435.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 06:05:15.1654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KFmHkfRtQAxYtDNBCiWqmnsFSK4aYJNu/60Kvz+l7vDYq9y5CxPkXEks5NOsO6YM16ojzSEEFtpoSZijVLv+qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3154
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/5/2022 11:27 AM, Takashi Iwai wrote:
> External email: Use caution opening links or attachments
>
>
> On Tue, 05 Apr 2022 05:26:07 +0200,
> Mohan Kumar wrote:
>> Tegra HDA Jack detection logic doesn't work when the HDACODEC
>> in runtime suspended state as unsol event won't be triggered
>> during D3 state. As pulseaudio server in userspace rely on the
>> jack mixer control status to show the audio devices in gui and
>> any display sink device hotplug event during D3 state will never
>> updates the jack status which will result in no audio device option
>> available in userspace settings.
>>
>> The possible option available to resolve this issue for multiple
>> tegra platforms is to use Jack polling method for every 5 seconds.
>> Also to make Jack detection work seamlessly the Jack worker thread
>> needs to run continuously after HDA sound card registered
>> irrespective of whether HDMI sink device connected or not, but the
>> Jack state update call happens only when Codec is not powered on.
>>
>> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
> Hmm, any reason not to use the standard jackpoll stuff that is already
> implemented in HD-audio controller side?  That is, doesn't the
> following oneliner work instead?
The reason is, the Jack poll thread implemented in hda_codec.c runs only 
when HDACODEC is in runtime resume state. But the problem trying resolve 
here is something opposite, bcaz when hdacodec is in runtime resume 
state unsol event would work but not during suspend state. So either 
need to make some changes on hda_codec.c specific to tegra or make it on 
tegra specific driver. So I went with second option.
>
>
> thanks,
>
> Takashi
>
> -- 8< --
> --- a/sound/pci/hda/hda_tegra.c
> +++ b/sound/pci/hda/hda_tegra.c
> @@ -421,6 +421,7 @@ static int hda_tegra_create(struct snd_card *card,
>          chip->driver_type = driver_caps & 0xff;
>          chip->dev_index = 0;
>          INIT_LIST_HEAD(&chip->pcm_list);
> +       chip->jackpoll_interval = msecs_to_jiffies(5000);
>
>          chip->codec_probe_mask = -1;
>