Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fda186f7-2cf4-a69a-d68e-58073d35cbea@redhat.com>
Date:   Tue, 5 Apr 2022 08:26:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] drm/format_helper: fix a kernel-doc typo
Content-Language: en-US
To:     Simon Ser <contact@emersion.fr>,
        Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org
References: <20220403232902.1753-1-rdunlap@infradead.org>
 <ttcrpLw9HkdhAH5SkXylXDBi9SBf7LWgOeW09ZvTF4U4_zKJAOXBQZlFxfw6NKY0Hip6dXBFape6zkX09cstuOno72c-c00wmZ_VbNDg6xs=@emersion.fr>
 <b20bbd22-895c-9e74-e579-d2f3561a2fe1@infradead.org>
 <BzpH4s8ZYn84kTlJQ3BHVMQzZlESb2Fk6v-uO5KBaaeBNMvRvC98lpuBLUNLE3a5bdoYTb5JRvo6EU__5AGJ79LUirSppO39I1t1xlwx-fI=@emersion.fr>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <BzpH4s8ZYn84kTlJQ3BHVMQzZlESb2Fk6v-uO5KBaaeBNMvRvC98lpuBLUNLE3a5bdoYTb5JRvo6EU__5AGJ79LUirSppO39I1t1xlwx-fI=@emersion.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/5/22 08:12, Simon Ser wrote:
> On Monday, April 4th, 2022 at 23:35, Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> On 4/4/22 09:04, Simon Ser wrote:
>>
>>> Both doc patches pushed, thanks. I had to manually edit them because they
>>> wouldn't apply cleanly. Next time, please use git-send-email (see
>>> https://git-send-email.io/ for setup instructions).
>>
>> That's odd. I did use 'git send-email' and I don't usually have any
>> problems (AFAIK). I'll check those setup instructions.
> 
> Hm, maybe the issue isn't git-send-email, but the way the patch was
> generated? I had to manually edit these lines for the first patch to work:
> 
>     --- linux-next-20211217.orig/include/drm/drm_file.h
>     +++ linux-next-20211217/include/drm/drm_file.h
> 
> I changed these to:
> 
>     --- a/include/drm/drm_file.h
>     +++ b/include/drm/drm_file.h
> 
> This wasn't enough for the second patch, I had to re-do the changes by hand
> from scratch.
>

Yes, I believe the suggestion should be to use git-format-patch instead.

To make sure that was is posted can be consumed by the git-am command.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat