Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220404172322.32578-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20220404172322.32578-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <Yks3Q75ZrUkXSjwz@ninjato> <CA+V-a8skF4h6yhjSFw5PXQEbgKEQt6kMs9bEsO3OCNfE1hu46A@mail.gmail.com>
 <YkvJXu7Y6Tc68U9e@shikoro>
In-Reply-To: <YkvJXu7Y6Tc68U9e@shikoro>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Tue, 5 Apr 2022 06:13:11 +0100
Message-ID: <CA+V-a8uPSr6+xcyqmBXZzuPb04v8KLNRou5Y+QvC7ibuAU_2Ng@mail.gmail.com>
Subject: Re: [PATCH 2/2] mmc: renesas_internal_dmac: Fix typo's
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>,
        "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Linux MMC List <linux-mmc@vger.kernel.org>,
        Pavel Machek <pavel@denx.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Biju Das <biju.das.jz@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 5, 2022 at 5:45 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
>
> > > > -     /* This DMAC cannot handle if buffer is not 128-bytes alignment */
> > > > +     /* This DMAC cannot handle if buffer is not 128-bytes aligned */
> > >
> > > Well, as we are here now, I think this can be further improved.
> > >
> > "The internal DMAC supports 128-bytes aligned buffers only", does this
> > sound good?
>
> I'd think it should be "128 byte aligned"? But I can't explain why, just
> a gut feeling.
>
Fine by me.

Let me know your thoughts on patch 1/2, I'll send a v2 with updated comment.

Cheers,
Prabhakar