Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp57562pxb; Mon, 4 Apr 2022 23:53:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7f5G6EIFfH455Jd8sYH89CArcf3yzmQHyfjJ2KzclOQWGDxCUS5zn+5ybwFJukGWyjI1N X-Received: by 2002:a17:90b:4a02:b0:1c6:c1a1:d65c with SMTP id kk2-20020a17090b4a0200b001c6c1a1d65cmr2360813pjb.97.1649141638759; Mon, 04 Apr 2022 23:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649141638; cv=none; d=google.com; s=arc-20160816; b=P4A+sYkonAot/1DhhweeuxcOB1RSx+3tG+cQZis/UPC4SuxY1lM0xOsxOiJOkVKuXw 2QFrSpoQKpaqm30eRoqiGP0EMfrwiqE9hJliIaHOhw04NaKwn/GYE5aNSdftydwoho2q ZOl1/by7kRS4rIF4RGB62QqO07RiA+d4xE03vZM/iHU1bUu8IHk25vKyUXv1uIbFmaxu NHU48CiDMe0pmaDjPnIEHJAYzUP4eIjAdBJhxrlc1O+Rv0PiMc0R4FGdlqVBEwyTFEMS Nz82DdElx7WydjsLRYbS6VkZxtstg6p51C2ZKW4mcRh0L1eGoirOc5zGg9lksyN0nfun gIOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=6ru1K9AnUQO1xWhO54+k3fzCBUb972pickNuOuoi2/4=; b=zKvdjT4thY7msBVEjJHosxu99yYceIuF6XBxCYMGiFcEf4lfLApfwVkSeR+jQkgx27 HOTejcZPIuar9d2c308azVp4f3Yh/u9C6XIxTh+r96kZAmt+twzyd9zxHV8UayzMrfQq HObHuJ0evfz6G8hkL/rSt4cj2dGJU51twmGimc5FdpXITEx/BQAe1Hry43vrv6IKH8sB 9Qzj9+vSbdhptG8RGbMYKGMIYsvoE11CEbG3c2e63Uz7CeXGVEPLyO6+qscWXqZ9z4A0 Xjgqrg1Dk81ovJTuRLIA3aIoqmsnXkDf8SH9s94h022mSxEW44NRWjKqMcS/St52lnd5 DOfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f8-20020a656288000000b003816043ef06si12157934pgv.251.2022.04.04.23.53.24; Mon, 04 Apr 2022 23:53:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229756AbiDEG0Y (ORCPT + 99 others); Tue, 5 Apr 2022 02:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229685AbiDEG0J (ORCPT ); Tue, 5 Apr 2022 02:26:09 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BE4A3B543; Mon, 4 Apr 2022 23:24:11 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id A727D68AFE; Tue, 5 Apr 2022 08:24:07 +0200 (CEST) Date: Tue, 5 Apr 2022 08:24:07 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Hector Martin , Sven Peter , Keith Busch , Sagi Grimberg , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver Message-ID: <20220405062407.GA24330@lst.de> References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-7-sven@svenpeter.dev> <20220324061620.GA12330@lst.de> <18f3a7e6-16d1-2037-90e7-1c0b1b2fbb1c@marcan.st> <20220404155924.GA9764@lst.de> <367fe64f-0e57-b264-969a-c7cee6344f05@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <367fe64f-0e57-b264-969a-c7cee6344f05@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 04, 2022 at 12:29:08PM -0600, Jens Axboe wrote: > Please reconsider how you phrase these objections. Saying the code is > "completely unreadable" because it's _1_ character over your hard limit > is just nonsense, and not a very productive way to deal with this. Agreed and sorry. I actually had a piece of code in mind that formatted all the comments way to long that really tripped me off, but it wans't this one. Too much going on right now.